mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
89a6966726
In file `api/types/client.go`, some of the "*Options{}" structs own a
`Filters` field while some else have the name of `Filter`, this commit
will rename all `Filter` to `Filters` for consistency. Also `Filters`
is consistent with API with format `/xxx?filters=xxx`, that's why
`Filters` is the right name.
Signed-off-by: Zhang Wei <zhangwei555@huawei.com>
96 lines
2.6 KiB
Go
96 lines
2.6 KiB
Go
package client
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/json"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"net/http"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/docker/docker/api/types"
|
|
"github.com/docker/docker/api/types/filters"
|
|
"golang.org/x/net/context"
|
|
)
|
|
|
|
func TestContainerListError(t *testing.T) {
|
|
client := &Client{
|
|
client: newMockClient(errorMock(http.StatusInternalServerError, "Server error")),
|
|
}
|
|
_, err := client.ContainerList(context.Background(), types.ContainerListOptions{})
|
|
if err == nil || err.Error() != "Error response from daemon: Server error" {
|
|
t.Fatalf("expected a Server Error, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestContainerList(t *testing.T) {
|
|
expectedURL := "/containers/json"
|
|
expectedFilters := `{"before":{"container":true},"label":{"label1":true,"label2":true}}`
|
|
client := &Client{
|
|
client: newMockClient(func(req *http.Request) (*http.Response, error) {
|
|
if !strings.HasPrefix(req.URL.Path, expectedURL) {
|
|
return nil, fmt.Errorf("Expected URL '%s', got '%s'", expectedURL, req.URL)
|
|
}
|
|
query := req.URL.Query()
|
|
all := query.Get("all")
|
|
if all != "1" {
|
|
return nil, fmt.Errorf("all not set in URL query properly. Expected '1', got %s", all)
|
|
}
|
|
limit := query.Get("limit")
|
|
if limit != "0" {
|
|
return nil, fmt.Errorf("limit should have not be present in query. Expected '0', got %s", limit)
|
|
}
|
|
since := query.Get("since")
|
|
if since != "container" {
|
|
return nil, fmt.Errorf("since not set in URL query properly. Expected 'container', got %s", since)
|
|
}
|
|
before := query.Get("before")
|
|
if before != "" {
|
|
return nil, fmt.Errorf("before should have not be present in query, go %s", before)
|
|
}
|
|
size := query.Get("size")
|
|
if size != "1" {
|
|
return nil, fmt.Errorf("size not set in URL query properly. Expected '1', got %s", size)
|
|
}
|
|
filters := query.Get("filters")
|
|
if filters != expectedFilters {
|
|
return nil, fmt.Errorf("expected filters incoherent '%v' with actual filters %v", expectedFilters, filters)
|
|
}
|
|
|
|
b, err := json.Marshal([]types.Container{
|
|
{
|
|
ID: "container_id1",
|
|
},
|
|
{
|
|
ID: "container_id2",
|
|
},
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return &http.Response{
|
|
StatusCode: http.StatusOK,
|
|
Body: ioutil.NopCloser(bytes.NewReader(b)),
|
|
}, nil
|
|
}),
|
|
}
|
|
|
|
filters := filters.NewArgs()
|
|
filters.Add("label", "label1")
|
|
filters.Add("label", "label2")
|
|
filters.Add("before", "container")
|
|
containers, err := client.ContainerList(context.Background(), types.ContainerListOptions{
|
|
Size: true,
|
|
All: true,
|
|
Since: "container",
|
|
Filters: filters,
|
|
})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(containers) != 2 {
|
|
t.Fatalf("expected 2 containers, got %v", containers)
|
|
}
|
|
}
|