mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
3f6e3a0885
This fix tries to address issue raised in #23973 where the `docker rename` does not update namedIndex and linkIndex, thus resulting in failures when the linked containers are referenced later on. This fix updates the namedIndex and linkIndex during the `docker rename` and fixes the issue. An integration test has been added to cover the changes in this fix. This fix fixes #23973. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
122 lines
3 KiB
Go
122 lines
3 KiB
Go
package daemon
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
|
|
"github.com/Sirupsen/logrus"
|
|
dockercontainer "github.com/docker/docker/container"
|
|
"github.com/docker/libnetwork"
|
|
)
|
|
|
|
// ContainerRename changes the name of a container, using the oldName
|
|
// to find the container. An error is returned if newName is already
|
|
// reserved.
|
|
func (daemon *Daemon) ContainerRename(oldName, newName string) error {
|
|
var (
|
|
sid string
|
|
sb libnetwork.Sandbox
|
|
)
|
|
|
|
if oldName == "" || newName == "" {
|
|
return fmt.Errorf("Neither old nor new names may be empty")
|
|
}
|
|
|
|
if newName[0] != '/' {
|
|
newName = "/" + newName
|
|
}
|
|
|
|
container, err := daemon.GetContainer(oldName)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
oldName = container.Name
|
|
oldIsAnonymousEndpoint := container.NetworkSettings.IsAnonymousEndpoint
|
|
|
|
if oldName == newName {
|
|
return fmt.Errorf("Renaming a container with the same name as its current name")
|
|
}
|
|
|
|
container.Lock()
|
|
defer container.Unlock()
|
|
|
|
links := map[string]*dockercontainer.Container{}
|
|
for k, v := range daemon.linkIndex.children(container) {
|
|
if !strings.HasPrefix(k, oldName) {
|
|
return fmt.Errorf("Linked container %s does not match parent %s", k, oldName)
|
|
}
|
|
links[strings.TrimPrefix(k, oldName)] = v
|
|
}
|
|
|
|
if newName, err = daemon.reserveName(container.ID, newName); err != nil {
|
|
return fmt.Errorf("Error when allocating new name: %v", err)
|
|
}
|
|
|
|
for k, v := range links {
|
|
daemon.nameIndex.Reserve(newName+k, v.ID)
|
|
daemon.linkIndex.link(container, v, newName+k)
|
|
}
|
|
|
|
container.Name = newName
|
|
container.NetworkSettings.IsAnonymousEndpoint = false
|
|
|
|
defer func() {
|
|
if err != nil {
|
|
container.Name = oldName
|
|
container.NetworkSettings.IsAnonymousEndpoint = oldIsAnonymousEndpoint
|
|
daemon.reserveName(container.ID, oldName)
|
|
for k, v := range links {
|
|
daemon.nameIndex.Reserve(oldName+k, v.ID)
|
|
daemon.linkIndex.link(container, v, oldName+k)
|
|
daemon.linkIndex.unlink(newName+k, v, container)
|
|
daemon.nameIndex.Release(newName + k)
|
|
}
|
|
daemon.releaseName(newName)
|
|
}
|
|
}()
|
|
|
|
for k, v := range links {
|
|
daemon.linkIndex.unlink(oldName+k, v, container)
|
|
daemon.nameIndex.Release(oldName + k)
|
|
}
|
|
daemon.releaseName(oldName)
|
|
if err = container.ToDisk(); err != nil {
|
|
return err
|
|
}
|
|
|
|
attributes := map[string]string{
|
|
"oldName": oldName,
|
|
}
|
|
|
|
if !container.Running {
|
|
daemon.LogContainerEventWithAttributes(container, "rename", attributes)
|
|
return nil
|
|
}
|
|
|
|
defer func() {
|
|
if err != nil {
|
|
container.Name = oldName
|
|
container.NetworkSettings.IsAnonymousEndpoint = oldIsAnonymousEndpoint
|
|
if e := container.ToDisk(); e != nil {
|
|
logrus.Errorf("%s: Failed in writing to Disk on rename failure: %v", container.ID, e)
|
|
}
|
|
}
|
|
}()
|
|
|
|
sid = container.NetworkSettings.SandboxID
|
|
if daemon.netController != nil {
|
|
sb, err = daemon.netController.SandboxByID(sid)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
err = sb.Rename(strings.TrimPrefix(container.Name, "/"))
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
daemon.LogContainerEventWithAttributes(container, "rename", attributes)
|
|
return nil
|
|
}
|