kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity
moby--moby/daemon
History
Doug Davis 12b6083c8f Remove panic in nat package on invalid hostport 
Closes #14621

This one grew to be much more than I expected so here's the story... :-)
- when a bad port string (e.g. xxx80) is passed into container.create()
  via the API it wasn't being checked until we tried to start the container.
- While starting the container we trid to parse 'xxx80' in nat.Int()
  and would panic on the strconv.ParseUint().  We should (almost) never panic.
- In trying to remove the panic I decided to make it so that we, instead,
  checked the string during the NewPort() constructor.  This means that
  I had to change all casts from 'string' to 'Port' to use NewPort() instead.
  Which is a good thing anyway, people shouldn't assume they know the
  internal format of types like that, in general.
- This meant I had to go and add error checks on all calls to NewPort().
  To avoid changing the testcases too much I create newPortNoError() **JUST**
  for the testcase uses where we know the port string is ok.
- After all of that I then went back and added a check during container.create()
  to check the port string so we'll report the error as soon as we get the
  data.
- If, somehow, the bad string does get into the metadata we will generate
  an error during container.start() but I can't test for that because
  the container.create() catches it now.  But I did add a testcase for that.

Signed-off-by: Doug Davis <dug@us.ibm.com>
2015-07-17 13:02:54 -07:00
..
events
execdriver Merge pull request #14604 from Microsoft/10662-addbridge 2015-07-16 08:44:40 -07:00
graphdriver Fix some formatting calls 2015-07-15 12:25:50 -07:00
logger Add new logging driver: fluentd 2015-06-26 11:03:11 +09:00
network Move /nat to /pkg/nat 2015-06-30 17:43:17 +01:00
attach.go Fix regression in containers attach/wsattach api, return not found before hijacking 2015-07-01 18:16:17 +02:00
changes.go
commit.go Windows: Graph driver implementation 2015-07-10 14:33:11 -07:00
config.go Merge pull request #14604 from Microsoft/10662-addbridge 2015-07-16 08:44:40 -07:00
config_experimental.go Vendoring in libnetwork for native multihost networking 2015-06-22 04:15:41 -07:00
config_linux.go Windows: Plumb through -b on daemon 2015-07-13 12:41:48 -07:00
config_stub.go Vendoring in libnetwork for native multihost networking 2015-06-22 04:15:41 -07:00
config_windows.go Windows: Plumb through -b on daemon 2015-07-13 12:41:48 -07:00
container.go Windows: Graph driver implementation 2015-07-10 14:33:11 -07:00
container_unit_test.go Move /nat to /pkg/nat 2015-06-30 17:43:17 +01:00
container_unix.go Remove panic in nat package on invalid hostport 2015-07-17 13:02:54 -07:00
container_windows.go Windows: Plumb through -b on daemon 2015-07-13 12:41:48 -07:00
copy.go
create.go Windows: Graph driver implementation 2015-07-10 14:33:11 -07:00
daemon.go Windows: Move daemon check back centrally 2015-07-11 12:42:46 -07:00
daemon_aufs.go Move graph.SetupInitLayer to daemon package where it is used 2015-06-16 16:50:56 -07:00
daemon_btrfs.go Windows: Don't build Linux graph drivers 2015-06-08 15:09:33 -07:00
daemon_devicemapper.go Windows: Don't build Linux graph drivers 2015-06-08 15:09:33 -07:00
daemon_no_aufs.go Windows: Don't build Linux graph drivers 2015-06-08 15:09:33 -07:00
daemon_overlay.go Windows: Don't build Linux graph drivers 2015-06-08 15:09:33 -07:00
daemon_test.go Allow to downgrade local volumes from > 1.7 to 1.6. 2015-06-09 18:04:59 -07:00
daemon_unit_test.go
daemon_unix.go Remove panic in nat package on invalid hostport 2015-07-17 13:02:54 -07:00
daemon_windows.go Windows: Plumb through -b on daemon 2015-07-13 12:41:48 -07:00
daemon_zfs.go Windows: No ZFS graphdriver 2015-05-14 15:57:45 -07:00
debugtrap_unix.go Windows: Win32 event for sigusr1 linux equivalence 2015-07-06 18:58:53 -07:00
debugtrap_unsupported.go Windows: Win32 event for sigusr1 linux equivalence 2015-07-06 18:58:53 -07:00
debugtrap_windows.go Windows: Win32 event for sigusr1 linux equivalence 2015-07-06 18:58:53 -07:00
delete.go Show error message when todisk failed 2015-07-02 18:24:35 +08:00
exec.go Quieter debug logging for clean exec commands 2015-07-13 10:36:36 -07:00
exec_linux.go
exec_windows.go
export.go Cleanup container LogEvent calls 2015-06-01 12:39:28 -07:00
history.go
image_delete.go Windows: Graph driver implementation 2015-07-10 14:33:11 -07:00
info.go Windows: Fix docker info not to SIGSEGV 2015-07-09 16:37:54 -07:00
inspect.go Remove exec config from container after exit 2015-07-08 10:55:42 -07:00
kill.go Cleanup container LogEvent calls 2015-06-01 12:39:28 -07:00
list.go Remove panic in nat package on invalid hostport 2015-07-17 13:02:54 -07:00
logdrivers_linux.go Add new logging driver: fluentd 2015-06-26 11:03:11 +09:00
logdrivers_windows.go Windows: Factor out syslog and journald 2015-05-14 10:34:09 -07:00
logs.go Fix goroutine leak on logs -f with no output 2015-06-04 13:56:40 -07:00
monitor.go Show error message when todisk failed 2015-07-02 18:24:35 +08:00
pause.go Cleanup container LogEvent calls 2015-06-01 12:39:28 -07:00
README.md
rename.go Cleanup container LogEvent calls 2015-06-01 12:39:28 -07:00
resize.go
restart.go Cleanup container LogEvent calls 2015-06-01 12:39:28 -07:00
start.go Add verify config to verifyContainerSettings 2015-06-13 09:31:19 +08:00
state.go Validate status= filter to docker ps 2015-07-02 16:12:42 -07:00
state_test.go
stats.go Stats API to retrieve nw stats from libnetwork 2015-07-01 11:15:16 -07:00
stats_collector_unix.go Windows: Factor out stat collector 2015-06-01 09:11:03 -07:00
stats_collector_windows.go Windows: Factor out stat collector 2015-06-01 09:11:03 -07:00
stats_linux.go Updates libcontainer to v2.2.1 2015-06-15 18:18:38 -04:00
stats_windows.go Fixes content-type/length for stats stream=false 2015-06-12 13:06:06 -04:00
stop.go Cleanup container LogEvent calls 2015-06-01 12:39:28 -07:00
top.go Cleanup container LogEvent calls 2015-06-01 12:39:28 -07:00
unpause.go Cleanup container LogEvent calls 2015-06-01 12:39:28 -07:00
utils_nounix.go Windows: Tidy up daemon\utils*.go 2015-07-09 18:47:32 -07:00
utils_test.go Windows: Tidy up daemon\utils*.go 2015-07-09 18:47:32 -07:00
utils_unix.go Windows: Tidy up daemon\utils*.go 2015-07-09 18:47:32 -07:00
volumes.go Fix read-write check for volumes. 2015-07-14 15:50:43 -07:00
volumes_experimental.go Mount bind volumes coming from the old volumes configuration. 2015-05-28 14:06:17 -07:00
volumes_experimental_unit_test.go apply selinux labels volume patch on volumes refactor 2015-05-27 12:50:16 -07:00
volumes_linux.go Allow to downgrade local volumes from > 1.7 to 1.6. 2015-06-09 18:04:59 -07:00
volumes_stubs.go Mount bind volumes coming from the old volumes configuration. 2015-05-28 14:06:17 -07:00
volumes_stubs_unit_test.go apply selinux labels volume patch on volumes refactor 2015-05-27 12:50:16 -07:00
volumes_unit_test.go Allow named volumes for external drivers. 2015-05-21 20:34:17 -07:00
volumes_windows.go Allow to downgrade local volumes from > 1.7 to 1.6. 2015-06-09 18:04:59 -07:00
wait.go Move container.WaitStop, AttachWithLogs and WsAttachWithLogs to daemon service in api server 2015-05-11 19:56:41 +02:00

README.md

This directory contains code pertaining to running containers and storing images

Code pertaining to running containers:

  • execdriver
  • networkdriver

Code pertaining to storing images:

  • graphdriver