1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
moby--moby/pkg/integration
Aaron Lehmann 2704fd9156 Fix race in RunCommandWithOutputForDuration
This function was starting a goroutine that modifies one of its return
values. The intent is for the goroutine to only influence the return
value when it's causing the function to return, but it's racy and can
also modify the return value when the function is returning due to the
timeout. Fix the goroutine to not modify return values directly.

Also, give the channel a buffer so that the goroutine doesn't block
forever after a timeout.

Fixes #18305

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2015-12-03 16:34:01 -08:00
..
checker Vendoring shakers library and update go-check 2015-10-17 14:28:08 +02:00
dockerCmd_utils.go Move dockerCmd… to pkg/integration… 2015-09-13 13:09:04 +02:00
dockerCmd_utils_test.go Build and test Docker on IBM Power and Z using gccgo. Enable CI on Power and Z. 2015-11-14 03:16:45 +00:00
utils.go Fix race in RunCommandWithOutputForDuration 2015-12-03 16:34:01 -08:00
utils_test.go Fixes 16556 CI failures 2015-09-24 11:19:00 -07:00