mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
27345e8f8f
Previously, failing to disable IPv6 router advertisement prevented the daemon to
start.
An issue was reported by a user that started docker using `systemd-nspawn "machine"`,
which produced an error;
failed to start daemon: Error initializing network controller:
Error creating default "bridge" network: libnetwork:
Unable to disable IPv6 router advertisement:
open /proc/sys/net/ipv6/conf/docker0/accept_ra: read-only file system
This patch changes the error to a log-message instead.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
86 lines
2.6 KiB
Go
86 lines
2.6 KiB
Go
package bridge
|
|
|
|
import (
|
|
"fmt"
|
|
"io/ioutil"
|
|
"os"
|
|
"path/filepath"
|
|
|
|
"github.com/docker/docker/pkg/parsers/kernel"
|
|
"github.com/docker/libnetwork/netutils"
|
|
"github.com/sirupsen/logrus"
|
|
"github.com/vishvananda/netlink"
|
|
)
|
|
|
|
// SetupDevice create a new bridge interface/
|
|
func setupDevice(config *networkConfiguration, i *bridgeInterface) error {
|
|
var setMac bool
|
|
|
|
// We only attempt to create the bridge when the requested device name is
|
|
// the default one.
|
|
if config.BridgeName != DefaultBridgeName && config.DefaultBridge {
|
|
return NonDefaultBridgeExistError(config.BridgeName)
|
|
}
|
|
|
|
// Set the bridgeInterface netlink.Bridge.
|
|
i.Link = &netlink.Bridge{
|
|
LinkAttrs: netlink.LinkAttrs{
|
|
Name: config.BridgeName,
|
|
},
|
|
}
|
|
|
|
// Only set the bridge's MAC address if the kernel version is > 3.3, as it
|
|
// was not supported before that.
|
|
kv, err := kernel.GetKernelVersion()
|
|
if err != nil {
|
|
logrus.Errorf("Failed to check kernel versions: %v. Will not assign a MAC address to the bridge interface", err)
|
|
} else {
|
|
setMac = kv.Kernel > 3 || (kv.Kernel == 3 && kv.Major >= 3)
|
|
}
|
|
|
|
if setMac {
|
|
hwAddr := netutils.GenerateRandomMAC()
|
|
i.Link.Attrs().HardwareAddr = hwAddr
|
|
logrus.Debugf("Setting bridge mac address to %s", hwAddr)
|
|
}
|
|
|
|
if err = i.nlh.LinkAdd(i.Link); err != nil {
|
|
logrus.Debugf("Failed to create bridge %s via netlink. Trying ioctl", config.BridgeName)
|
|
return ioctlCreateBridge(config.BridgeName, setMac)
|
|
}
|
|
|
|
return err
|
|
}
|
|
|
|
func setupDefaultSysctl(config *networkConfiguration, i *bridgeInterface) error {
|
|
// Disable IPv6 router advertisements originating on the bridge
|
|
sysPath := filepath.Join("/proc/sys/net/ipv6/conf/", config.BridgeName, "accept_ra")
|
|
if _, err := os.Stat(sysPath); err != nil {
|
|
logrus.
|
|
WithField("bridge", config.BridgeName).
|
|
WithField("syspath", sysPath).
|
|
Info("failed to read ipv6 net.ipv6.conf.<bridge>.accept_ra")
|
|
return nil
|
|
}
|
|
if err := ioutil.WriteFile(sysPath, []byte{'0', '\n'}, 0644); err != nil {
|
|
logrus.WithError(err).Warn("unable to disable IPv6 router advertisement")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// SetupDeviceUp ups the given bridge interface.
|
|
func setupDeviceUp(config *networkConfiguration, i *bridgeInterface) error {
|
|
err := i.nlh.LinkSetUp(i.Link)
|
|
if err != nil {
|
|
return fmt.Errorf("Failed to set link up for %s: %v", config.BridgeName, err)
|
|
}
|
|
|
|
// Attempt to update the bridge interface to refresh the flags status,
|
|
// ignoring any failure to do so.
|
|
if lnk, err := i.nlh.LinkByName(config.BridgeName); err == nil {
|
|
i.Link = lnk
|
|
} else {
|
|
logrus.Warnf("Failed to retrieve link for interface (%s): %v", config.BridgeName, err)
|
|
}
|
|
return nil
|
|
}
|