mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
795a58fb44
If an image has been tagged to multiple repos and tags, 'docker rmi -f IMAGE_ID' will just untag one random repo instead of untagging all and deleting the image. This patch implement this. This commit is composed of: *untag all names and delete the image *add test to this feature *modify commandline/cli.md to explain this Signed-off-by: Deng Guangxing <dengguangxing@huawei.com>
210 lines
6.9 KiB
Go
210 lines
6.9 KiB
Go
package main
|
|
|
|
import (
|
|
"os/exec"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestRmiWithContainerFails(t *testing.T) {
|
|
errSubstr := "is using it"
|
|
|
|
// create a container
|
|
runCmd := exec.Command(dockerBinary, "run", "-d", "busybox", "true")
|
|
out, _, err := runCommandWithOutput(runCmd)
|
|
if err != nil {
|
|
t.Fatalf("failed to create a container: %s, %v", out, err)
|
|
}
|
|
|
|
cleanedContainerID := strings.TrimSpace(out)
|
|
|
|
// try to delete the image
|
|
runCmd = exec.Command(dockerBinary, "rmi", "busybox")
|
|
out, _, err = runCommandWithOutput(runCmd)
|
|
if err == nil {
|
|
t.Fatalf("Container %q is using image, should not be able to rmi: %q", cleanedContainerID, out)
|
|
}
|
|
if !strings.Contains(out, errSubstr) {
|
|
t.Fatalf("Container %q is using image, error message should contain %q: %v", cleanedContainerID, errSubstr, out)
|
|
}
|
|
|
|
// make sure it didn't delete the busybox name
|
|
images, _, _ := dockerCmd(t, "images")
|
|
if !strings.Contains(images, "busybox") {
|
|
t.Fatalf("The name 'busybox' should not have been removed from images: %q", images)
|
|
}
|
|
|
|
deleteContainer(cleanedContainerID)
|
|
|
|
logDone("rmi - container using image while rmi, should not remove image name")
|
|
}
|
|
|
|
func TestRmiTag(t *testing.T) {
|
|
imagesBefore, _, _ := dockerCmd(t, "images", "-a")
|
|
dockerCmd(t, "tag", "busybox", "utest:tag1")
|
|
dockerCmd(t, "tag", "busybox", "utest/docker:tag2")
|
|
dockerCmd(t, "tag", "busybox", "utest:5000/docker:tag3")
|
|
{
|
|
imagesAfter, _, _ := dockerCmd(t, "images", "-a")
|
|
if strings.Count(imagesAfter, "\n") != strings.Count(imagesBefore, "\n")+3 {
|
|
t.Fatalf("before: %q\n\nafter: %q\n", imagesBefore, imagesAfter)
|
|
}
|
|
}
|
|
dockerCmd(t, "rmi", "utest/docker:tag2")
|
|
{
|
|
imagesAfter, _, _ := dockerCmd(t, "images", "-a")
|
|
if strings.Count(imagesAfter, "\n") != strings.Count(imagesBefore, "\n")+2 {
|
|
t.Fatalf("before: %q\n\nafter: %q\n", imagesBefore, imagesAfter)
|
|
}
|
|
|
|
}
|
|
dockerCmd(t, "rmi", "utest:5000/docker:tag3")
|
|
{
|
|
imagesAfter, _, _ := dockerCmd(t, "images", "-a")
|
|
if strings.Count(imagesAfter, "\n") != strings.Count(imagesBefore, "\n")+1 {
|
|
t.Fatalf("before: %q\n\nafter: %q\n", imagesBefore, imagesAfter)
|
|
}
|
|
|
|
}
|
|
dockerCmd(t, "rmi", "utest:tag1")
|
|
{
|
|
imagesAfter, _, _ := dockerCmd(t, "images", "-a")
|
|
if strings.Count(imagesAfter, "\n") != strings.Count(imagesBefore, "\n")+0 {
|
|
t.Fatalf("before: %q\n\nafter: %q\n", imagesBefore, imagesAfter)
|
|
}
|
|
|
|
}
|
|
logDone("rmi - tag,rmi - tagging the same images multiple times then removing tags")
|
|
}
|
|
|
|
func TestRmiImgIDForce(t *testing.T) {
|
|
runCmd := exec.Command(dockerBinary, "run", "-d", "busybox", "/bin/sh", "-c", "mkdir '/busybox-test'")
|
|
out, _, err := runCommandWithOutput(runCmd)
|
|
if err != nil {
|
|
t.Fatalf("failed to create a container:%s, %v", out, err)
|
|
}
|
|
containerID := strings.TrimSpace(out)
|
|
runCmd = exec.Command(dockerBinary, "commit", containerID, "busybox-test")
|
|
out, _, err = runCommandWithOutput(runCmd)
|
|
if err != nil {
|
|
t.Fatalf("failed to commit a new busybox-test:%s, %v", out, err)
|
|
}
|
|
|
|
imagesBefore, _, _ := dockerCmd(t, "images", "-a")
|
|
dockerCmd(t, "tag", "busybox-test", "utest:tag1")
|
|
dockerCmd(t, "tag", "busybox-test", "utest:tag2")
|
|
dockerCmd(t, "tag", "busybox-test", "utest/docker:tag3")
|
|
dockerCmd(t, "tag", "busybox-test", "utest:5000/docker:tag4")
|
|
{
|
|
imagesAfter, _, _ := dockerCmd(t, "images", "-a")
|
|
if strings.Count(imagesAfter, "\n") != strings.Count(imagesBefore, "\n")+4 {
|
|
t.Fatalf("tag busybox to create 4 more images with same imageID; docker images shows: %q\n", imagesAfter)
|
|
}
|
|
}
|
|
out, _, _ = dockerCmd(t, "inspect", "-f", "{{.Id}}", "busybox-test")
|
|
imgID := strings.TrimSpace(out)
|
|
dockerCmd(t, "rmi", "-f", imgID)
|
|
{
|
|
imagesAfter, _, _ := dockerCmd(t, "images", "-a")
|
|
if strings.Contains(imagesAfter, imgID[:12]) {
|
|
t.Fatalf("rmi -f %s failed, image still exists: %q\n\n", imgID, imagesAfter)
|
|
}
|
|
|
|
}
|
|
logDone("rmi - imgID,rmi -f imgID delete all tagged repos of specific imgID")
|
|
}
|
|
|
|
func TestRmiTagWithExistingContainers(t *testing.T) {
|
|
defer deleteAllContainers()
|
|
|
|
container := "test-delete-tag"
|
|
newtag := "busybox:newtag"
|
|
bb := "busybox:latest"
|
|
if out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "tag", bb, newtag)); err != nil {
|
|
t.Fatalf("Could not tag busybox: %v: %s", err, out)
|
|
}
|
|
if out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "--name", container, bb, "/bin/true")); err != nil {
|
|
t.Fatalf("Could not run busybox: %v: %s", err, out)
|
|
}
|
|
out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "rmi", newtag))
|
|
if err != nil {
|
|
t.Fatalf("Could not remove tag %s: %v: %s", newtag, err, out)
|
|
}
|
|
if d := strings.Count(out, "Untagged: "); d != 1 {
|
|
t.Fatalf("Expected 1 untagged entry got %d: %q", d, out)
|
|
}
|
|
|
|
logDone("rmi - delete tag with existing containers")
|
|
}
|
|
|
|
func TestRmiForceWithExistingContainers(t *testing.T) {
|
|
defer deleteAllContainers()
|
|
|
|
image := "busybox-clone"
|
|
|
|
cmd := exec.Command(dockerBinary, "build", "--no-cache", "-t", image, "-")
|
|
cmd.Stdin = strings.NewReader(`FROM busybox
|
|
MAINTAINER foo`)
|
|
|
|
if out, _, err := runCommandWithOutput(cmd); err != nil {
|
|
t.Fatalf("Could not build %s: %s, %v", image, out, err)
|
|
}
|
|
|
|
if out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "--name", "test-force-rmi", image, "/bin/true")); err != nil {
|
|
t.Fatalf("Could not run container: %s, %v", out, err)
|
|
}
|
|
|
|
out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "rmi", "-f", image))
|
|
if err != nil {
|
|
t.Fatalf("Could not remove image %s: %s, %v", image, out, err)
|
|
}
|
|
|
|
logDone("rmi - force delete with existing containers")
|
|
}
|
|
|
|
func TestRmiWithMultipleRepositories(t *testing.T) {
|
|
defer deleteAllContainers()
|
|
newRepo := "127.0.0.1:5000/busybox"
|
|
oldRepo := "busybox"
|
|
newTag := "busybox:test"
|
|
cmd := exec.Command(dockerBinary, "tag", oldRepo, newRepo)
|
|
out, _, err := runCommandWithOutput(cmd)
|
|
if err != nil {
|
|
t.Fatalf("Could not tag busybox: %v: %s", err, out)
|
|
}
|
|
cmd = exec.Command(dockerBinary, "run", "--name", "test", oldRepo, "touch", "/home/abcd")
|
|
out, _, err = runCommandWithOutput(cmd)
|
|
if err != nil {
|
|
t.Fatalf("failed to run container: %v, output: %s", err, out)
|
|
}
|
|
cmd = exec.Command(dockerBinary, "commit", "test", newTag)
|
|
out, _, err = runCommandWithOutput(cmd)
|
|
if err != nil {
|
|
t.Fatalf("failed to commit container: %v, output: %s", err, out)
|
|
}
|
|
cmd = exec.Command(dockerBinary, "rmi", newTag)
|
|
out, _, err = runCommandWithOutput(cmd)
|
|
if err != nil {
|
|
t.Fatalf("failed to remove image: %v, output: %s", err, out)
|
|
}
|
|
if !strings.Contains(out, "Untagged: "+newTag) {
|
|
t.Fatalf("Could not remove image %s: %s, %v", newTag, out, err)
|
|
}
|
|
|
|
logDone("rmi - delete a image which its dependency tagged to multiple repositories success")
|
|
}
|
|
|
|
func TestRmiBlank(t *testing.T) {
|
|
// try to delete a blank image name
|
|
runCmd := exec.Command(dockerBinary, "rmi", "")
|
|
out, _, err := runCommandWithOutput(runCmd)
|
|
|
|
if err == nil {
|
|
t.Fatal("Should have failed to delete '' image")
|
|
}
|
|
|
|
if strings.Contains(out, "No such image") {
|
|
t.Fatalf("Wrong error message generated: %s", out)
|
|
}
|
|
logDone("rmi - blank image name")
|
|
}
|