mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
d3eca4451d
Makes `docker volume ls` and `docker volume inspect` ask the volume drivers rather than only using what is cached locally. Previously in order to use a volume from an external driver, one would either have to use `docker volume create` or have a container that is already using that volume for it to be visible to the other volume API's. For keeping uniqueness of volume names in the daemon, names are bound to a driver on a first come first serve basis. If two drivers have a volume with the same name, the first one is chosen, and a warning is logged about the second one. Adds 2 new methods to the plugin API, `List` and `Get`. If a plugin does not implement these endpoints, a user will not be able to find the specified volumes as well requests go through the drivers. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
122 lines
3.3 KiB
Go
122 lines
3.3 KiB
Go
package volumedrivers
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"net/url"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/docker/docker/pkg/plugins"
|
|
"github.com/docker/go-connections/tlsconfig"
|
|
)
|
|
|
|
func TestVolumeRequestError(t *testing.T) {
|
|
mux := http.NewServeMux()
|
|
server := httptest.NewServer(mux)
|
|
defer server.Close()
|
|
|
|
mux.HandleFunc("/VolumeDriver.Create", func(w http.ResponseWriter, r *http.Request) {
|
|
w.Header().Set("Content-Type", "application/vnd.docker.plugins.v1+json")
|
|
fmt.Fprintln(w, `{"Err": "Cannot create volume"}`)
|
|
})
|
|
|
|
mux.HandleFunc("/VolumeDriver.Remove", func(w http.ResponseWriter, r *http.Request) {
|
|
w.Header().Set("Content-Type", "application/vnd.docker.plugins.v1+json")
|
|
fmt.Fprintln(w, `{"Err": "Cannot remove volume"}`)
|
|
})
|
|
|
|
mux.HandleFunc("/VolumeDriver.Mount", func(w http.ResponseWriter, r *http.Request) {
|
|
w.Header().Set("Content-Type", "application/vnd.docker.plugins.v1+json")
|
|
fmt.Fprintln(w, `{"Err": "Cannot mount volume"}`)
|
|
})
|
|
|
|
mux.HandleFunc("/VolumeDriver.Unmount", func(w http.ResponseWriter, r *http.Request) {
|
|
w.Header().Set("Content-Type", "application/vnd.docker.plugins.v1+json")
|
|
fmt.Fprintln(w, `{"Err": "Cannot unmount volume"}`)
|
|
})
|
|
|
|
mux.HandleFunc("/VolumeDriver.Path", func(w http.ResponseWriter, r *http.Request) {
|
|
w.Header().Set("Content-Type", "application/vnd.docker.plugins.v1+json")
|
|
fmt.Fprintln(w, `{"Err": "Unknown volume"}`)
|
|
})
|
|
|
|
mux.HandleFunc("/VolumeDriver.List", func(w http.ResponseWriter, r *http.Request) {
|
|
w.Header().Set("Content-Type", "application/vnd.docker.plugins.v1+json")
|
|
fmt.Fprintln(w, `{"Err": "Cannot list volumes"}`)
|
|
})
|
|
|
|
mux.HandleFunc("/VolumeDriver.Get", func(w http.ResponseWriter, r *http.Request) {
|
|
w.Header().Set("Content-Type", "application/vnd.docker.plugins.v1+json")
|
|
fmt.Fprintln(w, `{"Err": "Cannot get volume"}`)
|
|
})
|
|
|
|
u, _ := url.Parse(server.URL)
|
|
client, err := plugins.NewClient("tcp://"+u.Host, tlsconfig.Options{InsecureSkipVerify: true})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
driver := volumeDriverProxy{client}
|
|
|
|
if err = driver.Create("volume", nil); err == nil {
|
|
t.Fatal("Expected error, was nil")
|
|
}
|
|
|
|
if !strings.Contains(err.Error(), "Cannot create volume") {
|
|
t.Fatalf("Unexpected error: %v\n", err)
|
|
}
|
|
|
|
_, err = driver.Mount("volume")
|
|
if err == nil {
|
|
t.Fatal("Expected error, was nil")
|
|
}
|
|
|
|
if !strings.Contains(err.Error(), "Cannot mount volume") {
|
|
t.Fatalf("Unexpected error: %v\n", err)
|
|
}
|
|
|
|
err = driver.Unmount("volume")
|
|
if err == nil {
|
|
t.Fatal("Expected error, was nil")
|
|
}
|
|
|
|
if !strings.Contains(err.Error(), "Cannot unmount volume") {
|
|
t.Fatalf("Unexpected error: %v\n", err)
|
|
}
|
|
|
|
err = driver.Remove("volume")
|
|
if err == nil {
|
|
t.Fatal("Expected error, was nil")
|
|
}
|
|
|
|
if !strings.Contains(err.Error(), "Cannot remove volume") {
|
|
t.Fatalf("Unexpected error: %v\n", err)
|
|
}
|
|
|
|
_, err = driver.Path("volume")
|
|
if err == nil {
|
|
t.Fatal("Expected error, was nil")
|
|
}
|
|
|
|
if !strings.Contains(err.Error(), "Unknown volume") {
|
|
t.Fatalf("Unexpected error: %v\n", err)
|
|
}
|
|
|
|
_, err = driver.List()
|
|
if err == nil {
|
|
t.Fatal("Expected error, was nil")
|
|
}
|
|
if !strings.Contains(err.Error(), "Cannot list volumes") {
|
|
t.Fatalf("Unexpected error: %v\n", err)
|
|
}
|
|
|
|
_, err = driver.Get("volume")
|
|
if err == nil {
|
|
t.Fatal("Expected error, was nil")
|
|
}
|
|
if !strings.Contains(err.Error(), "Cannot get volume") {
|
|
t.Fatalf("Unexpected error: %v\n", err)
|
|
}
|
|
}
|