mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
da3d3b97eb
Common patterns: - Multiple images were built with same name but only one cleanup. - Containers were deleted after images. - Images not removed after retagging. Signed-off-by: Tõnis Tiigi <tonistiigi@gmail.com> (github: tonistiigi)
325 lines
10 KiB
Go
325 lines
10 KiB
Go
package main
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"reflect"
|
|
"testing"
|
|
|
|
"github.com/docker/docker/vendor/src/github.com/kr/pty"
|
|
)
|
|
|
|
// save a repo and try to load it using stdout
|
|
func TestSaveAndLoadRepoStdout(t *testing.T) {
|
|
runCmd := exec.Command(dockerBinary, "run", "-d", "busybox", "true")
|
|
out, _, err := runCommandWithOutput(runCmd)
|
|
if err != nil {
|
|
t.Fatalf("failed to create a container: %s, %v", out, err)
|
|
}
|
|
|
|
cleanedContainerID := stripTrailingCharacters(out)
|
|
|
|
repoName := "foobar-save-load-test"
|
|
|
|
inspectCmd := exec.Command(dockerBinary, "inspect", cleanedContainerID)
|
|
if out, _, err = runCommandWithOutput(inspectCmd); err != nil {
|
|
t.Fatalf("output should've been a container id: %s, %v", out, err)
|
|
}
|
|
|
|
commitCmd := exec.Command(dockerBinary, "commit", cleanedContainerID, repoName)
|
|
if out, _, err = runCommandWithOutput(commitCmd); err != nil {
|
|
t.Fatalf("failed to commit container: %s, %v", out, err)
|
|
}
|
|
|
|
inspectCmd = exec.Command(dockerBinary, "inspect", repoName)
|
|
before, _, err := runCommandWithOutput(inspectCmd)
|
|
if err != nil {
|
|
t.Fatalf("the repo should exist before saving it: %s, %v", before, err)
|
|
}
|
|
|
|
saveCmdTemplate := `%v save %v > /tmp/foobar-save-load-test.tar`
|
|
saveCmdFinal := fmt.Sprintf(saveCmdTemplate, dockerBinary, repoName)
|
|
saveCmd := exec.Command("bash", "-c", saveCmdFinal)
|
|
if out, _, err = runCommandWithOutput(saveCmd); err != nil {
|
|
t.Fatalf("failed to save repo: %s, %v", out, err)
|
|
}
|
|
|
|
deleteImages(repoName)
|
|
|
|
loadCmdFinal := `cat /tmp/foobar-save-load-test.tar | docker load`
|
|
loadCmd := exec.Command("bash", "-c", loadCmdFinal)
|
|
if out, _, err = runCommandWithOutput(loadCmd); err != nil {
|
|
t.Fatalf("failed to load repo: %s, %v", out, err)
|
|
}
|
|
|
|
inspectCmd = exec.Command(dockerBinary, "inspect", repoName)
|
|
after, _, err := runCommandWithOutput(inspectCmd)
|
|
if err != nil {
|
|
t.Fatalf("the repo should exist after loading it: %s %v", after, err)
|
|
}
|
|
|
|
if before != after {
|
|
t.Fatalf("inspect is not the same after a save / load")
|
|
}
|
|
|
|
deleteContainer(cleanedContainerID)
|
|
deleteImages(repoName)
|
|
|
|
os.Remove("/tmp/foobar-save-load-test.tar")
|
|
|
|
logDone("save - save/load a repo using stdout")
|
|
|
|
pty, tty, err := pty.Open()
|
|
if err != nil {
|
|
t.Fatalf("Could not open pty: %v", err)
|
|
}
|
|
cmd := exec.Command(dockerBinary, "save", repoName)
|
|
cmd.Stdin = tty
|
|
cmd.Stdout = tty
|
|
cmd.Stderr = tty
|
|
if err := cmd.Start(); err != nil {
|
|
t.Fatalf("start err: %v", err)
|
|
}
|
|
if err := cmd.Wait(); err == nil {
|
|
t.Fatal("did not break writing to a TTY")
|
|
}
|
|
|
|
buf := make([]byte, 1024)
|
|
|
|
n, err := pty.Read(buf)
|
|
if err != nil {
|
|
t.Fatal("could not read tty output")
|
|
}
|
|
|
|
if !bytes.Contains(buf[:n], []byte("Cowardly refusing")) {
|
|
t.Fatal("help output is not being yielded", out)
|
|
}
|
|
|
|
logDone("save - do not save to a tty")
|
|
}
|
|
|
|
func TestSaveSingleTag(t *testing.T) {
|
|
repoName := "foobar-save-single-tag-test"
|
|
|
|
tagCmdFinal := fmt.Sprintf("%v tag busybox:latest %v:latest", dockerBinary, repoName)
|
|
tagCmd := exec.Command("bash", "-c", tagCmdFinal)
|
|
if out, _, err := runCommandWithOutput(tagCmd); err != nil {
|
|
t.Fatalf("failed to tag repo: %s, %v", out, err)
|
|
}
|
|
|
|
idCmdFinal := fmt.Sprintf("%v images -q --no-trunc %v", dockerBinary, repoName)
|
|
idCmd := exec.Command("bash", "-c", idCmdFinal)
|
|
out, _, err := runCommandWithOutput(idCmd)
|
|
if err != nil {
|
|
t.Fatalf("failed to get repo ID: %s, %v", out, err)
|
|
}
|
|
|
|
cleanedImageID := stripTrailingCharacters(out)
|
|
|
|
saveCmdFinal := fmt.Sprintf("%v save %v:latest | tar t | grep -E '(^repositories$|%v)'", dockerBinary, repoName, cleanedImageID)
|
|
saveCmd := exec.Command("bash", "-c", saveCmdFinal)
|
|
if out, _, err = runCommandWithOutput(saveCmd); err != nil {
|
|
t.Fatalf("failed to save repo with image ID and 'repositories' file: %s, %v", out, err)
|
|
}
|
|
|
|
deleteImages(repoName)
|
|
|
|
logDone("save - save a specific image:tag")
|
|
}
|
|
|
|
func TestSaveImageId(t *testing.T) {
|
|
repoName := "foobar-save-image-id-test"
|
|
|
|
tagCmdFinal := fmt.Sprintf("%v tag scratch:latest %v:latest", dockerBinary, repoName)
|
|
tagCmd := exec.Command("bash", "-c", tagCmdFinal)
|
|
if out, _, err := runCommandWithOutput(tagCmd); err != nil {
|
|
t.Fatalf("failed to tag repo: %s, %v", out, err)
|
|
}
|
|
|
|
idLongCmdFinal := fmt.Sprintf("%v images -q --no-trunc %v", dockerBinary, repoName)
|
|
idLongCmd := exec.Command("bash", "-c", idLongCmdFinal)
|
|
out, _, err := runCommandWithOutput(idLongCmd)
|
|
if err != nil {
|
|
t.Fatalf("failed to get repo ID: %s, %v", out, err)
|
|
}
|
|
|
|
cleanedLongImageID := stripTrailingCharacters(out)
|
|
|
|
idShortCmdFinal := fmt.Sprintf("%v images -q %v", dockerBinary, repoName)
|
|
idShortCmd := exec.Command("bash", "-c", idShortCmdFinal)
|
|
out, _, err = runCommandWithOutput(idShortCmd)
|
|
if err != nil {
|
|
t.Fatalf("failed to get repo short ID: %s, %v", out, err)
|
|
}
|
|
|
|
cleanedShortImageID := stripTrailingCharacters(out)
|
|
|
|
saveCmdFinal := fmt.Sprintf("%v save %v | tar t | grep %v", dockerBinary, cleanedShortImageID, cleanedLongImageID)
|
|
saveCmd := exec.Command("bash", "-c", saveCmdFinal)
|
|
if out, _, err = runCommandWithOutput(saveCmd); err != nil {
|
|
t.Fatalf("failed to save repo with image ID: %s, %v", out, err)
|
|
}
|
|
|
|
deleteImages(repoName)
|
|
|
|
logDone("save - save a image by ID")
|
|
}
|
|
|
|
// save a repo and try to load it using flags
|
|
func TestSaveAndLoadRepoFlags(t *testing.T) {
|
|
runCmd := exec.Command(dockerBinary, "run", "-d", "busybox", "true")
|
|
out, _, err := runCommandWithOutput(runCmd)
|
|
if err != nil {
|
|
t.Fatalf("failed to create a container: %s, %v", out, err)
|
|
}
|
|
|
|
cleanedContainerID := stripTrailingCharacters(out)
|
|
|
|
repoName := "foobar-save-load-test"
|
|
|
|
inspectCmd := exec.Command(dockerBinary, "inspect", cleanedContainerID)
|
|
if out, _, err = runCommandWithOutput(inspectCmd); err != nil {
|
|
t.Fatalf("output should've been a container id: %s, %v", out, err)
|
|
}
|
|
|
|
commitCmd := exec.Command(dockerBinary, "commit", cleanedContainerID, repoName)
|
|
if out, _, err = runCommandWithOutput(commitCmd); err != nil {
|
|
t.Fatalf("failed to commit container: %s, %v", out, err)
|
|
}
|
|
|
|
inspectCmd = exec.Command(dockerBinary, "inspect", repoName)
|
|
before, _, err := runCommandWithOutput(inspectCmd)
|
|
if err != nil {
|
|
t.Fatalf("the repo should exist before saving it: %s, %v", before, err)
|
|
}
|
|
|
|
saveCmdTemplate := `%v save -o /tmp/foobar-save-load-test.tar %v`
|
|
saveCmdFinal := fmt.Sprintf(saveCmdTemplate, dockerBinary, repoName)
|
|
saveCmd := exec.Command("bash", "-c", saveCmdFinal)
|
|
if out, _, err = runCommandWithOutput(saveCmd); err != nil {
|
|
t.Fatalf("failed to save repo: %s, %v", out, err)
|
|
}
|
|
|
|
deleteImages(repoName)
|
|
|
|
loadCmdFinal := `docker load -i /tmp/foobar-save-load-test.tar`
|
|
loadCmd := exec.Command("bash", "-c", loadCmdFinal)
|
|
if out, _, err = runCommandWithOutput(loadCmd); err != nil {
|
|
t.Fatalf("failed to load repo: %s, %v", out, err)
|
|
}
|
|
|
|
inspectCmd = exec.Command(dockerBinary, "inspect", repoName)
|
|
after, _, err := runCommandWithOutput(inspectCmd)
|
|
if err != nil {
|
|
t.Fatalf("the repo should exist after loading it: %s, %v", after, err)
|
|
}
|
|
|
|
if before != after {
|
|
t.Fatalf("inspect is not the same after a save / load")
|
|
}
|
|
|
|
deleteContainer(cleanedContainerID)
|
|
deleteImages(repoName)
|
|
|
|
os.Remove("/tmp/foobar-save-load-test.tar")
|
|
|
|
logDone("save - save a repo using -o && load a repo using -i")
|
|
}
|
|
|
|
func TestSaveMultipleNames(t *testing.T) {
|
|
repoName := "foobar-save-multi-name-test"
|
|
|
|
// Make one image
|
|
tagCmdFinal := fmt.Sprintf("%v tag scratch:latest %v-one:latest", dockerBinary, repoName)
|
|
tagCmd := exec.Command("bash", "-c", tagCmdFinal)
|
|
if out, _, err := runCommandWithOutput(tagCmd); err != nil {
|
|
t.Fatalf("failed to tag repo: %s, %v", out, err)
|
|
}
|
|
defer deleteImages(repoName + "-one")
|
|
|
|
// Make two images
|
|
tagCmdFinal = fmt.Sprintf("%v tag scratch:latest %v-two:latest", dockerBinary, repoName)
|
|
tagCmd = exec.Command("bash", "-c", tagCmdFinal)
|
|
if out, _, err := runCommandWithOutput(tagCmd); err != nil {
|
|
t.Fatalf("failed to tag repo: %s, %v", out, err)
|
|
}
|
|
defer deleteImages(repoName + "-two")
|
|
|
|
saveCmdFinal := fmt.Sprintf("%v save %v-one %v-two:latest | tar xO repositories | grep -q -E '(-one|-two)'", dockerBinary, repoName, repoName)
|
|
saveCmd := exec.Command("bash", "-c", saveCmdFinal)
|
|
if out, _, err := runCommandWithOutput(saveCmd); err != nil {
|
|
t.Fatalf("failed to save multiple repos: %s, %v", out, err)
|
|
}
|
|
|
|
deleteImages(repoName)
|
|
|
|
logDone("save - save by multiple names")
|
|
}
|
|
|
|
// Issue #6722 #5892 ensure directories are included in changes
|
|
func TestSaveDirectoryPermissions(t *testing.T) {
|
|
layerEntries := []string{"opt/", "opt/a/", "opt/a/b/", "opt/a/b/c"}
|
|
layerEntriesAUFS := []string{"./", ".wh..wh.aufs", ".wh..wh.orph/", ".wh..wh.plnk/", "opt/", "opt/a/", "opt/a/b/", "opt/a/b/c"}
|
|
|
|
name := "save-directory-permissions"
|
|
tmpDir, err := ioutil.TempDir("", "save-layers-with-directories")
|
|
if err != nil {
|
|
t.Errorf("failed to create temporary directory: %s", err)
|
|
}
|
|
extractionDirectory := filepath.Join(tmpDir, "image-extraction-dir")
|
|
os.Mkdir(extractionDirectory, 0777)
|
|
|
|
defer os.RemoveAll(tmpDir)
|
|
defer deleteImages(name)
|
|
_, err = buildImage(name,
|
|
`FROM busybox
|
|
RUN adduser -D user && mkdir -p /opt/a/b && chown -R user:user /opt/a
|
|
RUN touch /opt/a/b/c && chown user:user /opt/a/b/c`,
|
|
true)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
saveCmdFinal := fmt.Sprintf("%s save %s | tar -xf - -C %s", dockerBinary, name, extractionDirectory)
|
|
saveCmd := exec.Command("bash", "-c", saveCmdFinal)
|
|
if out, _, err := runCommandWithOutput(saveCmd); err != nil {
|
|
t.Errorf("failed to save and extract image: %s", out)
|
|
}
|
|
|
|
dirs, err := ioutil.ReadDir(extractionDirectory)
|
|
if err != nil {
|
|
t.Errorf("failed to get a listing of the layer directories: %s", err)
|
|
}
|
|
|
|
found := false
|
|
for _, entry := range dirs {
|
|
if entry.IsDir() {
|
|
layerPath := filepath.Join(extractionDirectory, entry.Name(), "layer.tar")
|
|
|
|
f, err := os.Open(layerPath)
|
|
if err != nil {
|
|
t.Fatalf("failed to open %s: %s", layerPath, err)
|
|
}
|
|
|
|
entries, err := ListTar(f)
|
|
if err != nil {
|
|
t.Fatalf("encountered error while listing tar entries: %s", err)
|
|
}
|
|
|
|
if reflect.DeepEqual(entries, layerEntries) || reflect.DeepEqual(entries, layerEntriesAUFS) {
|
|
found = true
|
|
break
|
|
}
|
|
}
|
|
}
|
|
|
|
if !found {
|
|
t.Fatalf("failed to find the layer with the right content listing")
|
|
}
|
|
|
|
logDone("save - ensure directories exist in exported layers")
|
|
}
|