mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
b3b14b97b1
Propagation type changes must be done as a separate call, in the same way as read only bind mounts. To fix this: 1. Ensure propagation type change flags aren't included in other calls. 2. Apply propagation type change in a separate call. Also: * Make it clear which parameters are ignored by passing them as empty. * Add tests to ensure Mount options are applied correctly. Fixes #30415 Signed-off-by: Steven Hartland <steven.hartland@multiplay.co.uk>
56 lines
1.5 KiB
Go
56 lines
1.5 KiB
Go
package mount
|
|
|
|
import (
|
|
"syscall"
|
|
)
|
|
|
|
const (
|
|
// ptypes is the set propagation types.
|
|
ptypes = syscall.MS_SHARED | syscall.MS_PRIVATE | syscall.MS_SLAVE | syscall.MS_UNBINDABLE
|
|
|
|
// pflags is the full set valid flags for a change propagation call.
|
|
pflags = ptypes | syscall.MS_REC | syscall.MS_SILENT
|
|
|
|
// broflags is the combination of bind and read only
|
|
broflags = syscall.MS_BIND | syscall.MS_RDONLY
|
|
)
|
|
|
|
// isremount returns true if either device name or flags identify a remount request, false otherwise.
|
|
func isremount(device string, flags uintptr) bool {
|
|
switch {
|
|
// We treat device "" and "none" as a remount request to provide compatibility with
|
|
// requests that don't explicitly set MS_REMOUNT such as those manipulating bind mounts.
|
|
case flags&syscall.MS_REMOUNT != 0, device == "", device == "none":
|
|
return true
|
|
default:
|
|
return false
|
|
}
|
|
}
|
|
|
|
func mount(device, target, mType string, flags uintptr, data string) error {
|
|
oflags := flags &^ ptypes
|
|
if !isremount(device, flags) {
|
|
// Initial call applying all non-propagation flags.
|
|
if err := syscall.Mount(device, target, mType, oflags, data); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
if flags&ptypes != 0 {
|
|
// Change the propagation type.
|
|
if err := syscall.Mount("", target, "", flags&pflags, ""); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
if oflags&broflags == broflags {
|
|
// Remount the bind to apply read only.
|
|
return syscall.Mount("", target, "", oflags|syscall.MS_REMOUNT, "")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func unmount(target string, flag int) error {
|
|
return syscall.Unmount(target, flag)
|
|
}
|