mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
a8608b5b67
About github.com/opencontainers/runc/libcontainer/user:
According to 195d8d544a
this package has two functions:
- Have a static implementation of user lookup, which is now supported in the
os/user stdlib package with the osusergo build tag, but wasn't at the time.
- Have extra functions that os/user doesn't have, but none of those are used
in homedir.
Since https://github.com/moby/moby/pull/11287, homedir depended directly on
libcontainer's user package for CurrentUser().
This is being replaced with os/user.Current(), because all of our static
binaries are compiled with the osusergo tag, and for dynamic libraries it
is more correct to use libc's implementation than parsing /etc/passwd.
About github.com/docker/docker/pkg/idtools:
Only dependency was from GetStatic() which uses idtools.LookupUID(uid).
The implementation of idtools.LookupUID just calls to
github.com/opencontainers/runc/libcontainer/user.LookupUid or fallbacks
to exec-ing to getent (since https://github.com/moby/moby/pull/27599).
This patch replaces calls to homedir.GetStatic by homedir.Get(), opting out
of supporting nss lookups in static binaries via exec-ing to getent for
the homedir package.
If homedir package users need to support nss lookups, they are advised
to compile dynamically instead.
Signed-off-by: Tibor Vass <tibor@docker.com>
27 lines
1.1 KiB
Go
27 lines
1.1 KiB
Go
package gcplogs // import "github.com/docker/docker/daemon/logger/gcplogs"
|
|
|
|
import (
|
|
"os"
|
|
|
|
"github.com/docker/docker/dockerversion"
|
|
"github.com/docker/docker/pkg/homedir"
|
|
"github.com/sirupsen/logrus"
|
|
)
|
|
|
|
// ensureHomeIfIAmStatic ensure $HOME to be set if dockerversion.IAmStatic is "true".
|
|
// See issue #29344: gcplogs segfaults (static binary)
|
|
// If HOME is not set, logging.NewClient() will call os/user.Current() via oauth2/google.
|
|
// If compiling statically, make sure osusergo build tag is also used to prevent a segfault
|
|
// due to a glibc issue that won't be fixed in a short term
|
|
// (see golang/go#13470, https://sourceware.org/bugzilla/show_bug.cgi?id=19341).
|
|
// So we forcibly set HOME so as to avoid call to os/user/Current()
|
|
func ensureHomeIfIAmStatic() error {
|
|
// Note: dockerversion.IAmStatic is only available for linux.
|
|
// So we need to use them in this gcplogging_linux.go rather than in gcplogging.go
|
|
if dockerversion.IAmStatic == "true" && os.Getenv("HOME") == "" {
|
|
home := homedir.Get()
|
|
logrus.Warnf("gcplogs requires HOME to be set for static daemon binary. Forcibly setting HOME to %s.", home)
|
|
os.Setenv("HOME", home)
|
|
}
|
|
return nil
|
|
}
|