1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
moby--moby/hack/dockerfile/install
Sebastiaan van Stijn 1d9da1b233
Fix bug in gotestsum installer causing dependencies to not be downloaded
Building gotestsum started to fail after the repository removed some
dependencies on master.

What happens is that first, we `go get` the package (with go modules disabled);

    GO111MODULE=off go get -d gotest.tools/gotestsum

Which gets the latest version from master, and fetches the dependencies used
on master. Then we checkout the version we want to install (for example `v0.3.5`)
and run go build.

However, `v0.3.5` depends on logrus, and given that we ran `go get` for `master`,
that dependency was not fetched, and build fails.

This patch modifies the installer to use go modules (alternatively we could
probably run `go get .` after checking out the `v0.3.5` version),

We need to modify all installers, as it looks like this is a standard pattern
we use, but other dependencies were not failing (yet), so this patch only
addresses the immediate failure.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2020-05-16 18:52:53 +02:00
..
containerd.installer update containerd to v1.3.4 2020-04-16 14:36:38 +08:00
dockercli.installer Use build args to override binary commits in dockerfile 2019-10-10 14:52:57 -05:00
golangci_lint.installer ci: update golangci-lint v1.23.8 2020-03-10 11:52:40 +01:00
gotestsum.installer Fix bug in gotestsum installer causing dependencies to not be downloaded 2020-05-16 18:52:53 +02:00
install.sh Shell scripts: fix bare variables 2019-01-10 02:50:47 +01:00
proxy.installer vendor: bump libnetwork ef149a924dfde2e506ea3cb3f617d7d0fa96b8ee 2020-03-19 17:15:58 +08:00
rootlesskit.installer bump up rootlesskit to v0.9.5 2020-05-11 10:25:00 +09:00
runc.installer update runc binary to v1.0.0-rc10 (CVE-2019-19921) 2020-01-25 03:55:39 +09:00
shfmt.installer validate: add shfmt 2020-03-03 12:25:51 +09:00
tini.installer Use build args to override binary commits in dockerfile 2019-10-10 14:52:57 -05:00
tomlv.installer Use build args to override binary commits in dockerfile 2019-10-10 14:52:57 -05:00
vndr.installer bump vndr v0.1.1 2020-02-07 13:37:45 +01:00