1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
moby--moby/integration
Brian Goff 88c0271605 Don't set default platform on container create
This fixes a regression based on expectations of the runtime:

```
docker pull arm32v7/alpine
docker run arm32v7/alpine
```

Without this change, the `docker run` will fail due to platform
matching on non-arm32v7 systems, even though the image could run
(assuming the system is setup correctly).

This also emits a warning to make sure that the user is aware that a
platform that does not match the default platform of the system is being
run, for the cases like:

```
docker pull --platform armhf busybox
docker run busybox
```

Not typically an issue if the requests are done together like that, but
if the image was already there and someone did `docker run` without an
explicit `--platform`, they may very well be expecting to run a native
version of the image instead of the armhf one.

This warning does add some extra noise in the case of platform specific
images being run, such as `arm32v7/alpine`, but this can be supressed by
explicitly setting the platform.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2020-10-20 20:17:23 +00:00
..
build Merge pull request #41430 from TBBle/40444-update-gowinio-for-8gB-file-fix 2020-09-24 11:16:10 -07:00
config integration/config: add check for removing non-existing config 2020-04-14 18:31:38 +02:00
container Don't set default platform on container create 2020-10-20 20:17:23 +00:00
distribution bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
image Windows: Enable more integration tests 2020-09-20 22:09:27 +03:00
internal Replace service "Capabilities" w/ add/drop API 2020-07-27 10:09:42 -07:00
network Upgrading the versions of images in Dockerfile. 2020-06-30 12:24:06 +08:00
plugin fix integration test case TestExternalGraphDriver failed in mips arch 2020-09-15 10:04:00 +08:00
secret integration/secret: add check for empty list not producing an error 2020-04-14 18:31:36 +02:00
service Replace service "Capabilities" w/ add/drop API 2020-07-27 10:09:42 -07:00
session bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
system test-integration: support more rootless tests 2020-03-16 17:37:38 +09:00
testdata/https
volume Windows: Enable more integration tests 2020-09-20 22:09:27 +03:00
doc.go Add canonical import comment 2018-02-05 16:51:57 -05:00