mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
614d82390c
In the present code, each driver package provides a `New()` method which constructs a driver of its type, which is then registered with the controller. However, this is not suitable for the `drivers/remote` package, since it does not provide a (singleton) driver, but a mechanism for drivers to be added dynamically. As a result, the implementation is oddly dual-purpose, and a spurious `"remote"` driver is added to the controller's list of available drivers. Instead, it is better to provide the registration callback to each package and let it register its own driver or drivers. That way, the singleton driver packages can construct one and register it, and the remote package can hook the callback up with whatever the dynamic driver mechanism turns out to be. NB there are some method signature changes; in particular to controller.New, which can return an error if the built-in driver packages fail to initialise. Signed-off-by: Michael Bridgen <mikeb@squaremobius.net>
26 lines
600 B
Go
26 lines
600 B
Go
package libnetwork
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/docker/libnetwork/driverapi"
|
|
)
|
|
|
|
func TestDriverRegistration(t *testing.T) {
|
|
bridgeNetType := "bridge"
|
|
c, err := New()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
err = c.(*controller).RegisterDriver(bridgeNetType, nil)
|
|
if err == nil {
|
|
t.Fatalf("Expecting the RegisterDriver to fail for %s", bridgeNetType)
|
|
}
|
|
if _, ok := err.(driverapi.ErrActiveRegistration); !ok {
|
|
t.Fatalf("Failed for unexpected reason: %v", err)
|
|
}
|
|
err = c.(*controller).RegisterDriver("test-dummy", nil)
|
|
if err != nil {
|
|
t.Fatalf("Test failed with an error %v", err)
|
|
}
|
|
}
|