mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
4669418731
This adds a new filter argument to the volume prune endpoint "all".
When this is not set, or it is a false-y value, then only anonymous
volumes are considered for pruning.
When `all` is set to a truth-y value, you get the old behavior.
This is an API change, but I think one that is what most people would
want.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 618f26ccbc)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
63 lines
1.6 KiB
Go
63 lines
1.6 KiB
Go
package service
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/docker/docker/api/types/filters"
|
|
"gotest.tools/v3/assert"
|
|
"gotest.tools/v3/assert/cmp"
|
|
)
|
|
|
|
func TestFilterWithPrune(t *testing.T) {
|
|
f := filters.NewArgs()
|
|
assert.NilError(t, withPrune(f))
|
|
assert.Check(t, cmp.Len(f.Get("label"), 1))
|
|
assert.Check(t, f.Match("label", AnonymousLabel))
|
|
|
|
f = filters.NewArgs()
|
|
f.Add("label", "foo=bar")
|
|
f.Add("label", "bar=baz")
|
|
assert.NilError(t, withPrune(f))
|
|
|
|
assert.Check(t, cmp.Len(f.Get("label"), 3))
|
|
assert.Check(t, f.Match("label", AnonymousLabel))
|
|
assert.Check(t, f.Match("label", "foo=bar"))
|
|
assert.Check(t, f.Match("label", "bar=baz"))
|
|
|
|
f = filters.NewArgs()
|
|
f.Add("label", "foo=bar")
|
|
f.Add("all", "1")
|
|
assert.NilError(t, withPrune(f))
|
|
|
|
assert.Check(t, cmp.Len(f.Get("label"), 1))
|
|
assert.Check(t, f.Match("label", "foo=bar"))
|
|
|
|
f = filters.NewArgs()
|
|
f.Add("label", "foo=bar")
|
|
f.Add("all", "true")
|
|
assert.NilError(t, withPrune(f))
|
|
|
|
assert.Check(t, cmp.Len(f.Get("label"), 1))
|
|
assert.Check(t, f.Match("label", "foo=bar"))
|
|
|
|
f = filters.NewArgs()
|
|
f.Add("all", "0")
|
|
assert.NilError(t, withPrune(f))
|
|
assert.Check(t, cmp.Len(f.Get("label"), 1))
|
|
assert.Check(t, f.Match("label", AnonymousLabel))
|
|
|
|
f = filters.NewArgs()
|
|
f.Add("all", "false")
|
|
assert.NilError(t, withPrune(f))
|
|
assert.Check(t, cmp.Len(f.Get("label"), 1))
|
|
assert.Check(t, f.Match("label", AnonymousLabel))
|
|
|
|
f = filters.NewArgs()
|
|
f.Add("all", "")
|
|
assert.ErrorContains(t, withPrune(f), "invalid filter 'all'")
|
|
|
|
f = filters.NewArgs()
|
|
f.Add("all", "1")
|
|
f.Add("all", "0")
|
|
assert.ErrorContains(t, withPrune(f), "invalid filter 'all")
|
|
}
|