mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
fb6ee865a9
when a container failed to start, saves the error message into State.Error so that it can be retrieved when calling `docker inspect` instead of having to look at the log Docker-DCO-1.1-Signed-off-by: Daniel, Dao Quang Minh <dqminh89@gmail.com> (github: dqminh)
111 lines
3.6 KiB
Go
111 lines
3.6 KiB
Go
package main
|
|
|
|
import (
|
|
"fmt"
|
|
"os/exec"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
// Regression test for https://github.com/docker/docker/issues/7843
|
|
func TestStartAttachReturnsOnError(t *testing.T) {
|
|
defer deleteAllContainers()
|
|
|
|
cmd(t, "run", "-d", "--name", "test", "busybox")
|
|
cmd(t, "stop", "test")
|
|
|
|
// Expect this to fail because the above container is stopped, this is what we want
|
|
if _, err := runCommand(exec.Command(dockerBinary, "run", "-d", "--name", "test2", "--link", "test:test", "busybox")); err == nil {
|
|
t.Fatal("Expected error but got none")
|
|
}
|
|
|
|
ch := make(chan struct{})
|
|
go func() {
|
|
// Attempt to start attached to the container that won't start
|
|
// This should return an error immediately since the container can't be started
|
|
if _, err := runCommand(exec.Command(dockerBinary, "start", "-a", "test2")); err == nil {
|
|
t.Fatal("Expected error but got none")
|
|
}
|
|
close(ch)
|
|
}()
|
|
|
|
select {
|
|
case <-ch:
|
|
case <-time.After(time.Second):
|
|
t.Fatalf("Attach did not exit properly")
|
|
}
|
|
|
|
logDone("start - error on start with attach exits")
|
|
}
|
|
|
|
// gh#8555: Exit code should be passed through when using start -a
|
|
func TestStartAttachCorrectExitCode(t *testing.T) {
|
|
defer deleteAllContainers()
|
|
|
|
runCmd := exec.Command(dockerBinary, "run", "-d", "busybox", "sh", "-c", "sleep 2; exit 1")
|
|
out, _, _, err := runCommandWithStdoutStderr(runCmd)
|
|
if err != nil {
|
|
t.Fatalf("failed to run container: %v, output: %q", err, out)
|
|
}
|
|
|
|
out = stripTrailingCharacters(out)
|
|
|
|
// make sure the container has exited before trying the "start -a"
|
|
waitCmd := exec.Command(dockerBinary, "wait", out)
|
|
if out, _, err = runCommandWithOutput(waitCmd); err != nil {
|
|
t.Fatal(out, err)
|
|
}
|
|
|
|
startCmd := exec.Command(dockerBinary, "start", "-a", out)
|
|
startOut, exitCode, err := runCommandWithOutput(startCmd)
|
|
if err != nil && !strings.Contains("exit status 1", fmt.Sprintf("%s", err)) {
|
|
t.Fatalf("start command failed unexpectedly with error: %v, output: %q", err, startOut)
|
|
}
|
|
if exitCode != 1 {
|
|
t.Fatalf("start -a did not respond with proper exit code: expected 1, got %d", exitCode)
|
|
}
|
|
|
|
logDone("start - correct exit code returned with -a")
|
|
}
|
|
|
|
func TestStartRecordError(t *testing.T) {
|
|
defer deleteAllContainers()
|
|
|
|
// when container runs successfully, we should not have state.Error
|
|
cmd(t, "run", "-d", "-p", "9999:9999", "--name", "test", "busybox", "top")
|
|
stateErr, err := inspectField("test", "State.Error")
|
|
if err != nil {
|
|
t.Fatalf("Failed to inspect %q state's error, got error %q", "test", err)
|
|
}
|
|
if stateErr != "" {
|
|
t.Fatalf("Expected to not have state error but got state.Error(%q)", stateErr)
|
|
}
|
|
|
|
// Expect this to fail and records error because of ports conflict
|
|
out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-d", "--name", "test2", "-p", "9999:9999", "busybox", "top"))
|
|
if err == nil {
|
|
t.Fatalf("Expected error but got none, output %q", out)
|
|
}
|
|
stateErr, err = inspectField("test2", "State.Error")
|
|
if err != nil {
|
|
t.Fatalf("Failed to inspect %q state's error, got error %q", "test2", err)
|
|
}
|
|
expected := "port is already allocated"
|
|
if stateErr == "" || !strings.Contains(stateErr, expected) {
|
|
t.Fatalf("State.Error(%q) does not include %q", stateErr, expected)
|
|
}
|
|
|
|
// Expect the conflict to be resolved when we stop the initial container
|
|
cmd(t, "stop", "test")
|
|
cmd(t, "start", "test2")
|
|
stateErr, err = inspectField("test2", "State.Error")
|
|
if err != nil {
|
|
t.Fatalf("Failed to inspect %q state's error, got error %q", "test", err)
|
|
}
|
|
if stateErr != "" {
|
|
t.Fatalf("Expected to not have state error but got state.Error(%q)", stateErr)
|
|
}
|
|
|
|
logDone("start - set state error when start fails")
|
|
}
|