1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Moby Project - a collaborative project for the container ecosystem to assemble container-based systems
Find a file
Mark Feit 3a938df4b5
Make the network allocator handle IPv4 blocks too small for network/broadcast addresses.
This was originally in docker/libnetwork#2624, which has been closed since the
code was moved here.

When creating a new network, IPAM's address allocator attempts to reserve the
network and broadcast addresses on IPv4 networks of all sizes. For RFC 3021
point-to-point networks (IPv4 /31s), this consumes both available addresses and
renders any attempt to allocate an address from the block unsuccessful.

This change prevents those reservations from taking place on IPv4 networks having
two or fewer addresses (i.e., /31s and /32s) while retaining the existing behavior
for larger IPv4 blocks and all IPv6 blocks.

In case you're wondering why anyone would allocate /31s:  I work for a network
service provider.  We use a lot of point-to-point networks.  This cuts our
address space utilization for those by 50%, which makes ARIN happy.

This patch modifies the network allocator to recognize when an network is too
small for network and broadcast addresses and skip those reservations.

There are additional unit tests to make sure the functions involved behave as expected.

Try these out:

 * `docker network create --driver bridge --subnet 10.200.1.0/31 --ip-range 10.200.1.0/31 test-31`
 * `docker network create --driver bridge --subnet 10.200.1.0/32 --ip-range 10.200.1.0/32 test-32`

My installation has been running this patch in production with /31s since March.

Signed-off-by: Mark Feit <mfeit@internet2.edu>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2021-10-27 13:03:19 +02:00
.github
api Makefile: update bfirsh/redoc to 1.14.0, and fix swagger warnings 2021-09-24 17:23:55 +02:00
builder buildkit: normalize build target and local platform 2021-10-19 17:11:06 +02:00
cli
client Merge pull request #42770 from thaJeztah/eventtype_enums 2021-08-28 00:23:56 +09:00
cmd Allow switching Windows runtimes. 2021-09-23 17:44:04 +00:00
container refactor: move from io/ioutil to io and os package 2021-08-27 14:56:57 +08:00
contrib dockerd-rootless.sh: Fix variable not double quotes cause unexpected behavior 2021-10-18 00:11:03 +08:00
daemon daemon: fix TestVerifyPlatformContainerResources not capturing variable 2021-10-20 09:57:54 +02:00
distribution Merge pull request #42782 from dkkb/McGrady/code_improvement 2021-08-30 13:19:08 +02:00
dockerversion
docs
errdefs
hack CI: update docker-py to 5.0.3 2021-10-20 09:57:11 +02:00
image refactor: move from io/ioutil to io and os package 2021-08-27 14:56:57 +08:00
integration Fix race in TestCreateServiceSecretFileMode, TestCreateServiceConfigFileMode 2021-10-27 10:55:54 +02:00
integration-cli refactor: move from io/ioutil to io and os package 2021-08-27 14:56:57 +08:00
internal/test/suite
layer refactor: move from io/ioutil to io and os package 2021-08-27 14:56:57 +08:00
libcontainerd refactor: move from io/ioutil to io and os package 2021-08-27 14:56:57 +08:00
libnetwork Make the network allocator handle IPv4 blocks too small for network/broadcast addresses. 2021-10-27 13:03:19 +02:00
oci oci/caps: limit available capabilities to current environment 2021-10-15 16:12:26 +02:00
opts
patches
pkg Merge pull request #41215 from cpuguy83/better_plugin_errors 2021-10-24 12:37:07 +09:00
plugin refactor: move from io/ioutil to io and os package 2021-08-27 14:56:57 +08:00
profiles refactor: move from io/ioutil to io and os package 2021-08-27 14:56:57 +08:00
project
quota refactor: move from io/ioutil to io and os package 2021-08-27 14:56:57 +08:00
reference refactor: move from io/ioutil to io and os package 2021-08-27 14:56:57 +08:00
registry Merge pull request #42915 from thaJeztah/registry_cleanup 2021-10-15 10:01:22 +02:00
reports
restartmanager
rootless refactor: move from io/ioutil to io and os package 2021-08-27 14:56:57 +08:00
runconfig refactor: move from io/ioutil to io and os package 2021-08-27 14:56:57 +08:00
testutil Port testutil/daemon to FreeBSD 2021-10-16 09:51:55 +03:00
vendor Merge pull request #42933 from thaJeztah/limit_caps_to_environment 2021-10-20 09:55:08 +02:00
volume refactor: move from io/ioutil to io and os package 2021-08-27 14:56:57 +08:00
.DEREK.yml
.dockerignore
.gitignore
.mailmap
AUTHORS
CHANGELOG.md
codecov.yml
CONTRIBUTING.md
Dockerfile Dockerfile: switch CRIU install to Debian 11 "bullseye" packages 2021-10-15 10:43:15 +02:00
Dockerfile.e2e Update Go to 1.17.2 2021-10-08 15:12:36 +02:00
Dockerfile.simple Update Go to 1.17.2 2021-10-08 15:12:36 +02:00
Dockerfile.windows Update containerd binary to v1.5.7 2021-10-15 12:48:29 +02:00
Jenkinsfile Merge pull request #42765 from thaJeztah/windows_2022_ltsc 2021-08-27 15:52:58 +02:00
LICENSE
MAINTAINERS
Makefile Merge pull request #42880 from thaJeztah/makefile_proxy_vars 2021-09-27 13:30:39 +02:00
NOTICE
poule.yml
README.md
ROADMAP.md
SECURITY.md
TESTING.md
vendor.conf Merge pull request #42933 from thaJeztah/limit_caps_to_environment 2021-10-20 09:55:08 +02:00
VENDORING.md

The Moby Project

Moby Project logo

Moby is an open-source project created by Docker to enable and accelerate software containerization.

It provides a "Lego set" of toolkit components, the framework for assembling them into custom container-based systems, and a place for all container enthusiasts and professionals to experiment and exchange ideas. Components include container build tools, a container registry, orchestration tools, a runtime and more, and these can be used as building blocks in conjunction with other tools and projects.

Principles

Moby is an open project guided by strong principles, aiming to be modular, flexible and without too strong an opinion on user experience. It is open to the community to help set its direction.

  • Modular: the project includes lots of components that have well-defined functions and APIs that work together.
  • Batteries included but swappable: Moby includes enough components to build fully featured container system, but its modular architecture ensures that most of the components can be swapped by different implementations.
  • Usable security: Moby provides secure defaults without compromising usability.
  • Developer focused: The APIs are intended to be functional and useful to build powerful tools. They are not necessarily intended as end user tools but as components aimed at developers. Documentation and UX is aimed at developers not end users.

Audience

The Moby Project is intended for engineers, integrators and enthusiasts looking to modify, hack, fix, experiment, invent and build systems based on containers. It is not for people looking for a commercially supported system, but for people who want to work and learn with open source code.

Relationship with Docker

The components and tools in the Moby Project are initially the open source components that Docker and the community have built for the Docker Project. New projects can be added if they fit with the community goals. Docker is committed to using Moby as the upstream for the Docker Product. However, other projects are also encouraged to use Moby as an upstream, and to reuse the components in diverse ways, and all these uses will be treated in the same way. External maintainers and contributors are welcomed.

The Moby project is not intended as a location for support or feature requests for Docker products, but as a place for contributors to work on open source code, fix bugs, and make the code more useful. The releases are supported by the maintainers, community and users, on a best efforts basis only, and are not intended for customers who want enterprise or commercial support; Docker EE is the appropriate product for these use cases.


Legal

Brought to you courtesy of our legal counsel. For more context, please see the NOTICE document in this repo.

Use and transfer of Moby may be subject to certain restrictions by the United States and other governments.

It is your responsibility to ensure that your use and/or transfer does not violate applicable laws.

For more information, please see https://www.bis.doc.gov

Licensing

Moby is licensed under the Apache License, Version 2.0. See LICENSE for the full license text.