mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
70407ce40c
This fixes a few misuses of `deleteAllContainers()` cleanup method in integration-cli suite by moving call to the beginning of the method and guaranteeing their execution (including panics) with `defer`s. Also added some forgotten cleanup calls while I'm at it. Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
59 lines
1.7 KiB
Go
59 lines
1.7 KiB
Go
package main
|
|
|
|
import (
|
|
"encoding/json"
|
|
"os/exec"
|
|
"testing"
|
|
)
|
|
|
|
func TestInspectApiContainerResponse(t *testing.T) {
|
|
defer deleteAllContainers()
|
|
|
|
runCmd := exec.Command(dockerBinary, "run", "-d", "busybox", "true")
|
|
out, _, err := runCommandWithOutput(runCmd)
|
|
if err != nil {
|
|
t.Fatalf("failed to create a container: %s, %v", out, err)
|
|
}
|
|
|
|
cleanedContainerID := stripTrailingCharacters(out)
|
|
|
|
// test on json marshal version
|
|
// and latest version
|
|
testVersions := []string{"v1.11", "latest"}
|
|
|
|
for _, testVersion := range testVersions {
|
|
endpoint := "/containers/" + cleanedContainerID + "/json"
|
|
if testVersion != "latest" {
|
|
endpoint = "/" + testVersion + endpoint
|
|
}
|
|
body, err := sockRequest("GET", endpoint, nil)
|
|
if err != nil {
|
|
t.Fatalf("sockRequest failed for %s version: %v", testVersion, err)
|
|
}
|
|
|
|
var inspectJSON map[string]interface{}
|
|
if err = json.Unmarshal(body, &inspectJSON); err != nil {
|
|
t.Fatalf("unable to unmarshal body for %s version: %v", testVersion, err)
|
|
}
|
|
|
|
keys := []string{"State", "Created", "Path", "Args", "Config", "Image", "NetworkSettings", "ResolvConfPath", "HostnamePath", "HostsPath", "LogPath", "Name", "Driver", "ExecDriver", "MountLabel", "ProcessLabel", "Volumes", "VolumesRW"}
|
|
|
|
if testVersion == "v1.11" {
|
|
keys = append(keys, "ID")
|
|
} else {
|
|
keys = append(keys, "Id")
|
|
}
|
|
|
|
for _, key := range keys {
|
|
if _, ok := inspectJSON[key]; !ok {
|
|
t.Fatalf("%s does not exist in reponse for %s version", key, testVersion)
|
|
}
|
|
}
|
|
//Issue #6830: type not properly converted to JSON/back
|
|
if _, ok := inspectJSON["Path"].(bool); ok {
|
|
t.Fatalf("Path of `true` should not be converted to boolean `true` via JSON marshalling")
|
|
}
|
|
}
|
|
|
|
logDone("container json - check keys in container json response")
|
|
}
|