mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
a83a769347
TL;DR: check for IsExist(err) after a failed MkdirAll() is both
redundant and wrong -- so two reasons to remove it.
Quoting MkdirAll documentation:
> MkdirAll creates a directory named path, along with any necessary
> parents, and returns nil, or else returns an error. If path
> is already a directory, MkdirAll does nothing and returns nil.
This means two things:
1. If a directory to be created already exists, no error is returned.
2. If the error returned is IsExist (EEXIST), it means there exists
a non-directory with the same name as MkdirAll need to use for
directory. Example: we want to MkdirAll("a/b"), but file "a"
(or "a/b") already exists, so MkdirAll fails.
The above is a theory, based on quoted documentation and my UNIX
knowledge.
3. In practice, though, current MkdirAll implementation [1] returns
ENOTDIR in most of cases described in #2, with the exception when
there is a race between MkdirAll and someone else creating the
last component of MkdirAll argument as a file. In this very case
MkdirAll() will indeed return EEXIST.
Because of #1, IsExist check after MkdirAll is not needed.
Because of #2 and #3, ignoring IsExist error is just plain wrong,
as directory we require is not created. It's cleaner to report
the error now.
Note this error is all over the tree, I guess due to copy-paste,
or trying to follow the same usage pattern as for Mkdir(),
or some not quite correct examples on the Internet.
[v2: a separate aufs commit is merged into this one]
[1] https://github.com/golang/go/blob/f9ed2f75/src/os/path.go
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
|
||
|---|---|---|
| .. | ||
| tags | ||
| export.go | ||
| graph.go | ||
| graph_test.go | ||
| graph_unix.go | ||
| graph_windows.go | ||
| history.go | ||
| import.go | ||
| list.go | ||
| load.go | ||
| load_unsupported.go | ||
| mutex.go | ||
| pools_test.go | ||
| pull.go | ||
| pull_v1.go | ||
| pull_v2.go | ||
| push.go | ||
| push_v1.go | ||
| push_v2.go | ||
| registry.go | ||
| service.go | ||
| tags.go | ||
| tags_unit_test.go | ||