mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
eaad3ee3cf
`time.After` keeps a timer running until the specified duration is completed. It also allocates a new timer on each call. This can wind up leaving lots of uneccessary timers running in the background that are not needed and consume resources. Instead of `time.After`, use `time.NewTimer` so the timer can actually be stopped. In some of these cases it's not a big deal since the duraiton is really short, but in others it is much worse. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
49 lines
1 KiB
Go
49 lines
1 KiB
Go
package container // import "github.com/docker/docker/container"
|
|
|
|
import (
|
|
"time"
|
|
|
|
"github.com/sirupsen/logrus"
|
|
)
|
|
|
|
const (
|
|
loggerCloseTimeout = 10 * time.Second
|
|
)
|
|
|
|
// Reset puts a container into a state where it can be restarted again.
|
|
func (container *Container) Reset(lock bool) {
|
|
if lock {
|
|
container.Lock()
|
|
defer container.Unlock()
|
|
}
|
|
|
|
if err := container.CloseStreams(); err != nil {
|
|
logrus.Errorf("%s: %s", container.ID, err)
|
|
}
|
|
|
|
// Re-create a brand new stdin pipe once the container exited
|
|
if container.Config.OpenStdin {
|
|
container.StreamConfig.NewInputPipes()
|
|
}
|
|
|
|
if container.LogDriver != nil {
|
|
if container.LogCopier != nil {
|
|
exit := make(chan struct{})
|
|
go func() {
|
|
container.LogCopier.Wait()
|
|
close(exit)
|
|
}()
|
|
|
|
timer := time.NewTimer(loggerCloseTimeout)
|
|
defer timer.Stop()
|
|
select {
|
|
case <-timer.C:
|
|
logrus.Warn("Logger didn't exit in time: logs may be truncated")
|
|
case <-exit:
|
|
}
|
|
}
|
|
container.LogDriver.Close()
|
|
container.LogCopier = nil
|
|
container.LogDriver = nil
|
|
}
|
|
}
|