mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
3e6a889cd6
DESCRIPTION: As part of bringing libnetwork bridge driver features in parity with docker/daemon/network/driver/bridge features (Issue #46), this commit addresses the bridge.RequestPort() API. Currenlty docker/api/server.go needs an hold of port allocator in order to reserve a transport port which will be used by the http server on the host machine, so that portallocator does not give out that port when queried by portmapper as part of network driver operations. ISSUE: Current implementation in docker is server.go directly access portmapper and then portallocator from bridge pkg calling bridge.RequestPort(). This also forces that function to trigger portmapper initialization (in case bridge init() was not executed yet), while portmapper life cycle should only be controlled by bridge network driver. We cannot mantain this behavior with libnetwrok as this violates the modularization of networking code which libnetwork is bringing in. FIX: Make portallocator a singleton, now both docker core and portmapper code can initialize it and get the only one instance (Change in docker core code will happen when docker code will migrate to use libnetwork), given it is being used for host specific needs. NOTE: Long term fix is having multiple portallocator instances (so no more singleton) each capable to be in sync with OS regarding current port allocation. When this change comes, no change whould be required on portallocator' clients side, changes will be confined to portallocator package. Signed-off-by: Alessandro Boch <aboch@docker.com> |
||
|---|---|---|
| .. | ||
| bridge.go | ||
| bridge_test.go | ||
| interface.go | ||
| interface_test.go | ||
| network_test.go | ||
| resolvconf.go | ||
| resolvconf_test.go | ||
| setup.go | ||
| setup_device.go | ||
| setup_device_test.go | ||
| setup_fixedcidrv4.go | ||
| setup_fixedcidrv4_test.go | ||
| setup_fixedcidrv6.go | ||
| setup_fixedcidrv6_test.go | ||
| setup_ip_forwarding.go | ||
| setup_ip_forwarding_test.go | ||
| setup_ip_tables.go | ||
| setup_ip_tables_test.go | ||
| setup_ipv4.go | ||
| setup_ipv4_test.go | ||
| setup_ipv6.go | ||
| setup_ipv6_test.go | ||
| setup_verify.go | ||
| setup_verify_test.go | ||