mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
6052f2b396
I noticed that we're using a homegrown package for assertions. The functions are extremely similar to testify, but with enough slight differences to be confusing (for example, Equal takes its arguments in a different order). We already vendor testify, and it's used in a few places by tests. I also found some problems with pkg/testutil/assert. For example, the NotNil function seems to be broken. It checks the argument against "nil", which only works for an interface. If you pass in a nil map or slice, the equality check will fail. In the interest of avoiding NIH, I'm proposing replacing pkg/testutil/assert with testify. The test code looks almost the same, but we avoid the confusion of having two similar but slightly different assertion packages, and having to maintain our own package instead of using a commonly-used one. In the process, I found a few places where the tests should halt if an assertion fails, so I've made those cases (that I noticed) use "require" instead of "assert", and I've vendored the "require" package from testify alongside the already-present "assert" package. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
106 lines
3.5 KiB
Go
106 lines
3.5 KiB
Go
package assert
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"net/url"
|
|
"strings"
|
|
)
|
|
|
|
// httpCode is a helper that returns HTTP code of the response. It returns -1
|
|
// if building a new request fails.
|
|
func httpCode(handler http.HandlerFunc, method, url string, values url.Values) int {
|
|
w := httptest.NewRecorder()
|
|
req, err := http.NewRequest(method, url+"?"+values.Encode(), nil)
|
|
if err != nil {
|
|
return -1
|
|
}
|
|
handler(w, req)
|
|
return w.Code
|
|
}
|
|
|
|
// HTTPSuccess asserts that a specified handler returns a success status code.
|
|
//
|
|
// assert.HTTPSuccess(t, myHandler, "POST", "http://www.google.com", nil)
|
|
//
|
|
// Returns whether the assertion was successful (true) or not (false).
|
|
func HTTPSuccess(t TestingT, handler http.HandlerFunc, method, url string, values url.Values) bool {
|
|
code := httpCode(handler, method, url, values)
|
|
if code == -1 {
|
|
return false
|
|
}
|
|
return code >= http.StatusOK && code <= http.StatusPartialContent
|
|
}
|
|
|
|
// HTTPRedirect asserts that a specified handler returns a redirect status code.
|
|
//
|
|
// assert.HTTPRedirect(t, myHandler, "GET", "/a/b/c", url.Values{"a": []string{"b", "c"}}
|
|
//
|
|
// Returns whether the assertion was successful (true) or not (false).
|
|
func HTTPRedirect(t TestingT, handler http.HandlerFunc, method, url string, values url.Values) bool {
|
|
code := httpCode(handler, method, url, values)
|
|
if code == -1 {
|
|
return false
|
|
}
|
|
return code >= http.StatusMultipleChoices && code <= http.StatusTemporaryRedirect
|
|
}
|
|
|
|
// HTTPError asserts that a specified handler returns an error status code.
|
|
//
|
|
// assert.HTTPError(t, myHandler, "POST", "/a/b/c", url.Values{"a": []string{"b", "c"}}
|
|
//
|
|
// Returns whether the assertion was successful (true) or not (false).
|
|
func HTTPError(t TestingT, handler http.HandlerFunc, method, url string, values url.Values) bool {
|
|
code := httpCode(handler, method, url, values)
|
|
if code == -1 {
|
|
return false
|
|
}
|
|
return code >= http.StatusBadRequest
|
|
}
|
|
|
|
// HTTPBody is a helper that returns HTTP body of the response. It returns
|
|
// empty string if building a new request fails.
|
|
func HTTPBody(handler http.HandlerFunc, method, url string, values url.Values) string {
|
|
w := httptest.NewRecorder()
|
|
req, err := http.NewRequest(method, url+"?"+values.Encode(), nil)
|
|
if err != nil {
|
|
return ""
|
|
}
|
|
handler(w, req)
|
|
return w.Body.String()
|
|
}
|
|
|
|
// HTTPBodyContains asserts that a specified handler returns a
|
|
// body that contains a string.
|
|
//
|
|
// assert.HTTPBodyContains(t, myHandler, "www.google.com", nil, "I'm Feeling Lucky")
|
|
//
|
|
// Returns whether the assertion was successful (true) or not (false).
|
|
func HTTPBodyContains(t TestingT, handler http.HandlerFunc, method, url string, values url.Values, str interface{}) bool {
|
|
body := HTTPBody(handler, method, url, values)
|
|
|
|
contains := strings.Contains(body, fmt.Sprint(str))
|
|
if !contains {
|
|
Fail(t, fmt.Sprintf("Expected response body for \"%s\" to contain \"%s\" but found \"%s\"", url+"?"+values.Encode(), str, body))
|
|
}
|
|
|
|
return contains
|
|
}
|
|
|
|
// HTTPBodyNotContains asserts that a specified handler returns a
|
|
// body that does not contain a string.
|
|
//
|
|
// assert.HTTPBodyNotContains(t, myHandler, "www.google.com", nil, "I'm Feeling Lucky")
|
|
//
|
|
// Returns whether the assertion was successful (true) or not (false).
|
|
func HTTPBodyNotContains(t TestingT, handler http.HandlerFunc, method, url string, values url.Values, str interface{}) bool {
|
|
body := HTTPBody(handler, method, url, values)
|
|
|
|
contains := strings.Contains(body, fmt.Sprint(str))
|
|
if contains {
|
|
Fail(t, fmt.Sprintf("Expected response body for \"%s\" to NOT contain \"%s\" but found \"%s\"", url+"?"+values.Encode(), str, body))
|
|
}
|
|
|
|
return !contains
|
|
}
|