mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
88470052e7
full diff:fa125a3512...b3507428be- fixed IPv6 iptables rules for enabled firewalld (libnetwork#2609) - fixes "Docker uses 'iptables' instead of 'ip6tables' for IPv6 NAT rule, crashes" - Fix regression in docker-proxy - introduced in "Fix IPv6 Port Forwarding for the Bridge Driver" (libnetwork#2604) - fixes/addresses: "IPv4 and IPv6 addresses are not bound by default anymore" (libnetwork#2607) - fixes/addresses "IPv6 is no longer proxied by default anymore" (moby#41858) - Use hostIP to decide on Portmapper version - fixes docker-proxy not being stopped correctly Port mapping of containers now contain separatet mappings for IPv4 and IPv6 addresses, when listening on "any" IP address. Various tests had to be updated to take multiple mappings into account. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit0450728267) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
370 lines
12 KiB
Go
370 lines
12 KiB
Go
package main
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"regexp"
|
|
"sort"
|
|
"strconv"
|
|
"strings"
|
|
"testing"
|
|
|
|
"gotest.tools/v3/assert"
|
|
)
|
|
|
|
func (s *DockerSuite) TestPortList(c *testing.T) {
|
|
testRequires(c, DaemonIsLinux)
|
|
// one port
|
|
out, _ := dockerCmd(c, "run", "-d", "-p", "9876:80", "busybox", "top")
|
|
firstID := strings.TrimSpace(out)
|
|
|
|
out, _ = dockerCmd(c, "port", firstID, "80")
|
|
|
|
err := assertPortList(c, out, []string{"0.0.0.0:9876", "[::]:9876"})
|
|
// Port list is not correct
|
|
assert.NilError(c, err)
|
|
|
|
out, _ = dockerCmd(c, "port", firstID)
|
|
|
|
err = assertPortList(c, out, []string{"80/tcp -> 0.0.0.0:9876", "80/tcp -> [::]:9876"})
|
|
// Port list is not correct
|
|
assert.NilError(c, err)
|
|
|
|
dockerCmd(c, "rm", "-f", firstID)
|
|
|
|
// three port
|
|
out, _ = dockerCmd(c, "run", "-d",
|
|
"-p", "9876:80",
|
|
"-p", "9877:81",
|
|
"-p", "9878:82",
|
|
"busybox", "top")
|
|
ID := strings.TrimSpace(out)
|
|
|
|
out, _ = dockerCmd(c, "port", ID, "80")
|
|
|
|
err = assertPortList(c, out, []string{"0.0.0.0:9876", "[::]:9876"})
|
|
// Port list is not correct
|
|
assert.NilError(c, err)
|
|
|
|
out, _ = dockerCmd(c, "port", ID)
|
|
|
|
err = assertPortList(c, out, []string{
|
|
"80/tcp -> 0.0.0.0:9876",
|
|
"80/tcp -> [::]:9876",
|
|
"81/tcp -> 0.0.0.0:9877",
|
|
"81/tcp -> [::]:9877",
|
|
"82/tcp -> 0.0.0.0:9878",
|
|
"82/tcp -> [::]:9878",
|
|
})
|
|
// Port list is not correct
|
|
assert.NilError(c, err)
|
|
|
|
dockerCmd(c, "rm", "-f", ID)
|
|
|
|
// more and one port mapped to the same container port
|
|
out, _ = dockerCmd(c, "run", "-d",
|
|
"-p", "9876:80",
|
|
"-p", "9999:80",
|
|
"-p", "9877:81",
|
|
"-p", "9878:82",
|
|
"busybox", "top")
|
|
ID = strings.TrimSpace(out)
|
|
|
|
out, _ = dockerCmd(c, "port", ID, "80")
|
|
|
|
err = assertPortList(c, out, []string{"0.0.0.0:9876", "[::]:9876", "0.0.0.0:9999", "[::]:9999"})
|
|
// Port list is not correct
|
|
assert.NilError(c, err)
|
|
|
|
out, _ = dockerCmd(c, "port", ID)
|
|
|
|
err = assertPortList(c, out, []string{
|
|
"80/tcp -> 0.0.0.0:9876",
|
|
"80/tcp -> 0.0.0.0:9999",
|
|
"80/tcp -> [::]:9876",
|
|
"80/tcp -> [::]:9999",
|
|
"81/tcp -> 0.0.0.0:9877",
|
|
"81/tcp -> [::]:9877",
|
|
"82/tcp -> 0.0.0.0:9878",
|
|
"82/tcp -> [::]:9878",
|
|
})
|
|
// Port list is not correct
|
|
assert.NilError(c, err)
|
|
dockerCmd(c, "rm", "-f", ID)
|
|
|
|
testRange := func() {
|
|
// host port ranges used
|
|
IDs := make([]string, 3)
|
|
for i := 0; i < 3; i++ {
|
|
out, _ = dockerCmd(c, "run", "-d", "-p", "9090-9092:80", "busybox", "top")
|
|
IDs[i] = strings.TrimSpace(out)
|
|
|
|
out, _ = dockerCmd(c, "port", IDs[i])
|
|
|
|
err = assertPortList(c, out, []string{
|
|
fmt.Sprintf("80/tcp -> 0.0.0.0:%d", 9090+i),
|
|
fmt.Sprintf("80/tcp -> [::]:%d", 9090+i),
|
|
})
|
|
// Port list is not correct
|
|
assert.NilError(c, err)
|
|
}
|
|
|
|
// test port range exhaustion
|
|
out, _, err = dockerCmdWithError("run", "-d", "-p", "9090-9092:80", "busybox", "top")
|
|
// Exhausted port range did not return an error
|
|
assert.Assert(c, err != nil, "out: %s", out)
|
|
|
|
for i := 0; i < 3; i++ {
|
|
dockerCmd(c, "rm", "-f", IDs[i])
|
|
}
|
|
}
|
|
testRange()
|
|
// Verify we ran re-use port ranges after they are no longer in use.
|
|
testRange()
|
|
|
|
// test invalid port ranges
|
|
for _, invalidRange := range []string{"9090-9089:80", "9090-:80", "-9090:80"} {
|
|
out, _, err = dockerCmdWithError("run", "-d", "-p", invalidRange, "busybox", "top")
|
|
// Port range should have returned an error
|
|
assert.Assert(c, err != nil, "out: %s", out)
|
|
}
|
|
|
|
// test host range:container range spec.
|
|
out, _ = dockerCmd(c, "run", "-d", "-p", "9800-9803:80-83", "busybox", "top")
|
|
ID = strings.TrimSpace(out)
|
|
|
|
out, _ = dockerCmd(c, "port", ID)
|
|
|
|
err = assertPortList(c, out, []string{
|
|
"80/tcp -> 0.0.0.0:9800",
|
|
"80/tcp -> [::]:9800",
|
|
"81/tcp -> 0.0.0.0:9801",
|
|
"81/tcp -> [::]:9801",
|
|
"82/tcp -> 0.0.0.0:9802",
|
|
"82/tcp -> [::]:9802",
|
|
"83/tcp -> 0.0.0.0:9803",
|
|
"83/tcp -> [::]:9803",
|
|
})
|
|
// Port list is not correct
|
|
assert.NilError(c, err)
|
|
dockerCmd(c, "rm", "-f", ID)
|
|
|
|
// test mixing protocols in same port range
|
|
out, _ = dockerCmd(c, "run", "-d", "-p", "8000-8080:80", "-p", "8000-8080:80/udp", "busybox", "top")
|
|
ID = strings.TrimSpace(out)
|
|
|
|
out, _ = dockerCmd(c, "port", ID)
|
|
|
|
// Running this test multiple times causes the TCP port to increment.
|
|
err = assertPortRange(ID, []int{8000, 8080}, []int{8000, 8080})
|
|
// Port list is not correct
|
|
assert.NilError(c, err)
|
|
dockerCmd(c, "rm", "-f", ID)
|
|
}
|
|
|
|
func assertPortList(c *testing.T, out string, expected []string) error {
|
|
c.Helper()
|
|
lines := strings.Split(strings.Trim(out, "\n "), "\n")
|
|
if len(lines) != len(expected) {
|
|
return fmt.Errorf("different size lists %s, %d, %d", out, len(lines), len(expected))
|
|
}
|
|
sort.Strings(lines)
|
|
sort.Strings(expected)
|
|
|
|
// "docker port" does not yet have a "--format" flag, and older versions
|
|
// of the CLI used an incorrect output format for mappings on IPv6 addresses
|
|
// for example, "80/tcp -> :::80" instead of "80/tcp -> [::]:80".
|
|
oldFormat := func(mapping string) string {
|
|
old := strings.Replace(mapping, "[", "", 1)
|
|
old = strings.Replace(old, "]:", ":", 1)
|
|
return old
|
|
}
|
|
|
|
for i := 0; i < len(expected); i++ {
|
|
if lines[i] == expected[i] {
|
|
continue
|
|
}
|
|
if lines[i] != oldFormat(expected[i]) {
|
|
return fmt.Errorf("|" + lines[i] + "!=" + expected[i] + "|")
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func assertPortRange(id string, expectedTCP, expectedUDP []int) error {
|
|
client := testEnv.APIClient()
|
|
inspect, err := client.ContainerInspect(context.TODO(), id)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
var validTCP, validUDP bool
|
|
for portAndProto, binding := range inspect.NetworkSettings.Ports {
|
|
if portAndProto.Proto() == "tcp" && len(expectedTCP) == 0 {
|
|
continue
|
|
}
|
|
if portAndProto.Proto() == "udp" && len(expectedTCP) == 0 {
|
|
continue
|
|
}
|
|
|
|
for _, b := range binding {
|
|
port, err := strconv.Atoi(b.HostPort)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if len(expectedTCP) > 0 {
|
|
if port < expectedTCP[0] || port > expectedTCP[1] {
|
|
return fmt.Errorf("tcp port (%d) not in range expected range %d-%d", port, expectedTCP[0], expectedTCP[1])
|
|
}
|
|
validTCP = true
|
|
}
|
|
if len(expectedUDP) > 0 {
|
|
if port < expectedUDP[0] || port > expectedUDP[1] {
|
|
return fmt.Errorf("udp port (%d) not in range expected range %d-%d", port, expectedUDP[0], expectedUDP[1])
|
|
}
|
|
validUDP = true
|
|
}
|
|
}
|
|
}
|
|
if !validTCP {
|
|
return fmt.Errorf("tcp port not found")
|
|
}
|
|
if !validUDP {
|
|
return fmt.Errorf("udp port not found")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func stopRemoveContainer(id string, c *testing.T) {
|
|
dockerCmd(c, "rm", "-f", id)
|
|
}
|
|
|
|
func (s *DockerSuite) TestUnpublishedPortsInPsOutput(c *testing.T) {
|
|
testRequires(c, DaemonIsLinux)
|
|
// Run busybox with command line expose (equivalent to EXPOSE in image's Dockerfile) for the following ports
|
|
port1 := 80
|
|
port2 := 443
|
|
expose1 := fmt.Sprintf("--expose=%d", port1)
|
|
expose2 := fmt.Sprintf("--expose=%d", port2)
|
|
dockerCmd(c, "run", "-d", expose1, expose2, "busybox", "sleep", "5")
|
|
|
|
// Check docker ps o/p for last created container reports the unpublished ports
|
|
unpPort1 := fmt.Sprintf("%d/tcp", port1)
|
|
unpPort2 := fmt.Sprintf("%d/tcp", port2)
|
|
out, _ := dockerCmd(c, "ps", "-n=1")
|
|
// Missing unpublished ports in docker ps output
|
|
assert.Assert(c, strings.Contains(out, unpPort1))
|
|
// Missing unpublished ports in docker ps output
|
|
assert.Assert(c, strings.Contains(out, unpPort2))
|
|
// Run the container forcing to publish the exposed ports
|
|
dockerCmd(c, "run", "-d", "-P", expose1, expose2, "busybox", "sleep", "5")
|
|
|
|
// Check docker ps o/p for last created container reports the exposed ports in the port bindings
|
|
expBndRegx1 := regexp.MustCompile(`0.0.0.0:\d\d\d\d\d->` + unpPort1)
|
|
expBndRegx2 := regexp.MustCompile(`0.0.0.0:\d\d\d\d\d->` + unpPort2)
|
|
out, _ = dockerCmd(c, "ps", "-n=1")
|
|
// Cannot find expected port binding port (0.0.0.0:xxxxx->unpPort1) in docker ps output
|
|
assert.Equal(c, expBndRegx1.MatchString(out), true, fmt.Sprintf("out: %s; unpPort1: %s", out, unpPort1))
|
|
// Cannot find expected port binding port (0.0.0.0:xxxxx->unpPort2) in docker ps output
|
|
assert.Equal(c, expBndRegx2.MatchString(out), true, fmt.Sprintf("out: %s; unpPort2: %s", out, unpPort2))
|
|
|
|
// Run the container specifying explicit port bindings for the exposed ports
|
|
offset := 10000
|
|
pFlag1 := fmt.Sprintf("%d:%d", offset+port1, port1)
|
|
pFlag2 := fmt.Sprintf("%d:%d", offset+port2, port2)
|
|
out, _ = dockerCmd(c, "run", "-d", "-p", pFlag1, "-p", pFlag2, expose1, expose2, "busybox", "sleep", "5")
|
|
id := strings.TrimSpace(out)
|
|
|
|
// Check docker ps o/p for last created container reports the specified port mappings
|
|
expBnd1 := fmt.Sprintf("0.0.0.0:%d->%s", offset+port1, unpPort1)
|
|
expBnd2 := fmt.Sprintf("0.0.0.0:%d->%s", offset+port2, unpPort2)
|
|
out, _ = dockerCmd(c, "ps", "-n=1")
|
|
// Cannot find expected port binding (expBnd1) in docker ps output
|
|
assert.Assert(c, strings.Contains(out, expBnd1))
|
|
// Cannot find expected port binding (expBnd2) in docker ps output
|
|
assert.Assert(c, strings.Contains(out, expBnd2))
|
|
// Remove container now otherwise it will interfere with next test
|
|
stopRemoveContainer(id, c)
|
|
|
|
// Run the container with explicit port bindings and no exposed ports
|
|
out, _ = dockerCmd(c, "run", "-d", "-p", pFlag1, "-p", pFlag2, "busybox", "sleep", "5")
|
|
id = strings.TrimSpace(out)
|
|
|
|
// Check docker ps o/p for last created container reports the specified port mappings
|
|
out, _ = dockerCmd(c, "ps", "-n=1")
|
|
// Cannot find expected port binding (expBnd1) in docker ps output
|
|
assert.Assert(c, strings.Contains(out, expBnd1))
|
|
// Cannot find expected port binding (expBnd2) in docker ps output
|
|
assert.Assert(c, strings.Contains(out, expBnd2))
|
|
// Remove container now otherwise it will interfere with next test
|
|
stopRemoveContainer(id, c)
|
|
|
|
// Run the container with one unpublished exposed port and one explicit port binding
|
|
dockerCmd(c, "run", "-d", expose1, "-p", pFlag2, "busybox", "sleep", "5")
|
|
|
|
// Check docker ps o/p for last created container reports the specified unpublished port and port mapping
|
|
out, _ = dockerCmd(c, "ps", "-n=1")
|
|
// Missing unpublished exposed ports (unpPort1) in docker ps output
|
|
assert.Assert(c, strings.Contains(out, unpPort1))
|
|
// Missing port binding (expBnd2) in docker ps output
|
|
assert.Assert(c, strings.Contains(out, expBnd2))
|
|
}
|
|
|
|
func (s *DockerSuite) TestPortHostBinding(c *testing.T) {
|
|
testRequires(c, DaemonIsLinux, NotUserNamespace)
|
|
out, _ := dockerCmd(c, "run", "-d", "-p", "9876:80", "busybox", "nc", "-l", "-p", "80")
|
|
firstID := strings.TrimSpace(out)
|
|
|
|
out, _ = dockerCmd(c, "port", firstID, "80")
|
|
|
|
err := assertPortList(c, out, []string{"0.0.0.0:9876", "[::]:9876"})
|
|
// Port list is not correct
|
|
assert.NilError(c, err)
|
|
|
|
dockerCmd(c, "run", "--net=host", "busybox", "nc", "localhost", "9876")
|
|
|
|
dockerCmd(c, "rm", "-f", firstID)
|
|
|
|
out, _, err = dockerCmdWithError("run", "--net=host", "busybox", "nc", "localhost", "9876")
|
|
// Port is still bound after the Container is removed
|
|
assert.Assert(c, err != nil, "out: %s", out)
|
|
}
|
|
|
|
func (s *DockerSuite) TestPortExposeHostBinding(c *testing.T) {
|
|
testRequires(c, DaemonIsLinux, NotUserNamespace)
|
|
out, _ := dockerCmd(c, "run", "-d", "-P", "--expose", "80", "busybox", "nc", "-l", "-p", "80")
|
|
firstID := strings.TrimSpace(out)
|
|
|
|
out, _ = dockerCmd(c, "inspect", "--format", `{{index .NetworkSettings.Ports "80/tcp" 0 "HostPort" }}`, firstID)
|
|
|
|
exposedPort := strings.TrimSpace(out)
|
|
dockerCmd(c, "run", "--net=host", "busybox", "nc", "127.0.0.1", exposedPort)
|
|
|
|
dockerCmd(c, "rm", "-f", firstID)
|
|
|
|
out, _, err := dockerCmdWithError("run", "--net=host", "busybox", "nc", "127.0.0.1", exposedPort)
|
|
// Port is still bound after the Container is removed
|
|
assert.Assert(c, err != nil, "out: %s", out)
|
|
}
|
|
|
|
func (s *DockerSuite) TestPortBindingOnSandbox(c *testing.T) {
|
|
testRequires(c, DaemonIsLinux, NotUserNamespace)
|
|
dockerCmd(c, "network", "create", "--internal", "-d", "bridge", "internal-net")
|
|
nr := getNetworkResource(c, "internal-net")
|
|
assert.Equal(c, nr.Internal, true)
|
|
|
|
dockerCmd(c, "run", "--net", "internal-net", "-d", "--name", "c1",
|
|
"-p", "8080:8080", "busybox", "nc", "-l", "-p", "8080")
|
|
assert.Assert(c, waitRun("c1") == nil)
|
|
|
|
_, _, err := dockerCmdWithError("run", "--net=host", "busybox", "nc", "localhost", "8080")
|
|
assert.Assert(c, err != nil, "Port mapping on internal network is expected to fail")
|
|
// Connect container to another normal bridge network
|
|
dockerCmd(c, "network", "create", "-d", "bridge", "foo-net")
|
|
dockerCmd(c, "network", "connect", "foo-net", "c1")
|
|
|
|
_, _, err = dockerCmdWithError("run", "--net=host", "busybox", "nc", "localhost", "8080")
|
|
assert.Assert(c, err == nil, "Port mapping on the new network is expected to succeed")
|
|
}
|