mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
621e3d8587
Return an error when the container is stopped only in api versions equal or greater than 1.20 (docker 1.8). Signed-off-by: David Calavera <david.calavera@gmail.com>
100 lines
3.1 KiB
Go
100 lines
3.1 KiB
Go
package main
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"strings"
|
|
|
|
"github.com/go-check/check"
|
|
)
|
|
|
|
func (s *DockerSuite) TestKillContainer(c *check.C) {
|
|
out, _ := dockerCmd(c, "run", "-d", "busybox", "top")
|
|
cleanedContainerID := strings.TrimSpace(out)
|
|
c.Assert(waitRun(cleanedContainerID), check.IsNil)
|
|
|
|
dockerCmd(c, "kill", cleanedContainerID)
|
|
|
|
out, _ = dockerCmd(c, "ps", "-q")
|
|
if strings.Contains(out, cleanedContainerID) {
|
|
c.Fatal("killed container is still running")
|
|
}
|
|
}
|
|
|
|
func (s *DockerSuite) TestKillofStoppedContainer(c *check.C) {
|
|
out, _ := dockerCmd(c, "run", "-d", "busybox", "top")
|
|
cleanedContainerID := strings.TrimSpace(out)
|
|
|
|
dockerCmd(c, "stop", cleanedContainerID)
|
|
|
|
_, _, err := dockerCmdWithError("kill", "-s", "30", cleanedContainerID)
|
|
c.Assert(err, check.Not(check.IsNil), check.Commentf("Container %s is not running", cleanedContainerID))
|
|
}
|
|
|
|
func (s *DockerSuite) TestKillDifferentUserContainer(c *check.C) {
|
|
out, _ := dockerCmd(c, "run", "-u", "daemon", "-d", "busybox", "top")
|
|
cleanedContainerID := strings.TrimSpace(out)
|
|
c.Assert(waitRun(cleanedContainerID), check.IsNil)
|
|
|
|
dockerCmd(c, "kill", cleanedContainerID)
|
|
|
|
out, _ = dockerCmd(c, "ps", "-q")
|
|
if strings.Contains(out, cleanedContainerID) {
|
|
c.Fatal("killed container is still running")
|
|
}
|
|
}
|
|
|
|
// regression test about correct signal parsing see #13665
|
|
func (s *DockerSuite) TestKillWithSignal(c *check.C) {
|
|
out, _ := dockerCmd(c, "run", "-d", "busybox", "top")
|
|
cid := strings.TrimSpace(out)
|
|
c.Assert(waitRun(cid), check.IsNil)
|
|
|
|
dockerCmd(c, "kill", "-s", "SIGWINCH", cid)
|
|
|
|
running, _ := inspectField(cid, "State.Running")
|
|
if running != "true" {
|
|
c.Fatal("Container should be in running state after SIGWINCH")
|
|
}
|
|
}
|
|
|
|
func (s *DockerSuite) TestKillWithInvalidSignal(c *check.C) {
|
|
out, _ := dockerCmd(c, "run", "-d", "busybox", "top")
|
|
cid := strings.TrimSpace(out)
|
|
c.Assert(waitRun(cid), check.IsNil)
|
|
|
|
out, _, err := dockerCmdWithError("kill", "-s", "0", cid)
|
|
c.Assert(err, check.NotNil)
|
|
if !strings.ContainsAny(out, "Invalid signal: 0") {
|
|
c.Fatal("Kill with an invalid signal didn't error out correctly")
|
|
}
|
|
|
|
running, _ := inspectField(cid, "State.Running")
|
|
if running != "true" {
|
|
c.Fatal("Container should be in running state after an invalid signal")
|
|
}
|
|
|
|
out, _ = dockerCmd(c, "run", "-d", "busybox", "top")
|
|
cid = strings.TrimSpace(out)
|
|
c.Assert(waitRun(cid), check.IsNil)
|
|
|
|
out, _, err = dockerCmdWithError("kill", "-s", "SIG42", cid)
|
|
c.Assert(err, check.NotNil)
|
|
if !strings.ContainsAny(out, "Invalid signal: SIG42") {
|
|
c.Fatal("Kill with an invalid signal error out correctly")
|
|
}
|
|
|
|
running, _ = inspectField(cid, "State.Running")
|
|
if running != "true" {
|
|
c.Fatal("Container should be in running state after an invalid signal")
|
|
}
|
|
}
|
|
|
|
func (s *DockerSuite) TestKillofStoppedContainerAPIPre120(c *check.C) {
|
|
dockerCmd(c, "run", "--name", "docker-kill-test-api", "-d", "busybox", "top")
|
|
dockerCmd(c, "stop", "docker-kill-test-api")
|
|
|
|
status, _, err := sockRequest("POST", fmt.Sprintf("/v1.19/containers/%s/kill", "docker-kill-test-api"), nil)
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(status, check.Equals, http.StatusNoContent)
|
|
}
|