mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
a4c68ee857
When sending SIGUSR1 to the daemon, it can crash because of a concurrent map access panic, showing a stack trace involving dumpDaemon. It appears it's not possible to recover from a concurrent map access panic. Since it's important that SIGUSR1 not be a destructive operation, sadly the best course of action I can think of is to remove this functionality. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
27 lines
517 B
Go
27 lines
517 B
Go
// +build !windows
|
|
|
|
package daemon
|
|
|
|
import (
|
|
"os"
|
|
"os/signal"
|
|
"syscall"
|
|
|
|
"github.com/Sirupsen/logrus"
|
|
stackdump "github.com/docker/docker/pkg/signal"
|
|
)
|
|
|
|
func (d *Daemon) setupDumpStackTrap(root string) {
|
|
c := make(chan os.Signal, 1)
|
|
signal.Notify(c, syscall.SIGUSR1)
|
|
go func() {
|
|
for range c {
|
|
path, err := stackdump.DumpStacks(root)
|
|
if err != nil {
|
|
logrus.WithError(err).Error("failed to write goroutines dump")
|
|
} else {
|
|
logrus.Infof("goroutine stacks written to %s", path)
|
|
}
|
|
}
|
|
}()
|
|
}
|