1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Moby Project - a collaborative project for the container ecosystem to assemble container-based systems
Find a file
Sebastiaan van Stijn 45067cda33
client: remove wrapResponseError()
The wrapResponseError() utility converted some specific errors, but in
doing so, could hide the actual error message returned by the daemon.
In addition, starting with 38e6d474af,
HTTP status codes were already mapped to their corresponding errdefs
types on the client-side, making this conversion redundant.

This patch removes the wrapResponseError() utility; it's worth noting
that some error-messages will change slightly (as they now return the
error as returned by the daemon), but may cointain more details as
before, and in some cases prevents hiding the actual error.

Before this change:

    docker container rm nosuchcontainer
    Error: No such container: nosuchcontainer

    docker container cp mycontainer:/no/such/path .
    Error: No such container:path: mycontainer:/no/such/path

    docker container cp ./Dockerfile mycontainer:/no/such/path
    Error: No such container:path: mycontainer:/no/such

    docker image rm nosuchimage
    Error: No such image: nosuchimage

    docker network rm nosuchnetwork
    Error: No such network: nosuchnetwork

    docker volume rm nosuchvolume
    Error: No such volume: nosuchvolume

    docker plugin rm nosuchplugin
    Error: No such plugin: nosuchplugin

    docker checkpoint rm nosuchcontainer nosuchcheckpoint
    Error response from daemon: No such container: nosuchcontainer

    docker checkpoint rm mycontainer nosuchcheckpoint
    Error response from daemon: checkpoint nosuchcheckpoint does not exist for container mycontainer

    docker service rm nosuchservice
    Error: No such service: nosuchservice

    docker node rm nosuchnode
    Error: No such node: nosuchnode

    docker config rm nosuschconfig
    Error: No such config: nosuschconfig

    docker secret rm nosuchsecret
    Error: No such secret: nosuchsecret

After this change:

    docker container rm nosuchcontainer
    Error response from daemon: No such container: nosuchcontainer

    docker container cp mycontainer:/no/such/path .
    Error response from daemon: Could not find the file /no/such/path in container mycontainer

    docker container cp ./Dockerfile mycontainer:/no/such/path
    Error response from daemon: Could not find the file /no/such in container mycontainer

    docker image rm nosuchimage
    Error response from daemon: No such image: nosuchimage:latest

    docker network rm nosuchnetwork
    Error response from daemon: network nosuchnetwork not found

    docker volume rm nosuchvolume
    Error response from daemon: get nosuchvolume: no such volume

    docker plugin rm nosuchplugin
    Error response from daemon: plugin "nosuchplugin" not found

    docker checkpoint rm nosuchcontainer nosuchcheckpoint
    Error response from daemon: No such container: nosuchcontainer

    docker checkpoint rm mycontainer nosuchcheckpoint
    Error response from daemon: checkpoint nosuchcheckpoint does not exist for container mycontainer

    docker service rm nosuchservice
    Error response from daemon: service nosuchservice not found

    docker node rm nosuchnode
    Error response from daemon: node nosuchnode not found

    docker config rm nosuchconfig
    Error response from daemon: config nosuchconfig not found

    docker secret rm nosuchsecret
    Error response from daemon: secret nosuchsecret not found

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-03-20 19:04:52 +01:00
.github ci: simple gha workflow to build docker daemon 2022-03-14 06:33:50 +01:00
api search: remove parsing JSON filters out of the backend 2022-03-18 09:44:55 +01:00
builder remove deprecated builder/dockerignore 2022-03-06 00:49:59 +01:00
cli remove uses of deprecated pkg/term 2020-04-21 16:29:27 +02:00
client client: remove wrapResponseError() 2022-03-20 19:04:52 +01:00
cmd Merge pull request #43250 from tianon/rm-quotedstring 2022-03-16 16:55:39 +01:00
container Merge pull request #42574 from charlesxsh/fix-deadlock-1 2021-12-01 17:35:30 -08:00
contrib all: fix typos 2022-03-01 14:26:35 +08:00
daemon Merge pull request #43312 from thaJeztah/search_fixes 2022-03-18 18:30:50 +01:00
distribution distribution: retry downloading schema config on retryable error 2022-03-05 19:36:48 +01:00
dockerversion Update to Go 1.17.0, and gofmt with Go 1.17 2021-08-24 23:33:27 +02:00
docs Merge pull request #41060 from grooverdan/dock-api-fix-create-image 2022-03-18 19:02:30 +01:00
errdefs log error message when receiving an unexpected type error 2021-11-09 17:53:08 +08:00
hack update containerd binary to v1.6.1 2022-03-11 13:14:33 +01:00
image Merge pull request #43300 from thaJeztah/api_update_imageinspect_docs 2022-03-05 17:54:37 +01:00
integration client: remove wrapResponseError() 2022-03-20 19:04:52 +01:00
integration-cli client: remove wrapResponseError() 2022-03-20 19:04:52 +01:00
internal/test/suite integration-cli: move each test suite to its own TestX testing function 2019-09-18 18:26:36 +00:00
layer layer: remove layerstore.setOS(), layerstore.getOS() 2022-03-11 23:14:27 +01:00
libcontainerd Windows: require Windows Server RS5 / ltsc2019 (build 17763) as minimum 2022-02-18 22:58:28 +01:00
libnetwork Windows: require Windows Server RS5 / ltsc2019 (build 17763) as minimum 2022-02-18 22:58:28 +01:00
oci oci/caps: limit available capabilities to current environment 2021-10-15 16:12:26 +02:00
opts Remove opts.QuotedString implementation 2022-02-16 12:54:06 -08:00
pkg Merge pull request #43385 from thaJeztah/move_IsWindowsClient 2022-03-18 15:29:32 +01:00
plugin filters: lowercase error 2022-03-18 09:44:53 +01:00
profiles seccomp: add support for "swapcontext" syscall in default policy 2021-12-18 14:06:07 +01:00
project Merge pull request #43161 from Haarolean/master 2022-01-20 13:06:48 +01:00
quota refactor: move from io/ioutil to io and os package 2021-08-27 14:56:57 +08:00
reference remove unneeded "digest" alias for "go-digest" 2022-03-04 14:49:42 +01:00
registry Merge pull request #43394 from thaJeztah/cleanup_registry_step2 2022-03-18 19:35:02 +01:00
reports Fix typos 2018-05-16 09:15:43 +08:00
restartmanager unconvert: remove unnescessary conversions 2019-09-18 12:57:33 +02:00
rootless refactor: move from io/ioutil to io and os package 2021-08-27 14:56:57 +08:00
runconfig Merge pull request #42725 from thaJeztah/runconfig_simplify 2021-10-27 20:15:14 +09:00
testutil testutil/daemon: remove redundant fmt.Sprintf()'s 2022-02-15 12:49:35 +01:00
vendor vendor: golang.org/x/crypto v0.0.0-20220315160706-3147a52a75dd 2022-03-17 13:59:03 +01:00
volume filters: lowercase error 2022-03-18 09:44:53 +01:00
.DEREK.yml Update .DEREK.yml 2019-05-06 13:27:04 -07:00
.dockerignore update .dockerignore to prevent '-unsupported' builds 2020-01-13 12:55:15 +01:00
.gitattributes vendor: replace vndr with go mod vendor 2022-01-18 15:46:00 +01:00
.gitignore vendor: replace vndr with go mod vendor 2022-01-18 15:46:00 +01:00
.mailmap Update AUTHORS and mailmap 2021-06-04 02:18:49 +02:00
AUTHORS Update AUTHORS and mailmap 2021-06-04 02:18:49 +02:00
CHANGELOG.md changelog: fix incorrectly named libnetwork label 2021-05-31 15:27:46 +02:00
codecov.yml Add code coverage report and codecov config 2018-01-16 16:50:56 -05:00
CONTRIBUTING.md Removed the slack archives 2022-01-13 18:30:45 +01:00
docker-bake.hcl ci: simple gha workflow to build docker daemon 2022-03-14 06:33:50 +01:00
Dockerfile update golang to 1.18.0 2022-03-16 12:14:56 +01:00
Dockerfile.e2e update golang to 1.18.0 2022-03-16 12:14:56 +01:00
Dockerfile.simple update golang to 1.18.0 2022-03-16 12:14:56 +01:00
Dockerfile.windows update golang to 1.18.0 2022-03-16 12:14:56 +01:00
Jenkinsfile Jenkinsfile: remove Windows RS1 as it reached end of support 2022-01-12 01:05:17 +01:00
LICENSE Update LICENSE 2018-09-12 14:27:53 +01:00
MAINTAINERS Add Samuel Karp as a maintainer 2021-05-20 12:54:40 -07:00
Makefile Makefile: use volume for go mod cache when running dev-container 2022-01-18 15:46:06 +01:00
NOTICE switch kr/pty to creack/pty v1.1.7 2019-07-29 16:59:08 -07:00
README.md Add "Lego set" back in README.md 2017-10-10 14:10:39 +00:00
ROADMAP.md Fix some typos in ROADMAP.md 2019-01-25 14:27:13 +08:00
SECURITY.md Update SECURITY.md to have an option to keep name anonymous if requested. 2019-06-18 16:37:16 +00:00
TESTING.md TESTING.md: note that integration-cli is deprecated 2020-12-18 07:51:46 +01:00
vendor.mod vendor: golang.org/x/crypto v0.0.0-20220315160706-3147a52a75dd 2022-03-17 13:59:03 +01:00
vendor.sum vendor: golang.org/x/crypto v0.0.0-20220315160706-3147a52a75dd 2022-03-17 13:59:03 +01:00
VENDORING.md

The Moby Project

Moby Project logo

Moby is an open-source project created by Docker to enable and accelerate software containerization.

It provides a "Lego set" of toolkit components, the framework for assembling them into custom container-based systems, and a place for all container enthusiasts and professionals to experiment and exchange ideas. Components include container build tools, a container registry, orchestration tools, a runtime and more, and these can be used as building blocks in conjunction with other tools and projects.

Principles

Moby is an open project guided by strong principles, aiming to be modular, flexible and without too strong an opinion on user experience. It is open to the community to help set its direction.

  • Modular: the project includes lots of components that have well-defined functions and APIs that work together.
  • Batteries included but swappable: Moby includes enough components to build fully featured container system, but its modular architecture ensures that most of the components can be swapped by different implementations.
  • Usable security: Moby provides secure defaults without compromising usability.
  • Developer focused: The APIs are intended to be functional and useful to build powerful tools. They are not necessarily intended as end user tools but as components aimed at developers. Documentation and UX is aimed at developers not end users.

Audience

The Moby Project is intended for engineers, integrators and enthusiasts looking to modify, hack, fix, experiment, invent and build systems based on containers. It is not for people looking for a commercially supported system, but for people who want to work and learn with open source code.

Relationship with Docker

The components and tools in the Moby Project are initially the open source components that Docker and the community have built for the Docker Project. New projects can be added if they fit with the community goals. Docker is committed to using Moby as the upstream for the Docker Product. However, other projects are also encouraged to use Moby as an upstream, and to reuse the components in diverse ways, and all these uses will be treated in the same way. External maintainers and contributors are welcomed.

The Moby project is not intended as a location for support or feature requests for Docker products, but as a place for contributors to work on open source code, fix bugs, and make the code more useful. The releases are supported by the maintainers, community and users, on a best efforts basis only, and are not intended for customers who want enterprise or commercial support; Docker EE is the appropriate product for these use cases.


Legal

Brought to you courtesy of our legal counsel. For more context, please see the NOTICE document in this repo.

Use and transfer of Moby may be subject to certain restrictions by the United States and other governments.

It is your responsibility to ensure that your use and/or transfer does not violate applicable laws.

For more information, please see https://www.bis.doc.gov

Licensing

Moby is licensed under the Apache License, Version 2.0. See LICENSE for the full license text.