mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
6cc55dd65b
We just introduced a new tunable dm.xfs_nospace_max_retries. But this tunable will work only on new kernels where xfs supports this feature. On older kernels xfs does not allow tuning this behavior. There are two issues. First one is that if xfsSetNospaceRetries() fails, it returns error but leaves the device activated and mounted. We should be unmounting the device and deactivate it before returning. Second issue is, if docker is started on older kernel, with dm.xfs_nospace_max_retries specified, then docker will silently ignore the fact that /sys file to tweak this behavior is not present and will continue. But I think it might be better to fail container creation/start if kernel does not support this feature. This patch fixes it. After this patch, user will get an error like following when container is run. # docker run -ti fedora bash docker: Error response from daemon: devmapper: user specified daemon option dm.xfs_nospace_max_retries but it does not seem to be supported on this system :open /sys/fs/xfs/dm-5/error/metadata/ENOSPC/max_retries: no such file or directory. Signed-off-by: Vivek Goyal <vgoyal@redhat.com> |
||
|---|---|---|
| .. | ||
| aufs | ||
| btrfs | ||
| devmapper | ||
| graphtest | ||
| overlay | ||
| overlay2 | ||
| register | ||
| vfs | ||
| windows | ||
| zfs | ||
| counter.go | ||
| driver.go | ||
| driver_freebsd.go | ||
| driver_linux.go | ||
| driver_solaris.go | ||
| driver_unsupported.go | ||
| driver_windows.go | ||
| fsdiff.go | ||
| plugin.go | ||
| plugin_unsupported.go | ||
| proxy.go | ||