mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
475c65319b
This was just an alias to `strings.TrimSpace` Signed-off-by: Brian Goff <cpuguy83@gmail.com>
117 lines
3.1 KiB
Go
117 lines
3.1 KiB
Go
package main
|
|
|
|
import (
|
|
"os/exec"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// ensure that an added file shows up in docker diff
|
|
func TestDiffFilenameShownInOutput(t *testing.T) {
|
|
containerCmd := `echo foo > /root/bar`
|
|
runCmd := exec.Command(dockerBinary, "run", "-d", "busybox", "sh", "-c", containerCmd)
|
|
out, _, err := runCommandWithOutput(runCmd)
|
|
if err != nil {
|
|
t.Fatalf("failed to start the container: %s, %v", out, err)
|
|
}
|
|
|
|
cleanCID := strings.TrimSpace(out)
|
|
|
|
diffCmd := exec.Command(dockerBinary, "diff", cleanCID)
|
|
out, _, err = runCommandWithOutput(diffCmd)
|
|
if err != nil {
|
|
t.Fatalf("failed to run diff: %s %v", out, err)
|
|
}
|
|
|
|
found := false
|
|
for _, line := range strings.Split(out, "\n") {
|
|
if strings.Contains("A /root/bar", line) {
|
|
found = true
|
|
break
|
|
}
|
|
}
|
|
if !found {
|
|
t.Errorf("couldn't find the new file in docker diff's output: %v", out)
|
|
}
|
|
deleteContainer(cleanCID)
|
|
|
|
logDone("diff - check if created file shows up")
|
|
}
|
|
|
|
// test to ensure GH #3840 doesn't occur any more
|
|
func TestDiffEnsureDockerinitFilesAreIgnored(t *testing.T) {
|
|
// this is a list of files which shouldn't show up in `docker diff`
|
|
dockerinitFiles := []string{"/etc/resolv.conf", "/etc/hostname", "/etc/hosts", "/.dockerinit", "/.dockerenv"}
|
|
|
|
// we might not run into this problem from the first run, so start a few containers
|
|
for i := 0; i < 20; i++ {
|
|
containerCmd := `echo foo > /root/bar`
|
|
runCmd := exec.Command(dockerBinary, "run", "-d", "busybox", "sh", "-c", containerCmd)
|
|
out, _, err := runCommandWithOutput(runCmd)
|
|
if err != nil {
|
|
t.Fatal(out, err)
|
|
}
|
|
|
|
cleanCID := strings.TrimSpace(out)
|
|
|
|
diffCmd := exec.Command(dockerBinary, "diff", cleanCID)
|
|
out, _, err = runCommandWithOutput(diffCmd)
|
|
if err != nil {
|
|
t.Fatalf("failed to run diff: %s, %v", out, err)
|
|
}
|
|
|
|
deleteContainer(cleanCID)
|
|
|
|
for _, filename := range dockerinitFiles {
|
|
if strings.Contains(out, filename) {
|
|
t.Errorf("found file which should've been ignored %v in diff output", filename)
|
|
}
|
|
}
|
|
}
|
|
|
|
logDone("diff - check if ignored files show up in diff")
|
|
}
|
|
|
|
func TestDiffEnsureOnlyKmsgAndPtmx(t *testing.T) {
|
|
runCmd := exec.Command(dockerBinary, "run", "-d", "busybox", "sleep", "0")
|
|
out, _, err := runCommandWithOutput(runCmd)
|
|
if err != nil {
|
|
t.Fatal(out, err)
|
|
}
|
|
|
|
cleanCID := strings.TrimSpace(out)
|
|
|
|
diffCmd := exec.Command(dockerBinary, "diff", cleanCID)
|
|
out, _, err = runCommandWithOutput(diffCmd)
|
|
if err != nil {
|
|
t.Fatalf("failed to run diff: %s, %v", out, err)
|
|
}
|
|
deleteContainer(cleanCID)
|
|
|
|
expected := map[string]bool{
|
|
"C /dev": true,
|
|
"A /dev/full": true, // busybox
|
|
"C /dev/ptmx": true, // libcontainer
|
|
"A /dev/kmsg": true, // lxc
|
|
"A /dev/fd": true,
|
|
"A /dev/fuse": true,
|
|
"A /dev/ptmx": true,
|
|
"A /dev/null": true,
|
|
"A /dev/random": true,
|
|
"A /dev/stdout": true,
|
|
"A /dev/stderr": true,
|
|
"A /dev/tty1": true,
|
|
"A /dev/stdin": true,
|
|
"A /dev/tty": true,
|
|
"A /dev/urandom": true,
|
|
"A /dev/zero": true,
|
|
}
|
|
|
|
for _, line := range strings.Split(out, "\n") {
|
|
if line != "" && !expected[line] {
|
|
t.Errorf("%q is shown in the diff but shouldn't", line)
|
|
}
|
|
}
|
|
|
|
logDone("diff - ensure that only kmsg and ptmx in diff")
|
|
}
|