mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
e3c24caf7a
For some reason, `go vet` and `go fmt` validate does not capture
several issues.
The following was the output of `go vet`:
```
ubuntu@ubuntu:~/docker$ go vet ./... 2>&1 | grep -v ^vendor | grep -v '^exit status 1$'
cli/command/formatter/container_test.go:393: possible formatting directive in Log call
volume/volume_test.go:257: arg mp.RW for printf verb %s of wrong type: bool
```
The following was the output of `go fmt -s`:
```
ubuntu@ubuntu:~/docker$ gofmt -s -l . | grep -v ^vendor
cli/command/stack/list.go
daemon/commit.go
```
Fixed above issues with `go vet` and `go fmt -s`
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
(cherry picked from commit ace786e9d5)
Signed-off-by: Victor Vieux <victorvieux@gmail.com>
117 lines
2.2 KiB
Go
117 lines
2.2 KiB
Go
package stack
|
|
|
|
import (
|
|
"fmt"
|
|
"io"
|
|
"strconv"
|
|
"text/tabwriter"
|
|
|
|
"golang.org/x/net/context"
|
|
|
|
"github.com/docker/docker/api/types"
|
|
"github.com/docker/docker/api/types/filters"
|
|
"github.com/docker/docker/cli"
|
|
"github.com/docker/docker/cli/command"
|
|
"github.com/docker/docker/client"
|
|
"github.com/spf13/cobra"
|
|
)
|
|
|
|
const (
|
|
listItemFmt = "%s\t%s\n"
|
|
)
|
|
|
|
type listOptions struct {
|
|
}
|
|
|
|
func newListCommand(dockerCli *command.DockerCli) *cobra.Command {
|
|
opts := listOptions{}
|
|
|
|
cmd := &cobra.Command{
|
|
Use: "ls",
|
|
Aliases: []string{"list"},
|
|
Short: "List stacks",
|
|
Args: cli.NoArgs,
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
return runList(dockerCli, opts)
|
|
},
|
|
}
|
|
|
|
return cmd
|
|
}
|
|
|
|
func runList(dockerCli *command.DockerCli, opts listOptions) error {
|
|
client := dockerCli.Client()
|
|
ctx := context.Background()
|
|
|
|
stacks, err := getStacks(ctx, client)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
out := dockerCli.Out()
|
|
printTable(out, stacks)
|
|
return nil
|
|
}
|
|
|
|
func printTable(out io.Writer, stacks []*stack) {
|
|
writer := tabwriter.NewWriter(out, 0, 4, 2, ' ', 0)
|
|
|
|
// Ignore flushing errors
|
|
defer writer.Flush()
|
|
|
|
fmt.Fprintf(writer, listItemFmt, "NAME", "SERVICES")
|
|
for _, stack := range stacks {
|
|
fmt.Fprintf(
|
|
writer,
|
|
listItemFmt,
|
|
stack.Name,
|
|
strconv.Itoa(stack.Services),
|
|
)
|
|
}
|
|
}
|
|
|
|
type stack struct {
|
|
// Name is the name of the stack
|
|
Name string
|
|
// Services is the number of the services
|
|
Services int
|
|
}
|
|
|
|
func getStacks(
|
|
ctx context.Context,
|
|
apiclient client.APIClient,
|
|
) ([]*stack, error) {
|
|
|
|
filter := filters.NewArgs()
|
|
filter.Add("label", labelNamespace)
|
|
|
|
services, err := apiclient.ServiceList(
|
|
ctx,
|
|
types.ServiceListOptions{Filters: filter})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
m := make(map[string]*stack, 0)
|
|
for _, service := range services {
|
|
labels := service.Spec.Labels
|
|
name, ok := labels[labelNamespace]
|
|
if !ok {
|
|
return nil, fmt.Errorf("cannot get label %s for service %s",
|
|
labelNamespace, service.ID)
|
|
}
|
|
ztack, ok := m[name]
|
|
if !ok {
|
|
m[name] = &stack{
|
|
Name: name,
|
|
Services: 1,
|
|
}
|
|
} else {
|
|
ztack.Services++
|
|
}
|
|
}
|
|
var stacks []*stack
|
|
for _, stack := range m {
|
|
stacks = append(stacks, stack)
|
|
}
|
|
return stacks, nil
|
|
}
|