1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
moby--moby/runconfig/opts
Doug Davis 64aac182d6 Fix processing of unset build-args during build
This reverts 26103.  26103 was trying to make it so that if someone did:
  docker build --build-arg FOO .
and FOO wasn't set as an env var then it would pick-up FOO from the
Dockerfile's ARG cmd.  However, it went too far and removed the ability
to specify a build arg w/o any value. Meaning it required the --build-arg
param to always be in the form "name=value", and not just "name".

This PR does the right fix - it allows just "name" and it'll grab the value
from the env vars if set. If "name" isn't set in the env then it still needs
to send "name" to the server so that a warning can be printed about an
unused --build-arg. And this is why buildArgs in the options is now a
*string instead of just a string - 'nil' == mentioned but no value.

Closes #29084

Signed-off-by: Doug Davis <dug@us.ibm.com>
(cherry picked from commit cdb8ea90b0)
Signed-off-by: Victor Vieux <vieux@docker.com>
2016-12-09 14:24:00 -08:00
..
fixtures Return error if env file contains non-ascii or utf8 bytes (for windows) 2016-10-25 12:34:25 -07:00
envfile.go Return error if env file contains non-ascii or utf8 bytes (for windows) 2016-10-25 12:34:25 -07:00
envfile_test.go fix typos 2016-06-02 17:17:22 +08:00
opts.go Fix processing of unset build-args during build 2016-12-09 14:24:00 -08:00
opts_test.go Fix processing of unset build-args during build 2016-12-09 14:24:00 -08:00
parse.go Fix processing of unset build-args during build 2016-12-09 14:24:00 -08:00
parse_test.go Return error if env file contains non-ascii or utf8 bytes (for windows) 2016-10-25 12:34:25 -07:00
runtime.go Add engine-api types to docker 2016-09-07 11:05:58 -07:00
throttledevice.go all: replace loop with single append 2016-10-13 13:31:52 -07:00
ulimit.go Convert 'docker run' to a cobra command and to use pflags 2016-06-04 13:55:35 +02:00
ulimit_test.go
weightdevice.go Add engine-api types to docker 2016-09-07 11:05:58 -07:00