mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
a304dcef00
A command like: docker run --expose 5353/tcp -P fedora sleep 10 Currently fails with: Error: Cannot start container 5c558de5f0bd85ff14e13e3691aefbe531346297a27d4b3562732baa8785b34a: unknown protocol This is because nat.SplitProtoPort() confuses the order of the port and proto in 5353/tcp, assuming the protocol is first. However, in all other places in docker the protocol is last, so the fix is just to swap these. Docker-DCO-1.1-Signed-off-by: Alexander Larsson <alexl@redhat.com> (github: alexlarsson)
133 lines
2.9 KiB
Go
133 lines
2.9 KiB
Go
package nat
|
|
|
|
// nat is a convenience package for docker's manipulation of strings describing
|
|
// network ports.
|
|
|
|
import (
|
|
"fmt"
|
|
"github.com/dotcloud/docker/utils"
|
|
"strconv"
|
|
"strings"
|
|
)
|
|
|
|
const (
|
|
PortSpecTemplate = "ip:hostPort:containerPort"
|
|
PortSpecTemplateFormat = "ip:hostPort:containerPort | ip::containerPort | hostPort:containerPort"
|
|
)
|
|
|
|
type PortBinding struct {
|
|
HostIp string
|
|
HostPort string
|
|
}
|
|
|
|
type PortMap map[Port][]PortBinding
|
|
|
|
type PortSet map[Port]struct{}
|
|
|
|
// 80/tcp
|
|
type Port string
|
|
|
|
func NewPort(proto, port string) Port {
|
|
return Port(fmt.Sprintf("%s/%s", port, proto))
|
|
}
|
|
|
|
func ParsePort(rawPort string) (int, error) {
|
|
port, err := strconv.ParseUint(rawPort, 10, 16)
|
|
if err != nil {
|
|
return 0, err
|
|
}
|
|
return int(port), nil
|
|
}
|
|
|
|
func (p Port) Proto() string {
|
|
parts := strings.Split(string(p), "/")
|
|
if len(parts) == 1 {
|
|
return "tcp"
|
|
}
|
|
return parts[1]
|
|
}
|
|
|
|
func (p Port) Port() string {
|
|
return strings.Split(string(p), "/")[0]
|
|
}
|
|
|
|
func (p Port) Int() int {
|
|
i, err := ParsePort(p.Port())
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
return i
|
|
}
|
|
|
|
// Splits a port in the format of port/proto
|
|
func SplitProtoPort(rawPort string) (string, string) {
|
|
parts := strings.Split(rawPort, "/")
|
|
l := len(parts)
|
|
if l == 0 {
|
|
return "", ""
|
|
}
|
|
if l == 1 {
|
|
return "tcp", rawPort
|
|
}
|
|
return parts[1], parts[0]
|
|
}
|
|
|
|
// We will receive port specs in the format of ip:public:private/proto and these need to be
|
|
// parsed in the internal types
|
|
func ParsePortSpecs(ports []string) (map[Port]struct{}, map[Port][]PortBinding, error) {
|
|
var (
|
|
exposedPorts = make(map[Port]struct{}, len(ports))
|
|
bindings = make(map[Port][]PortBinding)
|
|
)
|
|
|
|
for _, rawPort := range ports {
|
|
proto := "tcp"
|
|
|
|
if i := strings.LastIndex(rawPort, "/"); i != -1 {
|
|
proto = rawPort[i+1:]
|
|
rawPort = rawPort[:i]
|
|
}
|
|
if !strings.Contains(rawPort, ":") {
|
|
rawPort = fmt.Sprintf("::%s", rawPort)
|
|
} else if len(strings.Split(rawPort, ":")) == 2 {
|
|
rawPort = fmt.Sprintf(":%s", rawPort)
|
|
}
|
|
|
|
parts, err := utils.PartParser(PortSpecTemplate, rawPort)
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
|
|
var (
|
|
containerPort = parts["containerPort"]
|
|
rawIp = parts["ip"]
|
|
hostPort = parts["hostPort"]
|
|
)
|
|
|
|
if containerPort == "" {
|
|
return nil, nil, fmt.Errorf("No port specified: %s<empty>", rawPort)
|
|
}
|
|
if _, err := strconv.ParseUint(containerPort, 10, 16); err != nil {
|
|
return nil, nil, fmt.Errorf("Invalid containerPort: %s", containerPort)
|
|
}
|
|
if _, err := strconv.ParseUint(hostPort, 10, 16); hostPort != "" && err != nil {
|
|
return nil, nil, fmt.Errorf("Invalid hostPort: %s", hostPort)
|
|
}
|
|
|
|
port := NewPort(proto, containerPort)
|
|
if _, exists := exposedPorts[port]; !exists {
|
|
exposedPorts[port] = struct{}{}
|
|
}
|
|
|
|
binding := PortBinding{
|
|
HostIp: rawIp,
|
|
HostPort: hostPort,
|
|
}
|
|
bslice, exists := bindings[port]
|
|
if !exists {
|
|
bslice = []PortBinding{}
|
|
}
|
|
bindings[port] = append(bslice, binding)
|
|
}
|
|
return exposedPorts, bindings, nil
|
|
}
|