Akihiro Suda 8493fb18ae dockerd: fix rootless detection (alternative to #39024) ... The `--rootless` flag had a couple of issues: * #38702: euid=0, $USER="root" but no access to cgroup ("rootful" Docker in rootless Docker) * #39009: euid=0 but $USER="docker" (rootful boot2docker) To fix #38702, XDG dirs are ignored as in rootful Docker, unless the dockerd is directly running under RootlessKit namespaces. RootlessKit detection is implemented by checking whether `$ROOTLESSKIT_STATE_DIR` is set. To fix #39009, the non-robust `$USER` check is now completely removed. The entire logic can be illustrated as follows: ``` withRootlessKit := getenv("ROOTLESSKIT_STATE_DIR") rootlessMode := withRootlessKit || cliFlag("--rootless") honorXDG := withRootlessKit useRootlessKitDockerProxy := withRootlessKit removeCgroupSpec := rootlessMode adjustOOMScoreAdj := rootlessMode ``` Close #39024 Fix #38702 #39009 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp> (cherry picked from commit 3518383ed9) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>		2019-05-13 15:31:31 -07:00
..
address_pools.go	Various code-cleanup	2018-05-23 17:50:54 +02:00
address_pools_test.go	Allow user to control the default address pools	2018-04-30 11:14:08 -04:00
env.go
env_test.go
hosts.go	dockerd: fix rootless detection (alternative to #39024)	2019-05-13 15:31:31 -07:00
hosts_test.go	allow running dockerd in an unprivileged user namespace (rootless mode)	2019-02-04 00:24:27 +09:00
hosts_unix.go
hosts_windows.go
ip.go
ip_test.go
opts.go	Various code-cleanup	2018-05-23 17:50:54 +02:00
opts_test.go
opts_unix.go
opts_windows.go
quotedstring.go
quotedstring_test.go	Update tests to use gotest.tools 👼	2018-06-13 09:04:30 +02:00
runtime.go
ulimit.go
ulimit_test.go