mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
1f0fdcc6f5
The golang-ci-lint takes longest to run, so do the other
checks first; this also makes the output a bit more readable.
While at it, fix some consistency issues in the output of the
other checks.
Before this change:
TEST_FORCE_VALIDATE=1 hack/validate/default
Congratulations! All commits are properly signed with the DCO!
Congratulations! Seccomp profile generation is done correctly.
INFO [config_reader] Used config file hack/validate/golangci-lint.yml
INFO [lintersdb] Active 15 linters: [deadcode gofmt goimports golint gosec gosimple govet ineffassign misspell staticcheck structcheck typecheck unconvert unused varcheck]
...
INFO Execution took 2m12.4287302s
Congratulations! "./pkg/..." is safely isolated from internal code.
The swagger spec at "api/swagger.yaml" is valid against swagger specification 2.0
Congratulations! All api changes are done the right way.
Congratulations! All toml source files changed here have valid syntax.
Congratulations! Changelog CHANGELOG.md is well-formed.
Congratulations! Changelog CHANGELOG.md dates are in descending order.
After this change:
TEST_FORCE_VALIDATE=1 hack/validate/default
Congratulations! All commits are properly signed with the DCO!
Congratulations! Seccomp profile generation is done correctly.
Congratulations! Packages in "./pkg/..." are safely isolated from internal code.
Congratulations! The swagger spec at "api/swagger.yaml" is valid against swagger specification 2.0
Congratulations! All API changes are done the right way.
Congratulations! All TOML source files changed here have valid syntax.
Congratulations! Changelog CHANGELOG.md is well-formed.
Congratulations! Changelog CHANGELOG.md dates are in descending order.
Congratulations! No new tests were added to integration-cli.
INFO Start validation with golang-ci-lint
INFO [config_reader] Used config file hack/validate/golangci-lint.yml
INFO [lintersdb] Active 15 linters: [deadcode gofmt goimports golint gosec gosimple govet ineffassign misspell staticcheck structcheck typecheck unconvert unused varcheck]
...
INFO Execution took 2m12.4287302s
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
29 lines
940 B
Bash
Executable file
29 lines
940 B
Bash
Executable file
#!/usr/bin/env bash
|
|
set -e -o pipefail
|
|
|
|
SCRIPTDIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
|
|
|
|
# CI platforms differ, so per-platform GOLANGCI_LINT_OPTS can be set
|
|
# from a platform-specific Dockerfile, otherwise let's just set
|
|
# (somewhat pessimistic) default of 10 minutes.
|
|
: "${GOLANGCI_LINT_OPTS=--timeout=10m}"
|
|
|
|
[ -n "${TESTDEBUG}" ] && set -x
|
|
|
|
# TODO find a way to share this code with hack/make.sh
|
|
if ${PKG_CONFIG} 'libsystemd >= 209' 2> /dev/null ; then
|
|
DOCKER_BUILDTAGS+=" journald"
|
|
elif ${PKG_CONFIG} 'libsystemd-journal' 2> /dev/null ; then
|
|
DOCKER_BUILDTAGS+=" journald journald_compat"
|
|
fi
|
|
|
|
echo -e "\n\033[0;36mINFO\033[0m Start validation with golang-ci-lint"
|
|
|
|
# TODO use --out-format=junit-xml and store artifacts
|
|
# shellcheck disable=SC2086
|
|
GOGC=75 golangci-lint run \
|
|
${GOLANGCI_LINT_OPTS} \
|
|
--print-resources-usage \
|
|
--build-tags="${DOCKER_BUILDTAGS}" \
|
|
--verbose \
|
|
--config "${SCRIPTDIR}/golangci-lint.yml"
|