1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
moby--moby/daemon/logger
Nalin Dahyabhai 52c0f36f7b Fix a race in cleaning up after journald followers
When following a journal-based log, it was possible for the worker
goroutine, which reads the journal using the journal context and sends
entry data down the message channel, to be scheduled after the function
which started it had returned.  This could create problems, since the
invoking function was closing the journal context object and message
channel before it returned, which could trigger use-after-free segfaults
and write-to-closed-channel panics in the worker goroutine.

Make the cleanup in the invoking function conditional so that it's only
done when we're not following the logs, and if we are, that it's left to
the worker goroutine to close them.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com> (github: nalind)
2016-03-17 18:36:21 -04:00
..
awslogs dockerversion placeholder for library import 2015-11-09 19:32:46 +01:00
etwlogs Windows: Add ETW logging driver plug-in 2016-02-16 13:24:49 -08:00
fluentd remove dead code 2016-03-16 19:15:14 -07:00
gcplogs Do not call out to Google on init 2016-03-17 11:06:21 -04:00
gelf add gelf option to customize compression type and level 2016-03-15 11:06:06 +00:00
journald Fix a race in cleaning up after journald followers 2016-03-17 18:36:21 -04:00
jsonfilelog Remove some unused structs and fields 2016-03-01 09:59:29 -08:00
loggerutils Provide basic string manupilation functions for template executions. 2016-03-09 19:37:12 -05:00
splunk *: fix response body leaks 2016-03-16 17:15:42 +01:00
syslog Fixes #18712. Add rfc5424 log format for syslog. 2016-03-09 22:31:11 +02:00
context.go daemon/logger: fix typo in godoc 2015-12-17 15:52:33 -08:00
copier.go only close LogDriver after LogCopier is done 2016-01-18 17:47:57 +00:00
copier_test.go only close LogDriver after LogCopier is done 2016-01-18 17:47:57 +00:00
factory.go log driver - add ability to interpolate container context into the log tag field 2015-09-16 15:19:28 -07:00
logger.go Move timeutils functions to the only places where they are used. 2015-12-15 14:56:14 -05:00