mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
6052f2b396
I noticed that we're using a homegrown package for assertions. The functions are extremely similar to testify, but with enough slight differences to be confusing (for example, Equal takes its arguments in a different order). We already vendor testify, and it's used in a few places by tests. I also found some problems with pkg/testutil/assert. For example, the NotNil function seems to be broken. It checks the argument against "nil", which only works for an interface. If you pass in a nil map or slice, the equality check will fail. In the interest of avoiding NIH, I'm proposing replacing pkg/testutil/assert with testify. The test code looks almost the same, but we avoid the confusion of having two similar but slightly different assertion packages, and having to maintain our own package instead of using a commonly-used one. In the process, I found a few places where the tests should halt if an assertion fails, so I've made those cases (that I noticed) use "require" instead of "assert", and I've vendored the "require" package from testify alongside the already-present "assert" package. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
28 lines
876 B
Go
28 lines
876 B
Go
// Package require implements the same assertions as the `assert` package but
|
|
// stops test execution when a test fails.
|
|
//
|
|
// Example Usage
|
|
//
|
|
// The following is a complete example using require in a standard test function:
|
|
// import (
|
|
// "testing"
|
|
// "github.com/stretchr/testify/require"
|
|
// )
|
|
//
|
|
// func TestSomething(t *testing.T) {
|
|
//
|
|
// var a string = "Hello"
|
|
// var b string = "Hello"
|
|
//
|
|
// require.Equal(t, a, b, "The two words should be the same.")
|
|
//
|
|
// }
|
|
//
|
|
// Assertions
|
|
//
|
|
// The `require` package have same global functions as in the `assert` package,
|
|
// but instead of returning a boolean result they call `t.FailNow()`.
|
|
//
|
|
// Every assertion function also takes an optional string message as the final argument,
|
|
// allowing custom error messages to be appended to the message the assertion method outputs.
|
|
package require
|