1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
moby--moby/integration-cli
Thomas Orozco 967f80f3cc Fix: Failed Start breaks VolumesFrom
Running parseVolumesFromSpec on all VolumesFrom specs before initialize
any mounts endures that we don't leave container.Volumes in an
inconsistent (partially initialized) if one of out mount groups is not
available (e.g. the container we're trying to mount from does not
exist).

Keeping container.Volumes in a consistent state ensures that next time
we Start() the container, it'll run prepareVolumes() again.

The attached test demonstrates that when a container fails to start due
to a missing container specified in VolumesFrom, it "remembers" a Volume
that worked.

Fixes: #8726

Signed-off-by: Thomas Orozco <thomas@orozco.fr>

Conflicts:
	integration-cli/docker_cli_start_test.go
		cli integration test
2014-11-12 00:14:04 +02:00
..
build_tests/TestCopy Rewrite TestContextTar tests to not use fixtures 2014-09-24 17:09:18 +04:00
docker_api_inspect_test.go integcli: lint fixes 2014-10-06 23:15:17 +03:00
docker_cli_attach_test.go Use prefix naming for attach tests 2014-09-19 21:56:25 +04:00
docker_cli_build_test.go builder: Restore /bin/sh handling in CMD when entrypoint is specified with JSON 2014-10-30 09:17:11 -04:00
docker_cli_commit_test.go integcli: lint fixes 2014-10-06 23:15:17 +03:00
docker_cli_cp_test.go
docker_cli_create_test.go Use prefix naming for create tests 2014-09-19 22:11:54 +04:00
docker_cli_daemon_test.go Setting iptables=false should propagate to ip-masq=false 2014-10-20 16:51:06 -04:00
docker_cli_diff_test.go
docker_cli_events_test.go integcli: lint fixes 2014-10-06 23:15:17 +03:00
docker_cli_exec_test.go test for panic on daemon restart 2014-09-18 21:54:42 +00:00
docker_cli_export_import_test.go
docker_cli_history_test.go integcli: lint fixes 2014-10-06 23:15:17 +03:00
docker_cli_images_test.go Removing an image that fails, also removes the image name/tag. 2014-09-11 11:29:25 -07:00
docker_cli_import_test.go integcli: lint fixes 2014-10-06 23:15:17 +03:00
docker_cli_info_test.go
docker_cli_inspect_test.go integcli: lint fixes 2014-10-06 23:15:17 +03:00
docker_cli_kill_test.go
docker_cli_links_test.go integcli: lint fixes 2014-10-06 23:15:17 +03:00
docker_cli_logs_test.go add the timeutils package 2014-09-17 14:30:08 +03:00
docker_cli_nat_test.go integcli: lint fixes 2014-10-06 23:15:17 +03:00
docker_cli_port_test.go Use prefix naming for port tests 2014-09-19 22:11:54 +04:00
docker_cli_ps_test.go Fix deadlock in ps exited filter 2014-11-07 16:35:50 +02:00
docker_cli_pull_test.go Pull all image aliases for id. Closes #8141. 2014-09-25 11:48:49 -07:00
docker_cli_push_test.go
docker_cli_restart_test.go Use prefix naming for restart tests 2014-09-19 22:11:54 +04:00
docker_cli_rm_test.go update test 2014-10-06 18:18:25 +00:00
docker_cli_rmi_test.go add test and move one from rm to rmi 2014-10-02 23:39:39 +00:00
docker_cli_run_test.go Clean volume paths 2014-10-20 19:11:44 -04:00
docker_cli_save_load_test.go integcli: fix permission detection for aufs 2014-09-19 21:08:57 +03:00
docker_cli_search_test.go
docker_cli_start_test.go Fix: Failed Start breaks VolumesFrom 2014-11-12 00:14:04 +02:00
docker_cli_tag_test.go Fix Tag Test for longer tags 2014-10-07 19:37:08 -07:00
docker_cli_top_test.go
docker_cli_version_test.go
docker_test_vars.go Clean volume paths 2014-10-20 19:11:44 -04:00
docker_utils.go Clean volume paths 2014-10-20 19:11:44 -04:00
MAINTAINERS
utils.go Fix Tag Test for longer tags 2014-10-07 19:37:08 -07:00