mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
d69d4799a3
The goal is to remove function from `docker_utils.go` and setup simple, one-responsability package that can be well tested ; and to ease writing request. This moves all the calls to `sockRequest` (and similar methods) to their counterpart in the `request` package. This introduce `request.Do` to write easier request (with functional argument to easily augment the request) with some pre-defined function for the most used http method (i.e. `request.Get`, `request.Post` and `request.Delete`). Few of the `sockRequest` call have been moved to `request.Do` (and `Get`, etc.) to showcase the usage of the package. There is still a whole lot to do. Signed-off-by: Vincent Demeester <vincent@sbr.pm>
124 lines
5 KiB
Go
124 lines
5 KiB
Go
package main
|
|
|
|
import (
|
|
"fmt"
|
|
"io/ioutil"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"runtime"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"github.com/docker/docker/api"
|
|
"github.com/docker/docker/integration-cli/checker"
|
|
"github.com/docker/docker/integration-cli/request"
|
|
"github.com/docker/docker/pkg/testutil"
|
|
icmd "github.com/docker/docker/pkg/testutil/cmd"
|
|
"github.com/go-check/check"
|
|
)
|
|
|
|
func (s *DockerSuite) TestAPIOptionsRoute(c *check.C) {
|
|
resp, _, err := request.Do(daemonHost(), "/", request.Method(http.MethodOptions))
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(resp.StatusCode, checker.Equals, http.StatusOK)
|
|
}
|
|
|
|
func (s *DockerSuite) TestAPIGetEnabledCORS(c *check.C) {
|
|
res, body, err := request.SockRequestRaw("GET", "/version", nil, "", daemonHost())
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(res.StatusCode, checker.Equals, http.StatusOK)
|
|
body.Close()
|
|
// TODO: @runcom incomplete tests, why old integration tests had this headers
|
|
// and here none of the headers below are in the response?
|
|
//c.Log(res.Header)
|
|
//c.Assert(res.Header.Get("Access-Control-Allow-Origin"), check.Equals, "*")
|
|
//c.Assert(res.Header.Get("Access-Control-Allow-Headers"), check.Equals, "Origin, X-Requested-With, Content-Type, Accept, X-Registry-Auth")
|
|
}
|
|
|
|
func (s *DockerSuite) TestAPIClientVersionOldNotSupported(c *check.C) {
|
|
if daemonPlatform != runtime.GOOS {
|
|
c.Skip("Daemon platform doesn't match test platform")
|
|
}
|
|
if api.MinVersion == api.DefaultVersion {
|
|
c.Skip("API MinVersion==DefaultVersion")
|
|
}
|
|
v := strings.Split(api.MinVersion, ".")
|
|
vMinInt, err := strconv.Atoi(v[1])
|
|
c.Assert(err, checker.IsNil)
|
|
vMinInt--
|
|
v[1] = strconv.Itoa(vMinInt)
|
|
version := strings.Join(v, ".")
|
|
|
|
resp, body, err := request.Get(daemonHost(), "/v"+version+"/version")
|
|
c.Assert(err, checker.IsNil)
|
|
defer body.Close()
|
|
c.Assert(resp.StatusCode, checker.Equals, http.StatusBadRequest)
|
|
expected := fmt.Sprintf("client version %s is too old. Minimum supported API version is %s, please upgrade your client to a newer version", version, api.MinVersion)
|
|
content, err := ioutil.ReadAll(body)
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(strings.TrimSpace(string(content)), checker.Contains, expected)
|
|
}
|
|
|
|
func (s *DockerSuite) TestAPIDockerAPIVersion(c *check.C) {
|
|
var svrVersion string
|
|
|
|
server := httptest.NewServer(http.HandlerFunc(
|
|
func(w http.ResponseWriter, r *http.Request) {
|
|
w.Header().Set("API-Version", api.DefaultVersion)
|
|
url := r.URL.Path
|
|
svrVersion = url
|
|
}))
|
|
defer server.Close()
|
|
|
|
// Test using the env var first
|
|
result := icmd.RunCmd(icmd.Cmd{
|
|
Command: binaryWithArgs("-H="+server.URL[7:], "version"),
|
|
Env: appendBaseEnv(false, "DOCKER_API_VERSION=xxx"),
|
|
})
|
|
c.Assert(result, icmd.Matches, icmd.Expected{Out: "API version: xxx", ExitCode: 1})
|
|
c.Assert(svrVersion, check.Equals, "/vxxx/version", check.Commentf("%s", result.Compare(icmd.Success)))
|
|
}
|
|
|
|
func (s *DockerSuite) TestAPIErrorJSON(c *check.C) {
|
|
httpResp, body, err := request.Post(daemonHost(), "/containers/create", request.JSONBody(struct{}{}))
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(httpResp.StatusCode, checker.Equals, http.StatusInternalServerError)
|
|
c.Assert(httpResp.Header.Get("Content-Type"), checker.Equals, "application/json")
|
|
b, err := testutil.ReadBody(body)
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(getErrorMessage(c, b), checker.Equals, "Config cannot be empty in order to create a container")
|
|
}
|
|
|
|
func (s *DockerSuite) TestAPIErrorPlainText(c *check.C) {
|
|
// Windows requires API 1.25 or later. This test is validating a behaviour which was present
|
|
// in v1.23, but changed in 1.24, hence not applicable on Windows. See apiVersionSupportsJSONErrors
|
|
testRequires(c, DaemonIsLinux)
|
|
httpResp, body, err := request.Post(daemonHost(), "/v1.23/containers/create", request.JSONBody(struct{}{}))
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(httpResp.StatusCode, checker.Equals, http.StatusInternalServerError)
|
|
c.Assert(httpResp.Header.Get("Content-Type"), checker.Contains, "text/plain")
|
|
b, err := testutil.ReadBody(body)
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(strings.TrimSpace(string(b)), checker.Equals, "Config cannot be empty in order to create a container")
|
|
}
|
|
|
|
func (s *DockerSuite) TestAPIErrorNotFoundJSON(c *check.C) {
|
|
// 404 is a different code path to normal errors, so test separately
|
|
httpResp, body, err := request.Get(daemonHost(), "/notfound", request.JSON)
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(httpResp.StatusCode, checker.Equals, http.StatusNotFound)
|
|
c.Assert(httpResp.Header.Get("Content-Type"), checker.Equals, "application/json")
|
|
b, err := testutil.ReadBody(body)
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(getErrorMessage(c, b), checker.Equals, "page not found")
|
|
}
|
|
|
|
func (s *DockerSuite) TestAPIErrorNotFoundPlainText(c *check.C) {
|
|
httpResp, body, err := request.Get(daemonHost(), "/v1.23/notfound", request.JSON)
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(httpResp.StatusCode, checker.Equals, http.StatusNotFound)
|
|
c.Assert(httpResp.Header.Get("Content-Type"), checker.Contains, "text/plain")
|
|
b, err := testutil.ReadBody(body)
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(strings.TrimSpace(string(b)), checker.Equals, "page not found")
|
|
}
|