mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
63906d8fae
Some improvements to the test; - Combine tests to reduce duplicated code - Add test-cases for empty version in request using the default version - Add test for valid versions in request actually setting the version Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
91 lines
2.4 KiB
Go
91 lines
2.4 KiB
Go
package middleware
|
|
|
|
import (
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"runtime"
|
|
"testing"
|
|
|
|
"github.com/docker/docker/api/server/httputils"
|
|
"github.com/stretchr/testify/assert"
|
|
"golang.org/x/net/context"
|
|
)
|
|
|
|
func TestVersionMiddlewareVersion(t *testing.T) {
|
|
defaultVersion := "1.10.0"
|
|
minVersion := "1.2.0"
|
|
expectedVersion := defaultVersion
|
|
handler := func(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
v := httputils.VersionFromContext(ctx)
|
|
assert.Equal(t, expectedVersion, v)
|
|
return nil
|
|
}
|
|
|
|
m := NewVersionMiddleware(defaultVersion, defaultVersion, minVersion)
|
|
h := m.WrapHandler(handler)
|
|
|
|
req, _ := http.NewRequest("GET", "/containers/json", nil)
|
|
resp := httptest.NewRecorder()
|
|
ctx := context.Background()
|
|
|
|
tests := []struct {
|
|
reqVersion string
|
|
expectedVersion string
|
|
errString string
|
|
}{
|
|
{
|
|
expectedVersion: "1.10.0",
|
|
},
|
|
{
|
|
reqVersion: "1.9.0",
|
|
expectedVersion: "1.9.0",
|
|
},
|
|
{
|
|
reqVersion: "0.1",
|
|
errString: "client version 0.1 is too old. Minimum supported API version is 1.2.0, please upgrade your client to a newer version",
|
|
},
|
|
{
|
|
reqVersion: "9999.9999",
|
|
errString: "client version 9999.9999 is too new. Maximum supported API version is 1.10.0",
|
|
},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
expectedVersion = test.expectedVersion
|
|
|
|
err := h(ctx, resp, req, map[string]string{"version": test.reqVersion})
|
|
|
|
if test.errString != "" {
|
|
assert.EqualError(t, err, test.errString)
|
|
} else {
|
|
assert.NoError(t, err)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestVersionMiddlewareWithErrorsReturnsHeaders(t *testing.T) {
|
|
handler := func(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
|
|
v := httputils.VersionFromContext(ctx)
|
|
assert.NotEmpty(t, v)
|
|
return nil
|
|
}
|
|
|
|
defaultVersion := "1.10.0"
|
|
minVersion := "1.2.0"
|
|
m := NewVersionMiddleware(defaultVersion, defaultVersion, minVersion)
|
|
h := m.WrapHandler(handler)
|
|
|
|
req, _ := http.NewRequest("GET", "/containers/json", nil)
|
|
resp := httptest.NewRecorder()
|
|
ctx := context.Background()
|
|
|
|
vars := map[string]string{"version": "0.1"}
|
|
err := h(ctx, resp, req, vars)
|
|
assert.Error(t, err)
|
|
|
|
hdr := resp.Result().Header
|
|
assert.Contains(t, hdr.Get("Server"), "Docker/"+defaultVersion)
|
|
assert.Contains(t, hdr.Get("Server"), runtime.GOOS)
|
|
assert.Equal(t, hdr.Get("API-Version"), defaultVersion)
|
|
assert.Equal(t, hdr.Get("OSType"), runtime.GOOS)
|
|
}
|