1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
moby--moby/libnetwork
Max Timchenko fc2414f988 Ensure iptables initialization only happens once
I saw a rare race during the first few calls to iptables module
where some of them would reenter initCheck() after the first call
to it already changed iptablesPath, but before the rest of the function
completed (in particular the long execs into testing for availability
of --wait flag and determining iptables version), resulting in
failure of one or more of iptables calls that did not use --wait and
were concurrent.

To fix the problem, this change gathers all one-time initialization into a
single function under a sync.Once instead of using a global variable
as a "done initializing" flag before initialization is done. sync.Once
guarantees all concurrent calls will block until the first one completes.

In addition, it turns out that GetVersion(), called from initCheck(), used
Raw() which called back into initCheck() via raw(), which did not cause a
problem in the earlier implementation but deadlocked when initialization became
strict.  This was changed to use a direct call, similar to initialization of
supportsXlock.

Signed-off-by: Max Timchenko <max@maxvt.com>
2017-03-08 20:37:13 +02:00
..
api
bitseq Merge pull request #1568 from likel/refactor 2016-12-29 12:18:06 -08:00
client
cluster
cmd proxy: clean up code (addendum to #1598) 2017-01-12 04:46:23 +00:00
config Revert "validate network and endpoint name more strictly" 2017-02-01 18:18:17 -08:00
datastore replace individual endpoint_cnt read from store with 1 bulk read 2017-02-02 14:45:38 -08:00
discoverapi
docs Fix typo in IPAM doc 2017-02-13 18:35:32 +08:00
driverapi Merge pull request #1604 from allencloud/fix-nits-in-comments 2016-12-29 12:20:04 -08:00
drivers Merge pull request #961 from JrCs/fix-iptables-order 2017-03-05 20:28:22 -08:00
drvregistry Merge pull request #1568 from likel/refactor 2016-12-29 12:18:06 -08:00
etchosts
hostdiscovery
idm Merge pull request #1568 from likel/refactor 2016-12-29 12:18:06 -08:00
ipam Merge pull request #1568 from likel/refactor 2016-12-29 12:18:06 -08:00
ipamapi
ipams Merge pull request #1599 from mavenugo/v0.9 2017-01-04 15:02:06 -08:00
ipamutils
iptables Ensure iptables initialization only happens once 2017-03-08 20:37:13 +02:00
ipvs handle err and fix t.Skip() in ipvs/ipvs_test.go 2017-02-07 14:31:11 +08:00
netlabel
netutils
networkdb Generating node discovery events to the drivers from networkdb 2017-02-01 17:54:51 -08:00
ns
options
osl Lock linux namespace structure when adding neighbors 2017-03-02 00:04:09 -08:00
portallocator
portmapper
resolvconf Fix GetNameServerAsCIDR 2017-01-26 01:34:07 -08:00
test/integration
testutils
types
vendor Use vndr for managing libnetwork dependencies 2017-01-11 17:22:05 -08:00
.dockerignore
.gitignore
agent.go Add anonymous container alias to service record on attachable network 2017-03-02 12:28:39 -08:00
agent.pb.go
agent.proto
CHANGELOG.md
circle.yml
controller.go Merge pull request #1658 from aboch/iptlck 2017-02-22 11:04:37 -08:00
default_gateway.go
default_gateway_freebsd.go
default_gateway_linux.go
default_gateway_solaris.go
default_gateway_windows.go
Dockerfile.build
drivers_experimental_linux.go
drivers_freebsd.go
drivers_ipam.go
drivers_linux.go
drivers_solaris.go
drivers_windows.go
endpoint.go
endpoint_cnt.go
endpoint_info.go Trust the endpoint state if we have a valid sandbox-id 2017-02-02 14:46:59 -08:00
endpoint_info_unix.go
endpoint_info_windows.go
error.go Revert "validate network and endpoint name more strictly" 2017-02-01 18:18:17 -08:00
errors_test.go
libnetwork_internal_test.go
libnetwork_linux_test.go
libnetwork_test.go
LICENSE
machines
MAINTAINERS Update maintainers file 2017-03-06 19:30:37 +01:00
Makefile Use vndr for managing libnetwork dependencies 2017-01-11 17:22:05 -08:00
network.go Add logs around service records modifications 2017-02-24 10:20:30 -08:00
network_unix.go
network_windows.go
README.md
resolver.go Fix the data model inconsistency that breaks daemon upgrade to 1.14-dev 2017-01-19 14:25:26 -08:00
resolver_unix.go
resolver_windows.go
ROADMAP.md
sandbox.go Merge pull request #1609 from aboch/gw46 2017-01-05 13:00:01 -08:00
sandbox_dns_unix.go Fix the data model inconsistency that breaks daemon upgrade to 1.14-dev 2017-01-19 14:25:26 -08:00
sandbox_dns_windows.go
sandbox_externalkey.go
sandbox_externalkey_solaris.go
sandbox_externalkey_unix.go
sandbox_externalkey_windows.go
sandbox_store.go Fix the data model inconsistency that breaks daemon upgrade to 1.14-dev 2017-01-19 14:25:26 -08:00
sandbox_test.go
service.go
service_common.go Make virtual service programming more robust 2017-02-01 15:54:31 -08:00
service_linux.go Fix service logs 2017-02-01 17:32:08 -08:00
service_unsupported.go
service_windows.go Make virtual service programming more robust 2017-02-01 15:54:31 -08:00
store.go replace individual endpoint_cnt read from store with 1 bulk read 2017-02-02 14:45:38 -08:00
store_linux_test.go
store_test.go
support.sh
Vagrantfile
vendor.conf Use vndr for managing libnetwork dependencies 2017-01-11 17:22:05 -08:00
wrapmake.sh

libnetwork - networking for containers

Circle CI Coverage Status GoDoc

Libnetwork provides a native Go implementation for connecting containers

The goal of libnetwork is to deliver a robust Container Network Model that provides a consistent programming interface and the required network abstractions for applications.

Design

Please refer to the design for more information.

Using libnetwork

There are many networking solutions available to suit a broad range of use-cases. libnetwork uses a driver / plugin model to support all of these solutions while abstracting the complexity of the driver implementations by exposing a simple and consistent Network Model to users.

func main() {
	if reexec.Init() {
		return
	}

	// Select and configure the network driver
	networkType := "bridge"

	// Create a new controller instance
	driverOptions := options.Generic{}
	genericOption := make(map[string]interface{})
	genericOption[netlabel.GenericData] = driverOptions
	controller, err := libnetwork.New(config.OptionDriverConfig(networkType, genericOption))
	if err != nil {
		log.Fatalf("libnetwork.New: %s", err)
	}

	// Create a network for containers to join.
	// NewNetwork accepts Variadic optional arguments that libnetwork and Drivers can use.
	network, err := controller.NewNetwork(networkType, "network1", "")
	if err != nil {
		log.Fatalf("controller.NewNetwork: %s", err)
	}

	// For each new container: allocate IP and interfaces. The returned network
	// settings will be used for container infos (inspect and such), as well as
	// iptables rules for port publishing. This info is contained or accessible
	// from the returned endpoint.
	ep, err := network.CreateEndpoint("Endpoint1")
	if err != nil {
		log.Fatalf("network.CreateEndpoint: %s", err)
	}

	// Create the sandbox for the container.
	// NewSandbox accepts Variadic optional arguments which libnetwork can use.
	sbx, err := controller.NewSandbox("container1",
		libnetwork.OptionHostname("test"),
		libnetwork.OptionDomainname("docker.io"))
	if err != nil {
		log.Fatalf("controller.NewSandbox: %s", err)
	}

	// A sandbox can join the endpoint via the join api.
	err = ep.Join(sbx)
	if err != nil {
		log.Fatalf("ep.Join: %s", err)
	}

	// libnetwork client can check the endpoint's operational data via the Info() API
	epInfo, err := ep.DriverInfo()
	if err != nil {
		log.Fatalf("ep.DriverInfo: %s", err)
	}

	macAddress, ok := epInfo[netlabel.MacAddress]
	if !ok {
		log.Fatalf("failed to get mac address from endpoint info")
	}

	fmt.Printf("Joined endpoint %s (%s) to sandbox %s (%s)\n", ep.Name(), macAddress, sbx.ContainerID(), sbx.Key())
}

Future

Please refer to roadmap for more information.

Contributing

Want to hack on libnetwork? Docker's contributions guidelines apply.

Code and documentation copyright 2015 Docker, inc. Code released under the Apache 2.0 license. Docs released under Creative commons.