mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
4a0704cdbd
The source of a tag operation is allowed to be a 64-character hex string. This means it should use ParseAnyReference for validation instead of ParseNormalizedNamed. This fixes a regression that happened in 17.04. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
37 lines
1 KiB
Go
37 lines
1 KiB
Go
package client
|
|
|
|
import (
|
|
"net/url"
|
|
|
|
"github.com/docker/distribution/reference"
|
|
"github.com/pkg/errors"
|
|
"golang.org/x/net/context"
|
|
)
|
|
|
|
// ImageTag tags an image in the docker host
|
|
func (cli *Client) ImageTag(ctx context.Context, source, target string) error {
|
|
if _, err := reference.ParseAnyReference(source); err != nil {
|
|
return errors.Wrapf(err, "Error parsing reference: %q is not a valid repository/tag", source)
|
|
}
|
|
|
|
ref, err := reference.ParseNormalizedNamed(target)
|
|
if err != nil {
|
|
return errors.Wrapf(err, "Error parsing reference: %q is not a valid repository/tag", target)
|
|
}
|
|
|
|
if _, isCanonical := ref.(reference.Canonical); isCanonical {
|
|
return errors.New("refusing to create a tag with a digest reference")
|
|
}
|
|
|
|
ref = reference.TagNameOnly(ref)
|
|
|
|
query := url.Values{}
|
|
query.Set("repo", reference.FamiliarName(ref))
|
|
if tagged, ok := ref.(reference.Tagged); ok {
|
|
query.Set("tag", tagged.Tag())
|
|
}
|
|
|
|
resp, err := cli.post(ctx, "/images/"+source+"/tag", query, nil, nil)
|
|
ensureReaderClosed(resp)
|
|
return err
|
|
}
|