1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
moby--moby/libnetwork
Alexander Morozov d0f3f77432 bitseq: fix race between CopyTo and set
Race detector message:

WARNING: DATA RACE
Write by goroutine 269:
  github.com/docker/libnetwork/bitseq.(*Handle).CopyTo()
      /home/moroz/project/workspace/src/github.com/docker/docker/vendor/src/github.com/docker/libnetwork/bitseq/store.go:85 +0x2f6
  github.com/docker/libnetwork/datastore.(*cache).get()
      /home/moroz/project/workspace/src/github.com/docker/docker/vendor/src/github.com/docker/libnetwork/datastore/cache.go:135 +0x307
  github.com/docker/libnetwork/datastore.(*datastore).GetObject()
      /home/moroz/project/workspace/src/github.com/docker/docker/vendor/src/github.com/docker/libnetwork/datastore/datastore.go:438 +0x121
  github.com/docker/libnetwork/bitseq.(*Handle).set()
      /home/moroz/project/workspace/src/github.com/docker/docker/vendor/src/github.com/docker/libnetwork/bitseq/sequence.go:254 +0x1a5
  github.com/docker/libnetwork/bitseq.(*Handle).Unset()
      /home/moroz/project/workspace/src/github.com/docker/docker/vendor/src/github.com/docker/libnetwork/bitseq/sequence.go:227 +0xb0
  github.com/docker/libnetwork/ipam.(*Allocator).ReleaseAddress()
      /home/moroz/project/workspace/src/github.com/docker/docker/vendor/src/github.com/docker/libnetwork/ipam/allocator.go:446 +0x10bc
  github.com/docker/libnetwork.(*endpoint).releaseAddress()
      /home/moroz/project/workspace/src/github.com/docker/docker/vendor/src/github.com/docker/libnetwork/endpoint.go:830 +0x731
  github.com/docker/libnetwork.(*endpoint).Delete()
      /home/moroz/project/workspace/src/github.com/docker/docker/vendor/src/github.com/docker/libnetwork/endpoint.go:624 +0x8d8
  github.com/docker/libnetwork.(*sandbox).Delete()
      /home/moroz/project/workspace/src/github.com/docker/docker/vendor/src/github.com/docker/libnetwork/sandbox.go:191 +0x1047
  github.com/docker/docker/daemon.(*Daemon).releaseNetwork()
      /home/moroz/project/workspace/src/github.com/docker/docker/daemon/container_unix.go:1180 +0x676
  github.com/docker/docker/daemon.(*Daemon).Cleanup()
      /home/moroz/project/workspace/src/github.com/docker/docker/daemon/start.go:157 +0x5d
  github.com/docker/docker/daemon.(*containerMonitor).Close()
      /home/moroz/project/workspace/src/github.com/docker/docker/daemon/monitor.go:111 +0xa4
  github.com/docker/docker/daemon.(*containerMonitor).Start.func1()
      /home/moroz/project/workspace/src/github.com/docker/docker/daemon/monitor.go:142 +0x14b
  github.com/docker/docker/daemon.(*containerMonitor).Start()
      /home/moroz/project/workspace/src/github.com/docker/docker/daemon/monitor.go:223 +0x1159
  github.com/docker/docker/daemon.(*containerMonitor).Start-fm()
      /home/moroz/project/workspace/src/github.com/docker/docker/daemon/start.go:147 +0x3b
  github.com/docker/docker/pkg/promise.Go.func1()
      /home/moroz/project/workspace/src/github.com/docker/docker/pkg/promise/promise.go:8 +0x2a

Previous read by goroutine 340:
  github.com/docker/libnetwork/bitseq.(*Handle).set()
      /home/moroz/project/workspace/src/github.com/docker/docker/vendor/src/github.com/docker/libnetwork/bitseq/sequence.go:254 +0x133
  github.com/docker/libnetwork/bitseq.(*Handle).Unset()
      /home/moroz/project/workspace/src/github.com/docker/docker/vendor/src/github.com/docker/libnetwork/bitseq/sequence.go:227 +0xb0
  github.com/docker/libnetwork/ipam.(*Allocator).ReleaseAddress()
      /home/moroz/project/workspace/src/github.com/docker/docker/vendor/src/github.com/docker/libnetwork/ipam/allocator.go:446 +0x10bc
  github.com/docker/libnetwork.(*endpoint).releaseAddress()
      /home/moroz/project/workspace/src/github.com/docker/docker/vendor/src/github.com/docker/libnetwork/endpoint.go:830 +0x731
  github.com/docker/libnetwork.(*endpoint).Delete()
      /home/moroz/project/workspace/src/github.com/docker/docker/vendor/src/github.com/docker/libnetwork/endpoint.go:624 +0x8d8
  github.com/docker/libnetwork.(*sandbox).Delete()
      /home/moroz/project/workspace/src/github.com/docker/docker/vendor/src/github.com/docker/libnetwork/sandbox.go:191 +0x1047
  github.com/docker/docker/daemon.(*Daemon).releaseNetwork()
      /home/moroz/project/workspace/src/github.com/docker/docker/daemon/container_unix.go:1180 +0x676
  github.com/docker/docker/daemon.(*Daemon).Cleanup()
      /home/moroz/project/workspace/src/github.com/docker/docker/daemon/start.go:157 +0x5d
  github.com/docker/docker/daemon.(*containerMonitor).Close()
      /home/moroz/project/workspace/src/github.com/docker/docker/daemon/monitor.go:111 +0xa4
  github.com/docker/docker/daemon.(*containerMonitor).Start.func1()
      /home/moroz/project/workspace/src/github.com/docker/docker/daemon/monitor.go:142 +0x14b
  github.com/docker/docker/daemon.(*containerMonitor).Start()
      /home/moroz/project/workspace/src/github.com/docker/docker/daemon/monitor.go:223 +0x1159
  github.com/docker/docker/daemon.(*containerMonitor).Start-fm()
      /home/moroz/project/workspace/src/github.com/docker/docker/daemon/start.go:147 +0x3b
  github.com/docker/docker/pkg/promise.Go.func1()
      /home/moroz/project/workspace/src/github.com/docker/docker/pkg/promise/promise.go:8 +0x2a

Signed-off-by: Alexander Morozov <lk4d4@docker.com>
2015-11-30 13:18:52 -08:00
..
api Changed Labels to DriverOpts 2015-10-14 16:38:46 -07:00
bitseq bitseq: fix race between CopyTo and set 2015-11-30 13:18:52 -08:00
client Changed Labels to DriverOpts 2015-10-14 16:38:46 -07:00
cmd Add IT case for external connectivity 2015-10-28 19:10:38 -07:00
config Moved the default local and global store to new root 2015-10-11 22:57:24 -07:00
datastore Format the code 2015-10-27 00:45:48 +08:00
docs Tidy up the IPAM driver doc 2015-10-26 12:47:05 +00:00
driverapi Remove always-on watch for networks and endpoints 2015-10-06 14:15:49 -07:00
drivers Merge pull request #591 from WeiZhang555/iptables-clean 2015-11-25 09:12:10 -08:00
etchosts Synchronize /etc/hosts updates at file level 2015-10-21 07:45:29 -07:00
Godeps godeps: update coreos/go-systemd to v4 and godbus/dbus to v3 2015-11-20 00:19:47 +01:00
hostdiscovery Add watch retrigger when store restarts 2015-10-21 21:45:52 -07:00
idm Remove 2^32 bits restriction on bitsequence 2015-10-10 05:42:26 -07:00
ipam English please. 2015-11-23 20:05:13 +00:00
ipamapi IPAM driver doc 2015-10-12 16:39:24 -07:00
ipams Allow remote ipam driver to return nil address 2015-10-20 23:08:59 -07:00
ipamutils Explicitly set namepsace for ipamutils.ElectInterface 2015-10-15 22:16:40 -07:00
iptables Merge pull request #591 from WeiZhang555/iptables-clean 2015-11-25 09:12:10 -08:00
netlabel move Labels from array to map to be consistent with cotnainers 2015-10-09 11:08:13 -07:00
netutils Multi-Arch Support 2015-11-25 22:47:41 +00:00
ns Move test specific functions to a testutils package. 2015-09-07 13:33:28 -04:00
options Move test specific functions to a testutils package. 2015-09-07 13:33:28 -04:00
osl Moved InterfaceStatistics from osl into types package 2015-09-26 10:12:20 -07:00
portallocator Move test specific functions to a testutils package. 2015-09-07 13:33:28 -04:00
portmapper Move test specific functions to a testutils package. 2015-09-07 13:33:28 -04:00
resolvconf fix the regexp for matching an ip address 2015-10-04 01:10:25 -07:00
test/integration Multi-Arch Support 2015-11-25 22:47:41 +00:00
testutils Move test specific functions to a testutils package. 2015-09-07 13:33:28 -04:00
types Enable Network labels in backend 2015-10-09 01:06:15 -07:00
.dockerignore Multi-Arch Support 2015-11-25 22:47:41 +00:00
.gitignore Multi-Arch Support 2015-11-25 22:47:41 +00:00
circle.yml Multi-Arch Support 2015-11-25 22:47:41 +00:00
controller.go Clean unused variables and fix typo 2015-11-06 11:38:33 +08:00
default_gateway.go Default Gateway endpoints must be annonymous 2015-10-23 16:52:11 -07:00
default_gateway_freebsd.go Made use of map[string]string for nw options in default-gateway impl 2015-10-12 15:28:28 -07:00
default_gateway_linux.go Made use of map[string]string for nw options in default-gateway impl 2015-10-12 15:28:28 -07:00
default_gateway_windows.go Made use of map[string]string for nw options in default-gateway impl 2015-10-12 15:28:28 -07:00
Dockerfile.build Multi-Arch Support 2015-11-25 22:47:41 +00:00
drivers.go Pass down store configs to driver 2015-10-06 17:28:47 -07:00
drivers_freebsd.go Push driver config during Init 2015-09-19 08:43:34 -07:00
drivers_linux.go Push driver config during Init 2015-09-19 08:43:34 -07:00
drivers_windows.go Push driver config during Init 2015-09-19 08:43:34 -07:00
endpoint.go Fix a couple of edge cases in service discovery 2015-11-25 15:25:56 -08:00
endpoint_cnt.go Some functions' logic cleanup 2015-10-27 11:08:42 -07:00
endpoint_info.go Fix in endpoint Info() method 2015-11-22 21:44:06 -08:00
error.go Fixed a couple of error messages to address UX related comments 2015-10-09 01:45:24 -07:00
errors_test.go Provide interface to categorize errors 2015-05-20 22:29:29 -07:00
libnetwork_internal_test.go Allow anonymous endpoint 2015-10-20 14:05:46 -07:00
libnetwork_test.go Allow IPv6 allocation post endpoint create 2015-11-10 14:53:19 -08:00
LICENSE
machines Use Docker Machine for Test Environments 2015-11-10 21:47:59 +00:00
MAINTAINERS Add Alessandro as a libnetwork maintainer 2015-05-29 18:46:33 +00:00
Makefile Multi-Arch Support 2015-11-25 22:47:41 +00:00
network.go libnetwork to honor explicit mac-address 2015-11-14 13:17:43 -08:00
README.md Fix outdated docs and comments 2015-09-22 23:47:44 +08:00
ROADMAP.md Update ROADMAP.md 2015-06-09 15:06:02 -07:00
sandbox.go Fix a couple of edge cases in service discovery 2015-11-25 15:25:56 -08:00
sandbox_externalkey.go sandbox_externalkey.go: split for cross compilation 2015-11-26 00:18:27 +01:00
sandbox_externalkey_unix.go sandbox_externalkey.go: split for cross compilation 2015-11-26 00:18:27 +01:00
sandbox_externalkey_windows.go sandbox_externalkey.go: split for cross compilation 2015-11-26 00:18:27 +01:00
sandbox_store.go Skip non-persistent endpoints in sandbox store 2015-11-02 08:09:49 -08:00
sandbox_test.go Remove always-on watch for networks and endpoints 2015-10-06 14:15:49 -07:00
store.go Remove redundant assignment to ep.network 2015-11-12 10:38:41 -08:00
store_test.go Add customer_prefix to the store URL for integration test 2015-10-26 17:48:52 +08:00
Vagrantfile Fixed Vagrantfile to use systemd script 2015-10-16 05:03:47 -07:00
wrapmake.sh Allow tests to be interrupted 2015-09-01 21:48:09 -07:00

libnetwork - networking for containers

Circle CI Coverage Status GoDoc

Libnetwork provides a native Go implementation for connecting containers

The goal of libnetwork is to deliver a robust Container Network Model that provides a consistent programming interface and the required network abstractions for applications.

NOTE: libnetwork project is under heavy development and is not ready for general use.

Design

Please refer to the design for more information.

Using libnetwork

There are many networking solutions available to suit a broad range of use-cases. libnetwork uses a driver / plugin model to support all of these solutions while abstracting the complexity of the driver implementations by exposing a simple and consistent Network Model to users.

	// Select and configure the network driver
	networkType := "bridge"

	// Create a new controller instance
	driverOptions := options.Generic{}
	genericOption := make(map[string]interface{})
	genericOption[netlabel.GenericData] = driverOptions
	controller, err := libnetwork.New(config.OptionDriverConfig(networkType, genericOption))
	if err != nil {
		return
	}

	// Create a network for containers to join.
	// NewNetwork accepts Variadic optional arguments that libnetwork and Drivers can use.
	network, err := controller.NewNetwork(networkType, "network1")
	if err != nil {
		return
	}

	// For each new container: allocate IP and interfaces. The returned network
	// settings will be used for container infos (inspect and such), as well as
	// iptables rules for port publishing. This info is contained or accessible
	// from the returned endpoint.
	ep, err := network.CreateEndpoint("Endpoint1")
	if err != nil {
		return
	}

	// Create the sandbox for the container.
	// NewSandbox accepts Variadic optional arguments which libnetwork can use.
	sbx, err := controller.NewSandbox("container1",
		libnetwork.OptionHostname("test"),
		libnetwork.OptionDomainname("docker.io"))

	// A sandbox can join the endpoint via the join api.
	err = ep.Join(sbx)
	if err != nil {
		return
	}

	// libnetwork client can check the endpoint's operational data via the Info() API
	epInfo, err := ep.DriverInfo()
	mapData, ok := epInfo[netlabel.PortMap]
	if ok {
		portMapping, ok := mapData.([]types.PortBinding)
		if ok {
			fmt.Printf("Current port mapping for endpoint %s: %v", ep.Name(), portMapping)
		}
	}

Current Status

Please watch this space for updates on the progress.

Currently libnetwork is nothing more than an attempt to modularize the Docker platform's networking subsystem by moving it into libnetwork as a library.

Future

Please refer to roadmap for more information.

Contributing

Want to hack on libnetwork? Docker's contributions guidelines apply.

Code and documentation copyright 2015 Docker, inc. Code released under the Apache 2.0 license. Docs released under Creative commons.