mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
54dcbab25e
Before this, if `forceRemove` is set the container data will be removed no matter what, including if there are issues with removing container on-disk state (rw layer, container root). In practice this causes a lot of issues with leaked data sitting on disk that users are not able to clean up themselves. This is particularly a problem while the `EBUSY` errors on remove are so prevalent. So for now let's not keep this behavior. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
84 lines
1.7 KiB
Go
84 lines
1.7 KiB
Go
package system
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"os"
|
|
"path/filepath"
|
|
"runtime"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/docker/docker/pkg/mount"
|
|
)
|
|
|
|
func TestEnsureRemoveAllNotExist(t *testing.T) {
|
|
// should never return an error for a non-existent path
|
|
if err := EnsureRemoveAll("/non/existent/path"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
func TestEnsureRemoveAllWithDir(t *testing.T) {
|
|
dir, err := ioutil.TempDir("", "test-ensure-removeall-with-dir")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := EnsureRemoveAll(dir); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
func TestEnsureRemoveAllWithFile(t *testing.T) {
|
|
tmp, err := ioutil.TempFile("", "test-ensure-removeall-with-dir")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
tmp.Close()
|
|
if err := EnsureRemoveAll(tmp.Name()); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
func TestEnsureRemoveAllWithMount(t *testing.T) {
|
|
if runtime.GOOS == "windows" {
|
|
t.Skip("mount not supported on Windows")
|
|
}
|
|
|
|
dir1, err := ioutil.TempDir("", "test-ensure-removeall-with-dir1")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
dir2, err := ioutil.TempDir("", "test-ensure-removeall-with-dir2")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(dir2)
|
|
|
|
bindDir := filepath.Join(dir1, "bind")
|
|
if err := os.MkdirAll(bindDir, 0755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if err := mount.Mount(dir2, bindDir, "none", "bind"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
done := make(chan struct{})
|
|
go func() {
|
|
err = EnsureRemoveAll(dir1)
|
|
close(done)
|
|
}()
|
|
|
|
select {
|
|
case <-done:
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
case <-time.After(5 * time.Second):
|
|
t.Fatal("timeout waiting for EnsureRemoveAll to finish")
|
|
}
|
|
|
|
if _, err := os.Stat(dir1); !os.IsNotExist(err) {
|
|
t.Fatalf("expected %q to not exist", dir1)
|
|
}
|
|
}
|