mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
bfcd95817a
Remove the block comment which is stale, and redundant now that the function is just as readable as the comment. Signed-off-by: Daniel Nephin <dnephin@docker.com>
82 lines
2.5 KiB
Go
82 lines
2.5 KiB
Go
package dockerfile
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/docker/docker/api/types"
|
|
"github.com/docker/docker/builder"
|
|
"github.com/docker/docker/pkg/archive"
|
|
"github.com/docker/docker/pkg/testutil/assert"
|
|
)
|
|
|
|
func TestEmptyDockerfile(t *testing.T) {
|
|
contextDir, cleanup := createTestTempDir(t, "", "builder-dockerfile-test")
|
|
defer cleanup()
|
|
|
|
createTestTempFile(t, contextDir, builder.DefaultDockerfileName, "", 0777)
|
|
|
|
readAndCheckDockerfile(t, "emptyDockerfile", contextDir, "", "The Dockerfile (Dockerfile) cannot be empty")
|
|
}
|
|
|
|
func TestSymlinkDockerfile(t *testing.T) {
|
|
contextDir, cleanup := createTestTempDir(t, "", "builder-dockerfile-test")
|
|
defer cleanup()
|
|
|
|
createTestSymlink(t, contextDir, builder.DefaultDockerfileName, "/etc/passwd")
|
|
|
|
// The reason the error is "Cannot locate specified Dockerfile" is because
|
|
// in the builder, the symlink is resolved within the context, therefore
|
|
// Dockerfile -> /etc/passwd becomes etc/passwd from the context which is
|
|
// a nonexistent file.
|
|
expectedError := fmt.Sprintf("Cannot locate specified Dockerfile: %s", builder.DefaultDockerfileName)
|
|
|
|
readAndCheckDockerfile(t, "symlinkDockerfile", contextDir, builder.DefaultDockerfileName, expectedError)
|
|
}
|
|
|
|
func TestDockerfileOutsideTheBuildContext(t *testing.T) {
|
|
contextDir, cleanup := createTestTempDir(t, "", "builder-dockerfile-test")
|
|
defer cleanup()
|
|
|
|
expectedError := "Forbidden path outside the build context"
|
|
|
|
readAndCheckDockerfile(t, "DockerfileOutsideTheBuildContext", contextDir, "../../Dockerfile", expectedError)
|
|
}
|
|
|
|
func TestNonExistingDockerfile(t *testing.T) {
|
|
contextDir, cleanup := createTestTempDir(t, "", "builder-dockerfile-test")
|
|
defer cleanup()
|
|
|
|
expectedError := "Cannot locate specified Dockerfile: Dockerfile"
|
|
|
|
readAndCheckDockerfile(t, "NonExistingDockerfile", contextDir, "Dockerfile", expectedError)
|
|
}
|
|
|
|
func readAndCheckDockerfile(t *testing.T, testName, contextDir, dockerfilePath, expectedError string) {
|
|
tarStream, err := archive.Tar(contextDir, archive.Uncompressed)
|
|
assert.NilError(t, err)
|
|
|
|
defer func() {
|
|
if err = tarStream.Close(); err != nil {
|
|
t.Fatalf("Error when closing tar stream: %s", err)
|
|
}
|
|
}()
|
|
|
|
context, err := builder.MakeTarSumContext(tarStream)
|
|
assert.NilError(t, err)
|
|
|
|
defer func() {
|
|
if err = context.Close(); err != nil {
|
|
t.Fatalf("Error when closing tar context: %s", err)
|
|
}
|
|
}()
|
|
|
|
options := &types.ImageBuildOptions{
|
|
Dockerfile: dockerfilePath,
|
|
}
|
|
|
|
b := &Builder{options: options, context: context}
|
|
|
|
_, err = b.readAndParseDockerfile()
|
|
assert.Error(t, err, expectedError)
|
|
}
|