Sebastiaan van Stijn 010adeec55 Builder: print relative path if COPY/ADD source path was not found ... Before this change, the error returned to the user would include the physical path inside the tmp dir on the daemon host. These paths should be considered an implementation detail, and provide no value to the user. Printing the tmp path can confuse users, and will be even more confusing if the daemon is running remotely (or in a VM, such as on Docker Desktop), in which case the path in the error message does not exist on the local machine; echo -e "FROM busybox\nCOPY /some/non-existing/file.txt ." | DOCKER_BUILDKIT=0 docker build -f- . Sending build context to Docker daemon 1.57kB Step 1/2 : FROM busybox ---> 1c35c4412082 Step 2/2 : COPY /some/non-existing/file.txt . COPY failed: stat /var/lib/docker/tmp/docker-builder405687992/some/non-existing/file.txt: no such file or directory When copying files from an image or a build stage, using `--from`, the error is similarly confusing: echo -e "FROM busybox\nCOPY --from=busybox /some/non-existing/file.txt ." | DOCKER_BUILDKIT=0 docker build -f- . Sending build context to Docker daemon 4.671kB Step 1/2 : FROM busybox ---> 018c9d7b792b Step 2/2 : COPY --from=busybox /some/non-existing/file.txt . COPY failed: stat /var/lib/docker/overlay2/ef34239c80526c779b7afaeaedbf11c1b201d7f7681d45613102c4541da0e156/merged/some/non-existing/file.txt: no such file or directory This patch updates the error messages to be more user-friendly. Changes are slightly different, depending on if the source was a local path, or an image (or build-stage), using `--from`. If `--from` is used, only the path is updated, and we print the relative path instead of the full path; echo -e "FROM busybox\nCOPY --from=busybox /some/non-existing/file.txt ." | DOCKER_BUILDKIT=0 docker build -f- . Sending build context to Docker daemon 1.583kB Step 1/2 : FROM busybox ---> 018c9d7b792b Step 2/2 : COPY --from=busybox /some/non-existing/file.txt . COPY failed: stat some/non-existing/file.txt: file does not exist In other cases, additional information is added to mention "build context" and ".dockerignore", which could provide the user some hints to find the problem: echo -e "FROM busybox\nCOPY /some/non-existing/file.txt ." | DOCKER_BUILDKIT=0 docker build -f- . Sending build context to Docker daemon 1.583kB Step 1/2 : FROM busybox ---> 018c9d7b792b Step 2/2 : COPY /some/non-existing/file.txt . COPY failed: file not found in build context or excluded by .dockerignore: stat some/non-existing/file.txt: file does not exist echo -e "FROM busybox\nADD /some/non-existing/file.txt ." | DOCKER_BUILDKIT=0 docker build -f- . Sending build context to Docker daemon 1.583kB Step 1/2 : FROM busybox ---> 018c9d7b792b Step 2/2 : ADD /some/non-existing/file.txt . ADD failed: file not found in build context or excluded by .dockerignore: stat some/non-existing/file.txt: file does not exist This patch only improves the error for the classic builder. Similar changes could be made for BuildKit, which produces equally, or even more confusing errors; echo -e "FROM busybox\nCOPY /some/non-existing/file.txt ." | DOCKER_BUILDKIT=1 docker build -f- . [+] Building 1.2s (6/6) FINISHED => [internal] load build definition from Dockerfile 0.0s => => transferring dockerfile: 85B 0.0s => [internal] load .dockerignore 0.0s => => transferring context: 2B 0.0s => [internal] load metadata for docker.io/library/busybox:latest 1.2s => [internal] load build context 0.0s => => transferring context: 2B 0.0s => CACHED [1/2] FROM docker.io/library/busybox@sha256:4f47c01... 0.0s => ERROR [2/2] COPY /some/non-existing/file.txt . 0.0s ------ > [2/2] COPY /some/non-existing/file.txt .: ------ failed to compute cache key: failed to walk /var/lib/docker/tmp/buildkit-mount181923793/some/non-existing: lstat /var/lib/docker/tmp/buildkit-mount181923793/some/non-existing: no such file or directory echo -e "FROM busybox\nCOPY --from=busybox /some/non-existing/file.txt ." | DOCKER_BUILDKIT=1 docker build -f- . [+] Building 2.5s (6/6) FINISHED => [internal] load build definition from Dockerfile 0.0s => => transferring dockerfile: 100B 0.0s => [internal] load .dockerignore 0.0s => => transferring context: 2B 0.0s => [internal] load metadata for docker.io/library/busybox:latest 1.2s => FROM docker.io/library/busybox:latest 1.2s => => resolve docker.io/library/busybox:latest 1.2s => CACHED [stage-0 1/2] FROM docker.io/library/busybox@sha256:4f47c01... 0.0s => ERROR [stage-0 2/2] COPY --from=busybox /some/non-existing/file.txt . 0.0s ------ > [stage-0 2/2] COPY --from=busybox /some/non-existing/file.txt .: ------ failed to compute cache key: failed to walk /var/lib/docker/overlay2/2a796d91e46fc038648c6010f062bdfd612ee62b0e8fe77bc632688e3fba32d9/merged/some/non-existing: lstat /var/lib/docker/overlay2/2a796d91e46fc038648c6010f062bdfd612ee62b0e8fe77bc632688e3fba32d9/merged/some/non-existing: no such file or directory Signed-off-by: Sebastiaan van Stijn <github@gone.nl>		2020-08-17 12:03:18 +02:00
..
builder-next	fix buildkit pull nil panic	2020-07-29 07:48:50 +08:00
dockerfile	Builder: print relative path if COPY/ADD source path was not found	2020-08-17 12:03:18 +02:00
dockerignore	Fix typos	2020-02-10 20:59:04 +08:00
remotecontext	builder/remotecontext: use lowercase for error	2020-08-11 10:46:18 +02:00
builder.go	Windows: (WCOW) Generate OCI spec that remote runtime can escape	2019-03-12 18:41:55 -07:00