mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
9465272c28
This helps ensure that `github.com/docker/docker/pkg/...` is actually safe to use in isolation (ie, doesn't import anything from `github.com/docker/docker` except other things from `pkg` or vendored dependencies). Adding `github.com/docker/docker/utils` to the imports of `pkg/version/version.go`: ``` ---> Making bundle: validate-pkg (in bundles/1.7.0-dev/validate-pkg) These files import internal code: (either directly or indirectly) - pkg/version/version.go imports github.com/docker/docker/autogen/dockerversion - pkg/version/version.go imports github.com/docker/docker/utils ``` And then removing it again: ``` ---> Making bundle: validate-pkg (in bundles/1.7.0-dev/validate-pkg) Congratulations! "./pkg/..." is safely isolated from internal code. ``` Signed-off-by: Andrew "Tianon" Page <admwiggin@gmail.com>
32 lines
736 B
Bash
32 lines
736 B
Bash
#!/bin/bash
|
|
set -e
|
|
|
|
source "${MAKEDIR}/.validate"
|
|
|
|
IFS=$'\n'
|
|
files=( $(validate_diff --diff-filter=ACMR --name-only -- 'pkg/*.go' || true) )
|
|
unset IFS
|
|
|
|
badFiles=()
|
|
for f in "${files[@]}"; do
|
|
IFS=$'\n'
|
|
badImports=( $(go list -e -f '{{ join .Deps "\n" }}' "$f" | sort -u | grep -vE '^github.com/docker/docker/pkg/' | grep -E '^github.com/docker/docker' || true) )
|
|
unset IFS
|
|
|
|
for import in "${badImports[@]}"; do
|
|
badFiles+=( "$f imports $import" )
|
|
done
|
|
done
|
|
|
|
if [ ${#badFiles[@]} -eq 0 ]; then
|
|
echo 'Congratulations! "./pkg/..." is safely isolated from internal code.'
|
|
else
|
|
{
|
|
echo 'These files import internal code: (either directly or indirectly)'
|
|
for f in "${badFiles[@]}"; do
|
|
echo " - $f"
|
|
done
|
|
echo
|
|
} >&2
|
|
false
|
|
fi
|