mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
3477da0cdb
This fix tries to address the issue raised in discussion of
PR 28735 where it was not possible to manage plugin based on
plugin ID. Previously it was not possible to invoke
`docker plugin inspect` with a plugin ID (or ID prefix).
This fix updates the implementation of `docker plugin inspect`
so that it is possbile to search based on a plugin name, or a
plugin ID. A short format of plugin ID (prefix) is also possible,
as long as there is no ambiguity.
Previously the check of `docker plugin inspect` was mostly done
on the client side. This could potentially cause inconsistency
between API and CMD. This fix move all the checks to daemon side
so that API and CMD will be consistent.
An integration test has been added to cover the changes.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
(cherry picked from commit 0ce6e070f7)
Signed-off-by: Victor Vieux <victorvieux@gmail.com>
252 lines
8.7 KiB
Go
252 lines
8.7 KiB
Go
package main
|
|
|
|
import (
|
|
"github.com/docker/docker/pkg/integration/checker"
|
|
"github.com/go-check/check"
|
|
|
|
"io/ioutil"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
)
|
|
|
|
var (
|
|
pluginProcessName = "no-remove"
|
|
pName = "tiborvass/no-remove"
|
|
pTag = "latest"
|
|
pNameWithTag = pName + ":" + pTag
|
|
)
|
|
|
|
func (s *DockerSuite) TestPluginBasicOps(c *check.C) {
|
|
testRequires(c, DaemonIsLinux, Network)
|
|
_, _, err := dockerCmdWithError("plugin", "install", "--grant-all-permissions", pNameWithTag)
|
|
c.Assert(err, checker.IsNil)
|
|
|
|
out, _, err := dockerCmdWithError("plugin", "ls")
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(out, checker.Contains, pName)
|
|
c.Assert(out, checker.Contains, pTag)
|
|
c.Assert(out, checker.Contains, "true")
|
|
|
|
id, _, err := dockerCmdWithError("plugin", "inspect", "-f", "{{.Id}}", pNameWithTag)
|
|
id = strings.TrimSpace(id)
|
|
c.Assert(err, checker.IsNil)
|
|
|
|
out, _, err = dockerCmdWithError("plugin", "remove", pNameWithTag)
|
|
c.Assert(out, checker.Contains, "is enabled")
|
|
|
|
_, _, err = dockerCmdWithError("plugin", "disable", pNameWithTag)
|
|
c.Assert(err, checker.IsNil)
|
|
|
|
out, _, err = dockerCmdWithError("plugin", "remove", pNameWithTag)
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(out, checker.Contains, pNameWithTag)
|
|
|
|
_, err = os.Stat(filepath.Join(dockerBasePath, "plugins", id))
|
|
if !os.IsNotExist(err) {
|
|
c.Fatal(err)
|
|
}
|
|
}
|
|
|
|
func (s *DockerSuite) TestPluginForceRemove(c *check.C) {
|
|
testRequires(c, DaemonIsLinux, Network)
|
|
out, _, err := dockerCmdWithError("plugin", "install", "--grant-all-permissions", pNameWithTag)
|
|
c.Assert(err, checker.IsNil)
|
|
|
|
out, _, err = dockerCmdWithError("plugin", "remove", pNameWithTag)
|
|
c.Assert(out, checker.Contains, "is enabled")
|
|
|
|
out, _, err = dockerCmdWithError("plugin", "remove", "--force", pNameWithTag)
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(out, checker.Contains, pNameWithTag)
|
|
}
|
|
|
|
func (s *DockerSuite) TestPluginActive(c *check.C) {
|
|
testRequires(c, DaemonIsLinux, Network, IsAmd64)
|
|
out, _, err := dockerCmdWithError("plugin", "install", "--grant-all-permissions", pNameWithTag)
|
|
c.Assert(err, checker.IsNil)
|
|
|
|
out, _, err = dockerCmdWithError("volume", "create", "-d", pNameWithTag)
|
|
c.Assert(err, checker.IsNil)
|
|
|
|
vID := strings.TrimSpace(out)
|
|
|
|
out, _, err = dockerCmdWithError("plugin", "remove", pNameWithTag)
|
|
c.Assert(out, checker.Contains, "is in use")
|
|
|
|
_, _, err = dockerCmdWithError("volume", "rm", vID)
|
|
c.Assert(err, checker.IsNil)
|
|
|
|
out, _, err = dockerCmdWithError("plugin", "remove", pNameWithTag)
|
|
c.Assert(out, checker.Contains, "is enabled")
|
|
|
|
_, _, err = dockerCmdWithError("plugin", "disable", pNameWithTag)
|
|
c.Assert(err, checker.IsNil)
|
|
|
|
out, _, err = dockerCmdWithError("plugin", "remove", pNameWithTag)
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(out, checker.Contains, pNameWithTag)
|
|
}
|
|
|
|
func (s *DockerSuite) TestPluginInstallDisable(c *check.C) {
|
|
testRequires(c, DaemonIsLinux, Network)
|
|
out, _, err := dockerCmdWithError("plugin", "install", "--grant-all-permissions", "--disable", pName)
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, pName)
|
|
|
|
out, _, err = dockerCmdWithError("plugin", "ls")
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(out, checker.Contains, "false")
|
|
|
|
out, _, err = dockerCmdWithError("plugin", "enable", pName)
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, pName)
|
|
|
|
out, _, err = dockerCmdWithError("plugin", "disable", pName)
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, pName)
|
|
|
|
out, _, err = dockerCmdWithError("plugin", "remove", pName)
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, pName)
|
|
}
|
|
|
|
func (s *DockerSuite) TestPluginInstallDisableVolumeLs(c *check.C) {
|
|
testRequires(c, DaemonIsLinux, Network)
|
|
out, _, err := dockerCmdWithError("plugin", "install", "--grant-all-permissions", "--disable", pName)
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, pName)
|
|
|
|
dockerCmd(c, "volume", "ls")
|
|
}
|
|
|
|
func (s *DockerSuite) TestPluginSet(c *check.C) {
|
|
testRequires(c, DaemonIsLinux, Network)
|
|
out, _ := dockerCmd(c, "plugin", "install", "--grant-all-permissions", "--disable", pName)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, pName)
|
|
|
|
env, _ := dockerCmd(c, "plugin", "inspect", "-f", "{{.Settings.Env}}", pName)
|
|
c.Assert(strings.TrimSpace(env), checker.Equals, "[DEBUG=0]")
|
|
|
|
dockerCmd(c, "plugin", "set", pName, "DEBUG=1")
|
|
|
|
env, _ = dockerCmd(c, "plugin", "inspect", "-f", "{{.Settings.Env}}", pName)
|
|
c.Assert(strings.TrimSpace(env), checker.Equals, "[DEBUG=1]")
|
|
}
|
|
|
|
func (s *DockerSuite) TestPluginInstallArgs(c *check.C) {
|
|
testRequires(c, DaemonIsLinux, Network)
|
|
out, _ := dockerCmd(c, "plugin", "install", "--grant-all-permissions", "--disable", pName, "DEBUG=1")
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, pName)
|
|
|
|
env, _ := dockerCmd(c, "plugin", "inspect", "-f", "{{.Settings.Env}}", pName)
|
|
c.Assert(strings.TrimSpace(env), checker.Equals, "[DEBUG=1]")
|
|
}
|
|
|
|
func (s *DockerSuite) TestPluginInstallImage(c *check.C) {
|
|
testRequires(c, DaemonIsLinux, Network)
|
|
out, _, err := dockerCmdWithError("plugin", "install", "redis")
|
|
c.Assert(err, checker.NotNil)
|
|
c.Assert(out, checker.Contains, "content is not a plugin")
|
|
}
|
|
|
|
func (s *DockerSuite) TestPluginEnableDisableNegative(c *check.C) {
|
|
testRequires(c, DaemonIsLinux, Network)
|
|
out, _, err := dockerCmdWithError("plugin", "install", "--grant-all-permissions", pName)
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, pName)
|
|
|
|
out, _, err = dockerCmdWithError("plugin", "enable", pName)
|
|
c.Assert(err, checker.NotNil)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, "already enabled")
|
|
|
|
_, _, err = dockerCmdWithError("plugin", "disable", pName)
|
|
c.Assert(err, checker.IsNil)
|
|
|
|
out, _, err = dockerCmdWithError("plugin", "disable", pName)
|
|
c.Assert(err, checker.NotNil)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, "already disabled")
|
|
|
|
_, _, err = dockerCmdWithError("plugin", "remove", pName)
|
|
c.Assert(err, checker.IsNil)
|
|
}
|
|
|
|
func (s *DockerSuite) TestPluginCreate(c *check.C) {
|
|
testRequires(c, DaemonIsLinux, Network)
|
|
|
|
name := "foo/bar-driver"
|
|
temp, err := ioutil.TempDir("", "foo")
|
|
c.Assert(err, checker.IsNil)
|
|
defer os.RemoveAll(temp)
|
|
|
|
data := `{"description": "foo plugin"}`
|
|
err = ioutil.WriteFile(filepath.Join(temp, "config.json"), []byte(data), 0644)
|
|
c.Assert(err, checker.IsNil)
|
|
|
|
out, _, err := dockerCmdWithError("plugin", "create", name, temp)
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(out, checker.Contains, name)
|
|
|
|
out, _, err = dockerCmdWithError("plugin", "ls")
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(out, checker.Contains, name)
|
|
|
|
out, _, err = dockerCmdWithError("plugin", "create", name, temp)
|
|
c.Assert(err, checker.NotNil)
|
|
c.Assert(out, checker.Contains, "already exist")
|
|
|
|
out, _, err = dockerCmdWithError("plugin", "ls")
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(out, checker.Contains, name)
|
|
// The output will consists of one HEADER line and one line of foo/bar-driver
|
|
c.Assert(len(strings.Split(strings.TrimSpace(out), "\n")), checker.Equals, 2)
|
|
}
|
|
|
|
func (s *DockerSuite) TestPluginInspect(c *check.C) {
|
|
testRequires(c, DaemonIsLinux, Network)
|
|
_, _, err := dockerCmdWithError("plugin", "install", "--grant-all-permissions", pNameWithTag)
|
|
c.Assert(err, checker.IsNil)
|
|
|
|
out, _, err := dockerCmdWithError("plugin", "ls")
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(out, checker.Contains, pName)
|
|
c.Assert(out, checker.Contains, pTag)
|
|
c.Assert(out, checker.Contains, "true")
|
|
|
|
// Find the ID first
|
|
out, _, err = dockerCmdWithError("plugin", "inspect", "-f", "{{.Id}}", pNameWithTag)
|
|
c.Assert(err, checker.IsNil)
|
|
id := strings.TrimSpace(out)
|
|
c.Assert(id, checker.Not(checker.Equals), "")
|
|
|
|
// Long form
|
|
out, _, err = dockerCmdWithError("plugin", "inspect", "-f", "{{.Id}}", id)
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(strings.TrimSpace(out), checker.Equals, id)
|
|
|
|
// Short form
|
|
out, _, err = dockerCmdWithError("plugin", "inspect", "-f", "{{.Id}}", id[:5])
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(strings.TrimSpace(out), checker.Equals, id)
|
|
|
|
// Name with tag form
|
|
out, _, err = dockerCmdWithError("plugin", "inspect", "-f", "{{.Id}}", pNameWithTag)
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(strings.TrimSpace(out), checker.Equals, id)
|
|
|
|
// Name without tag form
|
|
out, _, err = dockerCmdWithError("plugin", "inspect", "-f", "{{.Id}}", pName)
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(strings.TrimSpace(out), checker.Equals, id)
|
|
|
|
_, _, err = dockerCmdWithError("plugin", "disable", pNameWithTag)
|
|
c.Assert(err, checker.IsNil)
|
|
|
|
out, _, err = dockerCmdWithError("plugin", "remove", pNameWithTag)
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(out, checker.Contains, pNameWithTag)
|
|
|
|
// After remove nothing should be found
|
|
_, _, err = dockerCmdWithError("plugin", "inspect", "-f", "{{.Id}}", id[:5])
|
|
c.Assert(err, checker.NotNil)
|
|
}
|