mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
7cb96ba308
Validation of Mounts was only performed on container _creation_, not on container _start_. As a result, if the host-path no longer existed when the container was started, a directory was created in the given location. This is the wrong behavior, because when using the `Mounts` API, host paths should never be created, and an error should be produced instead. This patch adds a validation step on container start, and produces an error if the host path is not found. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
73 lines
2.8 KiB
Go
73 lines
2.8 KiB
Go
package volume
|
|
|
|
import (
|
|
"errors"
|
|
"io/ioutil"
|
|
"os"
|
|
"runtime"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/docker/docker/api/types/mount"
|
|
)
|
|
|
|
func TestValidateMount(t *testing.T) {
|
|
testDir, err := ioutil.TempDir("", "test-validate-mount")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(testDir)
|
|
|
|
cases := []struct {
|
|
input mount.Mount
|
|
expected error
|
|
}{
|
|
{mount.Mount{Type: mount.TypeVolume}, errMissingField("Target")},
|
|
{mount.Mount{Type: mount.TypeVolume, Target: testDestinationPath, Source: "hello"}, nil},
|
|
{mount.Mount{Type: mount.TypeVolume, Target: testDestinationPath}, nil},
|
|
{mount.Mount{Type: mount.TypeBind}, errMissingField("Target")},
|
|
{mount.Mount{Type: mount.TypeBind, Target: testDestinationPath}, errMissingField("Source")},
|
|
{mount.Mount{Type: mount.TypeBind, Target: testDestinationPath, Source: testSourcePath, VolumeOptions: &mount.VolumeOptions{}}, errExtraField("VolumeOptions")},
|
|
|
|
{mount.Mount{Type: mount.TypeBind, Source: testDir, Target: testDestinationPath}, nil},
|
|
{mount.Mount{Type: "invalid", Target: testDestinationPath}, errors.New("mount type unknown")},
|
|
{mount.Mount{Type: mount.TypeBind, Source: testSourcePath, Target: testDestinationPath}, errBindNotExist},
|
|
}
|
|
|
|
lcowCases := []struct {
|
|
input mount.Mount
|
|
expected error
|
|
}{
|
|
{mount.Mount{Type: mount.TypeVolume}, errMissingField("Target")},
|
|
{mount.Mount{Type: mount.TypeVolume, Target: "/foo", Source: "hello"}, nil},
|
|
{mount.Mount{Type: mount.TypeVolume, Target: "/foo"}, nil},
|
|
{mount.Mount{Type: mount.TypeBind}, errMissingField("Target")},
|
|
{mount.Mount{Type: mount.TypeBind, Target: "/foo"}, errMissingField("Source")},
|
|
{mount.Mount{Type: mount.TypeBind, Target: "/foo", Source: "c:\\foo", VolumeOptions: &mount.VolumeOptions{}}, errExtraField("VolumeOptions")},
|
|
{mount.Mount{Type: mount.TypeBind, Source: "c:\\foo", Target: "/foo"}, errBindNotExist},
|
|
{mount.Mount{Type: mount.TypeBind, Source: testDir, Target: "/foo"}, nil},
|
|
{mount.Mount{Type: "invalid", Target: "/foo"}, errors.New("mount type unknown")},
|
|
}
|
|
parser := NewParser(runtime.GOOS)
|
|
for i, x := range cases {
|
|
err := parser.ValidateMountConfig(&x.input)
|
|
if err == nil && x.expected == nil {
|
|
continue
|
|
}
|
|
if (err == nil && x.expected != nil) || (x.expected == nil && err != nil) || !strings.Contains(err.Error(), x.expected.Error()) {
|
|
t.Errorf("expected %q, got %q, case: %d", x.expected, err, i)
|
|
}
|
|
}
|
|
if runtime.GOOS == "windows" {
|
|
parser = &lcowParser{}
|
|
for i, x := range lcowCases {
|
|
err := parser.ValidateMountConfig(&x.input)
|
|
if err == nil && x.expected == nil {
|
|
continue
|
|
}
|
|
if (err == nil && x.expected != nil) || (x.expected == nil && err != nil) || !strings.Contains(err.Error(), x.expected.Error()) {
|
|
t.Errorf("expected %q, got %q, case: %d", x.expected, err, i)
|
|
}
|
|
}
|
|
}
|
|
}
|