mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
246d1eb58e
When the daemon is started, it looks at all the volumes and checks to see if any of them have mount options persisted to disk, and loads them from disk if it does. In some cases a volume will be created with an empty map causing the options file to be persisted and volume options set to a non-nil value on daemon restart... this causes problems later when the driver checks for a non-nil value to determine if it should try and mount with the persisted volume options. Ensures 2 things: 1. Instead of only checking nilness for the opts map, use `len` to make sure it is not an empty map, which we don't really need to persit. 2. An empty (or nulled) opts.json will not inadvertnatly set volume options on daemon restart. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
329 lines
6.6 KiB
Go
329 lines
6.6 KiB
Go
package local
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"os"
|
|
"path/filepath"
|
|
"reflect"
|
|
"runtime"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/docker/docker/pkg/mount"
|
|
)
|
|
|
|
func TestRemove(t *testing.T) {
|
|
// TODO Windows: Investigate why this test fails on Windows under CI
|
|
// but passes locally.
|
|
if runtime.GOOS == "windows" {
|
|
t.Skip("Test failing on Windows CI")
|
|
}
|
|
rootDir, err := ioutil.TempDir("", "local-volume-test")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(rootDir)
|
|
|
|
r, err := New(rootDir, 0, 0)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
vol, err := r.Create("testing", nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if err := r.Remove(vol); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
vol, err = r.Create("testing2", nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := os.RemoveAll(vol.Path()); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if err := r.Remove(vol); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if _, err := os.Stat(vol.Path()); err != nil && !os.IsNotExist(err) {
|
|
t.Fatal("volume dir not removed")
|
|
}
|
|
|
|
if l, _ := r.List(); len(l) != 0 {
|
|
t.Fatal("expected there to be no volumes")
|
|
}
|
|
}
|
|
|
|
func TestInitializeWithVolumes(t *testing.T) {
|
|
rootDir, err := ioutil.TempDir("", "local-volume-test")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(rootDir)
|
|
|
|
r, err := New(rootDir, 0, 0)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
vol, err := r.Create("testing", nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
r, err = New(rootDir, 0, 0)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
v, err := r.Get(vol.Name())
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if v.Path() != vol.Path() {
|
|
t.Fatal("expected to re-initialize root with existing volumes")
|
|
}
|
|
}
|
|
|
|
func TestCreate(t *testing.T) {
|
|
rootDir, err := ioutil.TempDir("", "local-volume-test")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(rootDir)
|
|
|
|
r, err := New(rootDir, 0, 0)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
cases := map[string]bool{
|
|
"name": true,
|
|
"name-with-dash": true,
|
|
"name_with_underscore": true,
|
|
"name/with/slash": false,
|
|
"name/with/../../slash": false,
|
|
"./name": false,
|
|
"../name": false,
|
|
"./": false,
|
|
"../": false,
|
|
"~": false,
|
|
".": false,
|
|
"..": false,
|
|
"...": false,
|
|
}
|
|
|
|
for name, success := range cases {
|
|
v, err := r.Create(name, nil)
|
|
if success {
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if v.Name() != name {
|
|
t.Fatalf("Expected volume with name %s, got %s", name, v.Name())
|
|
}
|
|
} else {
|
|
if err == nil {
|
|
t.Fatalf("Expected error creating volume with name %s, got nil", name)
|
|
}
|
|
}
|
|
}
|
|
|
|
r, err = New(rootDir, 0, 0)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
func TestValidateName(t *testing.T) {
|
|
r := &Root{}
|
|
names := map[string]bool{
|
|
"x": false,
|
|
"/testvol": false,
|
|
"thing.d": true,
|
|
"hello-world": true,
|
|
"./hello": false,
|
|
".hello": false,
|
|
}
|
|
|
|
for vol, expected := range names {
|
|
err := r.validateName(vol)
|
|
if expected && err != nil {
|
|
t.Fatalf("expected %s to be valid got %v", vol, err)
|
|
}
|
|
if !expected && err == nil {
|
|
t.Fatalf("expected %s to be invalid", vol)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestCreateWithOpts(t *testing.T) {
|
|
if runtime.GOOS == "windows" {
|
|
t.Skip()
|
|
}
|
|
|
|
rootDir, err := ioutil.TempDir("", "local-volume-test")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(rootDir)
|
|
|
|
r, err := New(rootDir, 0, 0)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if _, err := r.Create("test", map[string]string{"invalidopt": "notsupported"}); err == nil {
|
|
t.Fatal("expected invalid opt to cause error")
|
|
}
|
|
|
|
vol, err := r.Create("test", map[string]string{"device": "tmpfs", "type": "tmpfs", "o": "size=1m,uid=1000"})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
v := vol.(*localVolume)
|
|
|
|
dir, err := v.Mount("1234")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer func() {
|
|
if err := v.Unmount("1234"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}()
|
|
|
|
mountInfos, err := mount.GetMounts()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
var found bool
|
|
for _, info := range mountInfos {
|
|
if info.Mountpoint == dir {
|
|
found = true
|
|
if info.Fstype != "tmpfs" {
|
|
t.Fatalf("expected tmpfs mount, got %q", info.Fstype)
|
|
}
|
|
if info.Source != "tmpfs" {
|
|
t.Fatalf("expected tmpfs mount, got %q", info.Source)
|
|
}
|
|
if !strings.Contains(info.VfsOpts, "uid=1000") {
|
|
t.Fatalf("expected mount info to have uid=1000: %q", info.VfsOpts)
|
|
}
|
|
if !strings.Contains(info.VfsOpts, "size=1024k") {
|
|
t.Fatalf("expected mount info to have size=1024k: %q", info.VfsOpts)
|
|
}
|
|
break
|
|
}
|
|
}
|
|
|
|
if !found {
|
|
t.Fatal("mount not found")
|
|
}
|
|
|
|
if v.active.count != 1 {
|
|
t.Fatalf("Expected active mount count to be 1, got %d", v.active.count)
|
|
}
|
|
|
|
// test double mount
|
|
if _, err := v.Mount("1234"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if v.active.count != 2 {
|
|
t.Fatalf("Expected active mount count to be 2, got %d", v.active.count)
|
|
}
|
|
|
|
if err := v.Unmount("1234"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if v.active.count != 1 {
|
|
t.Fatalf("Expected active mount count to be 1, got %d", v.active.count)
|
|
}
|
|
|
|
mounted, err := mount.Mounted(v.path)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if !mounted {
|
|
t.Fatal("expected mount to still be active")
|
|
}
|
|
|
|
r, err = New(rootDir, 0, 0)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
v2, exists := r.volumes["test"]
|
|
if !exists {
|
|
t.Fatal("missing volume on restart")
|
|
}
|
|
|
|
if !reflect.DeepEqual(v.opts, v2.opts) {
|
|
t.Fatal("missing volume options on restart")
|
|
}
|
|
}
|
|
|
|
func TestRealodNoOpts(t *testing.T) {
|
|
rootDir, err := ioutil.TempDir("", "volume-test-reload-no-opts")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(rootDir)
|
|
|
|
r, err := New(rootDir, 0, 0)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if _, err := r.Create("test1", nil); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, err := r.Create("test2", nil); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
// make sure a file with `null` (.e.g. empty opts map from older daemon) is ok
|
|
if err := ioutil.WriteFile(filepath.Join(rootDir, "test2"), []byte("null"), 600); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if _, err := r.Create("test3", nil); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
// make sure an empty opts file doesn't break us too
|
|
if err := ioutil.WriteFile(filepath.Join(rootDir, "test3"), nil, 600); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if _, err := r.Create("test4", map[string]string{}); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
r, err = New(rootDir, 0, 0)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
for _, name := range []string{"test1", "test2", "test3", "test4"} {
|
|
v, err := r.Get(name)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
lv, ok := v.(*localVolume)
|
|
if !ok {
|
|
t.Fatalf("expected *localVolume got: %v", reflect.TypeOf(v))
|
|
}
|
|
if lv.opts != nil {
|
|
t.Fatalf("expected opts to be nil, got: %v", lv.opts)
|
|
}
|
|
if _, err := lv.Mount("1234"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
}
|