mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
e7479e3ab8
In cases where a logging plugin has crashed when the daemon tries to copy the container stdio to the logging plugin it returns a broken pipe error and any log entries that occurr while the plugin is down are lost. Fix this by opening read+write in the daemon so logs are not lost while the plugin is down. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
23 lines
790 B
Go
23 lines
790 B
Go
// +build linux freebsd
|
|
|
|
package logger // import "github.com/docker/docker/daemon/logger"
|
|
|
|
import (
|
|
"context"
|
|
"io"
|
|
|
|
"github.com/containerd/fifo"
|
|
"github.com/pkg/errors"
|
|
"golang.org/x/sys/unix"
|
|
)
|
|
|
|
func openPluginStream(a *pluginAdapter) (io.WriteCloser, error) {
|
|
// Make sure to also open with read (in addition to write) to avoid borken pipe errors on plugin failure.
|
|
// It is up to the plugin to keep track of pipes that it should re-attach to, however.
|
|
// If the plugin doesn't open for reads, then the container will block once the pipe is full.
|
|
f, err := fifo.OpenFifo(context.Background(), a.fifoPath, unix.O_RDWR|unix.O_CREAT|unix.O_NONBLOCK, 0700)
|
|
if err != nil {
|
|
return nil, errors.Wrapf(err, "error creating i/o pipe for log plugin: %s", a.Name())
|
|
}
|
|
return f, nil
|
|
}
|