mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
4f8c870d62
These showed locally when running `make validate`. CI doesn't seem to have the
same (possibly it's disabled in the configuration)
builder/fscache/fscache.go:618::error: github.com/docker/docker/vendor/github.com/tonistiigi/fsutil.StatInfo composite literal uses unkeyed fields (vet)
client/swarm_unlock_test.go:44::error: github.com/docker/docker/api/types/swarm.UnlockRequest composite literal uses unkeyed fields (vet)
client/swarm_unlock_test.go:20::error: github.com/docker/docker/api/types/swarm.UnlockRequest composite literal uses unkeyed fields (vet)
cmd/dockerd/daemon_unix.go:113::error: github.com/docker/docker/cmd/dockerd/hack.MalformedHostHeaderOverride composite literal uses unkeyed fields (vet)
cmd/dockerd/daemon_unix.go:110::error: github.com/docker/docker/cmd/dockerd/hack.MalformedHostHeaderOverride composite literal uses unkeyed fields (vet)
daemon/graphdriver/overlay/overlay.go:171::error: github.com/docker/docker/pkg/idtools.IDPair composite literal uses unkeyed fields (vet)
daemon/graphdriver/overlay/overlay.go:413::error: github.com/docker/docker/pkg/idtools.IDPair composite literal uses unkeyed fields (vet)
daemon/graphdriver/overlay2/overlay.go:203::error: github.com/docker/docker/pkg/idtools.IDPair composite literal uses unkeyed fields (vet)
daemon/graphdriver/overlay2/overlay.go:584::error: github.com/docker/docker/pkg/idtools.IDPair composite literal uses unkeyed fields (vet)
daemon/graphdriver/zfs/zfs.go:109::error: github.com/docker/docker/pkg/idtools.IDPair composite literal uses unkeyed fields (vet)
daemon/graphdriver/zfs/zfs.go:388::error: github.com/docker/docker/pkg/idtools.IDPair composite literal uses unkeyed fields (vet)
daemon/volumes_windows.go:27::error: github.com/docker/docker/pkg/idtools.IDPair composite literal uses unkeyed fields (vet)
integration/service/network_test.go:31::error: github.com/docker/docker/api/types/network.NetworkingConfig composite literal uses unkeyed fields (vet)
api/server/server.go:129:10⚠️ should not use basic type string as key in context.WithValue (golint)
integration/service/network_test.go:54::error: github.com/docker/docker/api/types/network.NetworkingConfig composite literal uses unkeyed fields (vet)
libcontainerd/client_daemon_linux.go:61::error: github.com/docker/docker/pkg/idtools.IDPair composite literal uses unkeyed fields (vet)
libcontainerd/client_daemon_linux.go:74::error: github.com/docker/docker/pkg/idtools.IDPair composite literal uses unkeyed fields (vet)
pkg/archive/archive_windows.go:76::error: github.com/docker/docker/pkg/idtools.IDPair composite literal uses unkeyed fields (vet)
plugin/manager_linux.go:56::error: github.com/docker/docker/pkg/idtools.IDPair composite literal uses unkeyed fields (vet)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
51 lines
1.5 KiB
Go
51 lines
1.5 KiB
Go
package daemon // import "github.com/docker/docker/daemon"
|
|
|
|
import (
|
|
"sort"
|
|
|
|
"github.com/docker/docker/api/types/mount"
|
|
"github.com/docker/docker/container"
|
|
"github.com/docker/docker/pkg/idtools"
|
|
volumemounts "github.com/docker/docker/volume/mounts"
|
|
)
|
|
|
|
// setupMounts configures the mount points for a container by appending each
|
|
// of the configured mounts on the container to the OCI mount structure
|
|
// which will ultimately be passed into the oci runtime during container creation.
|
|
// It also ensures each of the mounts are lexicographically sorted.
|
|
|
|
// BUGBUG TODO Windows containerd. This would be much better if it returned
|
|
// an array of runtime spec mounts, not container mounts. Then no need to
|
|
// do multiple transitions.
|
|
|
|
func (daemon *Daemon) setupMounts(c *container.Container) ([]container.Mount, error) {
|
|
var mnts []container.Mount
|
|
for _, mount := range c.MountPoints { // type is volumemounts.MountPoint
|
|
if err := daemon.lazyInitializeVolume(c.ID, mount); err != nil {
|
|
return nil, err
|
|
}
|
|
s, err := mount.Setup(c.MountLabel, idtools.IDPair{UID: 0, GID: 0}, nil)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
mnts = append(mnts, container.Mount{
|
|
Source: s,
|
|
Destination: mount.Destination,
|
|
Writable: mount.RW,
|
|
})
|
|
}
|
|
|
|
sort.Sort(mounts(mnts))
|
|
return mnts, nil
|
|
}
|
|
|
|
// setBindModeIfNull is platform specific processing which is a no-op on
|
|
// Windows.
|
|
func setBindModeIfNull(bind *volumemounts.MountPoint) {
|
|
return
|
|
}
|
|
|
|
func (daemon *Daemon) validateBindDaemonRoot(m mount.Mount) (bool, error) {
|
|
return false, nil
|
|
}
|