1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
moby--moby/client
Sebastiaan van Stijn 0ea7b143b0
Don't use AutoRemove on older daemons
Docker 1.13 moves the `--rm` flag to the daemon,
through an AutoRemove option in HostConfig.

When using API 1.24 and under, AutoRemove should not be
used, even if the daemon is version 1.13 or above and
"supports" this feature.

This patch fixes a situation where an 1.13 client,
talking to an 1.13 daemon, but using the 1.24 API
version, still set the AutoRemove property.

As a result, both the client _and_ the daemon
were attempting to remove the container, resulting
in an error:

    ERRO[0000] error removing container: Error response from daemon:
    removal of container ce0976ad22495c7cbe9487752ea32721a282164862db036b2f3377bd07461c3a
    is already in progress

In addition, the validation of conflicting options
is moved from `docker run` to `opts.parse()`, so
that conflicting options are also detected when
running `docker create` and `docker start` separately.

To resolve the issue, the `AutoRemove` option is now
always set to `false` both by the client and the
daemon, if API version 1.24 or under is used.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2017-01-15 01:59:57 +01:00
..
testdata
checkpoint_create.go
checkpoint_create_test.go
checkpoint_delete.go
checkpoint_delete_test.go
checkpoint_list.go
checkpoint_list_test.go
client.go Change tls to TLS 2016-12-20 22:08:07 +08:00
client_mock_test.go
client_test.go Change tls to TLS 2016-12-20 22:08:07 +08:00
client_unix.go
client_windows.go
container_attach.go
container_commit.go Use IDResponse for container create response. 2016-10-31 11:16:02 -04:00
container_commit_test.go expected new_container_id while testing ContainerCommit 2016-11-18 10:21:04 +08:00
container_copy.go
container_copy_test.go Optimize the log info for client test 2016-12-02 03:32:04 +08:00
container_create.go Don't use AutoRemove on older daemons 2017-01-15 01:59:57 +01:00
container_create_test.go Don't use AutoRemove on older daemons 2017-01-15 01:59:57 +01:00
container_diff.go
container_diff_test.go
container_exec.go always add but hide experimental cmds and flags 2016-11-08 04:55:27 -08:00
container_exec_test.go Add an IDResponse type 2016-10-31 11:16:02 -04:00
container_export.go
container_export_test.go
container_inspect.go
container_inspect_test.go expected new_container_id while testing ContainerCommit 2016-11-18 10:21:04 +08:00
container_kill.go
container_kill_test.go
container_list.go Replace all "Filter" field with "Filters" for consistency 2016-11-01 23:09:30 +08:00
container_list_test.go Replace all "Filter" field with "Filters" for consistency 2016-11-01 23:09:30 +08:00
container_logs.go
container_logs_test.go
container_pause.go
container_pause_test.go
container_prune.go Convert DanglingOnly to Filters for docker image prune 2016-12-02 20:08:49 -08:00
container_prune_test.go Add --filter until=<timestamp> for docker container/image prune 2017-01-04 14:16:42 -08:00
container_remove.go
container_remove_test.go
container_rename.go
container_rename_test.go
container_resize.go
container_resize_test.go
container_restart.go
container_restart_test.go
container_start.go
container_start_test.go
container_stats.go Tidy GetDockerOS() function 2016-11-09 14:46:53 -08:00
container_stats_test.go
container_stop.go
container_stop_test.go
container_top.go
container_top_test.go
container_unpause.go
container_unpause_test.go
container_update.go Generate container update response from swagger spec. 2016-10-31 11:16:02 -04:00
container_update_test.go Generate container update response from swagger spec. 2016-10-31 11:16:02 -04:00
container_wait.go Generate ContainerWait response from the swagger spec. 2016-10-31 11:19:53 -04:00
container_wait_test.go Generate ContainerWait response from the swagger spec. 2016-10-31 11:19:53 -04:00
disk_usage.go
errors.go change minor mistake of spelling 2016-12-20 21:05:19 +08:00
events.go Fixes a race condition in client events monitoring 2016-12-16 10:11:53 -05:00
events_test.go
hijack.go Refactor client/request 2016-10-31 17:36:49 -04:00
image_build.go Update docs and code to use application/x-tar in the build API 2017-01-10 06:40:06 +02:00
image_build_test.go Update docs and code to use application/x-tar in the build API 2017-01-10 06:40:06 +02:00
image_create.go
image_create_test.go
image_history.go
image_history_test.go
image_import.go
image_import_test.go expected new_container_id while testing ContainerCommit 2016-11-18 10:21:04 +08:00
image_inspect.go
image_inspect_test.go
image_list.go Fixes ImageList to be retro-compatible with older API 2016-11-28 22:15:50 +01:00
image_list_test.go Fixes ImageList to be retro-compatible with older API 2016-11-28 22:15:50 +01:00
image_load.go
image_load_test.go
image_prune.go Convert DanglingOnly to Filters for docker image prune 2016-12-02 20:08:49 -08:00
image_prune_test.go Add --filter until=<timestamp> for docker container/image prune 2017-01-04 14:16:42 -08:00
image_pull.go
image_pull_test.go
image_push.go
image_push_test.go
image_remove.go
image_remove_test.go
image_save.go
image_save_test.go
image_search.go
image_search_test.go api/types/container,client: gofmt 2016-12-05 17:00:36 +02:00
image_tag.go check both source_image_tag and target_image_tag for 'docker image tag' 2017-01-07 04:55:53 +08:00
image_tag_test.go check both source_image_tag and target_image_tag for 'docker image tag' 2017-01-07 04:55:53 +08:00
info.go
info_test.go api: types: keep info.SecurityOptions a string slice 2016-11-19 13:21:16 +01:00
interface.go Add SecretUpdate method to client 2017-01-13 09:51:05 -08:00
interface_experimental.go move plugins out of experimental 2016-11-10 15:51:32 -08:00
interface_stable.go
login.go Fix the inconsistent function name for client 2016-12-02 04:18:02 +08:00
network_connect.go
network_connect_test.go
network_create.go
network_create_test.go
network_disconnect.go
network_disconnect_test.go
network_inspect.go
network_inspect_test.go expected new_container_id while testing ContainerCommit 2016-11-18 10:21:04 +08:00
network_list.go
network_list_test.go
network_prune.go Convert DanglingOnly to Filters for docker image prune 2016-12-02 20:08:49 -08:00
network_prune_test.go Add --filter until=<timestamp> for docker container/image prune 2017-01-04 14:16:42 -08:00
network_remove.go
network_remove_test.go
node_inspect.go
node_inspect_test.go change minor mistake of spelling 2016-12-20 21:05:19 +08:00
node_list.go Replace all "Filter" field with "Filters" for consistency 2016-11-01 23:09:30 +08:00
node_list_test.go Replace all "Filter" field with "Filters" for consistency 2016-11-01 23:09:30 +08:00
node_remove.go
node_remove_test.go
node_update.go
node_update_test.go
ping.go change minor mistake of spelling 2016-12-20 21:05:19 +08:00
plugin_create.go Update docs and code to use application/x-tar in the build API 2017-01-10 06:40:06 +02:00
plugin_disable.go Enforce zero plugin refcount during disable. 2016-12-22 13:26:53 -08:00
plugin_disable_test.go Enforce zero plugin refcount during disable. 2016-12-22 13:26:53 -08:00
plugin_enable.go Add HTTP client timeout. 2016-11-21 13:11:40 -08:00
plugin_enable_test.go Add HTTP client timeout. 2016-11-21 13:11:40 -08:00
plugin_inspect.go Merge pull request #28963 from vieux/refactor_plugin_install 2016-12-05 12:00:29 -08:00
plugin_inspect_test.go
plugin_install.go Implement content addressability for plugins 2016-12-23 13:29:58 -08:00
plugin_list.go
plugin_list_test.go
plugin_push.go Implement content addressability for plugins 2016-12-23 13:29:58 -08:00
plugin_push_test.go Implement content addressability for plugins 2016-12-23 13:29:58 -08:00
plugin_remove.go
plugin_remove_test.go expected new_container_id while testing ContainerCommit 2016-11-18 10:21:04 +08:00
plugin_set.go
plugin_set_test.go
README.md Rename Remote API to Engine API 2016-11-22 12:49:38 +00:00
request.go Fix the inconsistent function name for client 2016-12-02 04:18:02 +08:00
request_test.go
secret_create.go update secret create url for consistency 2016-11-18 10:18:21 +08:00
secret_create_test.go update secret create url for consistency 2016-11-18 10:18:21 +08:00
secret_inspect.go secrets: secret management for swarm 2016-11-09 14:27:43 -05:00
secret_inspect_test.go change minor mistake of spelling 2016-12-20 21:05:19 +08:00
secret_list.go review updates 2016-11-09 14:27:45 -05:00
secret_list_test.go review updates 2016-11-09 14:27:45 -05:00
secret_remove.go secrets: secret management for swarm 2016-11-09 14:27:43 -05:00
secret_remove_test.go secrets: secret management for swarm 2016-11-09 14:27:43 -05:00
secret_update.go Add SecretUpdate method to client 2017-01-13 09:51:05 -08:00
secret_update_test.go Add SecretUpdate method to client 2017-01-13 09:51:05 -08:00
service_create.go
service_create_test.go
service_inspect.go
service_inspect_test.go change minor mistake of spelling 2016-12-20 21:05:19 +08:00
service_list.go Replace all "Filter" field with "Filters" for consistency 2016-11-01 23:09:30 +08:00
service_list_test.go Replace all "Filter" field with "Filters" for consistency 2016-11-01 23:09:30 +08:00
service_logs.go api: Service Logs support 2016-11-10 13:46:02 -08:00
service_logs_test.go api: Service Logs support 2016-11-10 13:46:02 -08:00
service_remove.go
service_remove_test.go
service_update.go Return warnings from service create and service update when digest pinning fails 2016-11-18 09:31:31 -08:00
service_update_test.go Return warnings from service create and service update when digest pinning fails 2016-11-18 09:31:31 -08:00
swarm_get_unlock_key.go Revise swarm init/update flags, add unlocking capability 2016-11-09 16:09:00 -08:00
swarm_init.go Change tls to TLS 2016-12-20 22:08:07 +08:00
swarm_init_test.go
swarm_inspect.go Change tls to TLS 2016-12-20 22:08:07 +08:00
swarm_inspect_test.go
swarm_join.go Change tls to TLS 2016-12-20 22:08:07 +08:00
swarm_join_test.go
swarm_leave.go Change tls to TLS 2016-12-20 22:08:07 +08:00
swarm_leave_test.go
swarm_unlock.go Add support for swarm init lock and swarm unlock 2016-11-09 16:09:00 -08:00
swarm_update.go Change tls to TLS 2016-12-20 22:08:07 +08:00
swarm_update_test.go
task_inspect.go
task_inspect_test.go
task_list.go Replace all "Filter" field with "Filters" for consistency 2016-11-01 23:09:30 +08:00
task_list_test.go Replace all "Filter" field with "Filters" for consistency 2016-11-01 23:09:30 +08:00
transport.go Merge pull request #29565 from yuexiao-wang/fix-typo-tls 2016-12-22 12:10:09 +01:00
utils.go Convert DanglingOnly to Filters for docker image prune 2016-12-02 20:08:49 -08:00
version.go
volume_create.go
volume_create_test.go
volume_inspect.go
volume_inspect_test.go
volume_list.go
volume_list_test.go
volume_prune.go Convert DanglingOnly to Filters for docker image prune 2016-12-02 20:08:49 -08:00
volume_remove.go always add but hide experimental cmds and flags 2016-11-08 04:55:27 -08:00
volume_remove_test.go

Go client for the Docker Engine API

The docker command uses this package to communicate with the daemon. It can also be used by your own Go applications to do anything the command-line interface does  running containers, pulling images, managing swarms, etc.

For example, to list running containers (the equivalent of docker ps):

package main

import (
	"context"
	"fmt"

	"github.com/docker/docker/api/types"
	"github.com/docker/docker/client"
)

func main() {
	cli, err := client.NewEnvClient()
	if err != nil {
		panic(err)
	}

	containers, err := cli.ContainerList(context.Background(), types.ContainerListOptions{})
	if err != nil {
		panic(err)
	}

	for _, container := range containers {
		fmt.Printf("%s %s\n", container.ID[:10], container.Image)
	}
}

Full documentation is available on GoDoc.